GSoC/kolibrios-nvme-driver
2
0
Fork 0
mirror of https://git.missingno.dev/kolibrios-nvme-driver/ synced 2025-02-02 02:20:09 +01:00
Code Issues 2 Actions Activity

refactor(nvme_cleanup): add proper cleanup

Browse Source
This commit is contained in:
Abdur-Rahman Mansoor 2024-08-02 14:01:20 -04:00
parent e1ad8f643d
commit b2f63c4997
1 changed files with 51 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

63
drivers/nvme/nvme.asm
View File

@ -1250,21 +1250,60 @@ endp
proc nvme_cleanup proc nvme_cleanup
DEBUGF DBG_INFO, "(NVMe): Cleaning up...\n" mov esi, dword [p_nvme_devices]
mov ecx, dword [pcidevs_len] test esi, esi
mov eax, dword [p_nvme_devices] jnz @f
test eax, eax
jnz .loop
ret ret
.loop:
;invoke KernelFree, dword [p_nvme_devices + ecx * sizeof.pcidev + pcidev.ident_ptr]
dec ecx
test ecx, ecx
jnz .loop
invoke KernelFree, dword [p_nvme_devices]
@@: @@:
mov ebx, dword [pcidevs_len]
sub esi, sizeof.pcidev
.get_pcidev:
add esi, sizeof.pcidev
; Free the queues
mov edi, dword [esi + pcidev.queue_entries]
test edi, edi
jz .free_pcidevs
sub edi, sizeof.NVM_QUEUE_ENTRY
xor ecx, ecx
.get_queue:
add edi, sizeof.NVM_QUEUE_ENTRY
; TODO: Delete the I/O completion and submission queue
; Remember, we have to free the completion queue before
; the submission queue
push ecx
invoke KernelFree, dword [edi + NVM_QUEUE_ENTRY.cq_ptr]
invoke KernelFree, dword [edi + NVM_QUEUE_ENTRY.sq_ptr]
pop ecx
; Free the commands and their respective mutexes
push edi ecx
xor ecx, ecx
mov edi, dword [edi + NVM_QUEUE_ENTRY.cmd_ptr]
sub edi, sizeof.NVMQCMD
.get_cmd:
add edi, sizeof.NVMQCMD
push ecx
invoke KernelFree, dword [edi + NVMQCMD.mutex_ptr]
pop ecx
inc ecx
cmp ecx, SQ_ENTRIES
jne .get_cmd
pop ecx edi
inc ecx
cmp ecx, LAST_QUEUE_ID
jne .get_queue
invoke KernelFree, dword [esi + pcidev.queue_entries]
.free_pcidevs:
invoke KernelFree, dword [p_nvme_devices]
ret ret
endp endp