GSoC/kolibrios-nvme-driver
2
0
Fork 0
mirror of https://git.missingno.dev/kolibrios-nvme-driver/ synced 2026-03-09 04:43:25 +00:00
Code Issues 2 Actions Activity

System freеzеs when trying to delete a deleted folder #3

New Issue
Closed
opened 2024-08-09 10:34:57 +00:00 by Burer · 2 comments
Burer commented 2024-08-09 10:34:57 +00:00
Copy Link

Discovered this bug while testing driver with commit 37ea6e2d16 in VirtualBox.

It is a bit tricky, so I decided to add a separate issue for it, and here are the exact steps to reproduce:

  1. Opened NVMe drive from Linux (using VirtualBox, not real installation).
  2. Deleted some folders and files, shut down Linux.
  3. Opened same drive in KolibriOS - deleted files are displayed in some kind of hidden folder.
  4. Tried to delete it - system froze in process.

Not sure what is the reason of problem, maybe it is just me doing something wrong, but decided to share it here just in case.

Discovered this bug while testing driver with commit 37ea6e2d16 in VirtualBox. It is a bit tricky, so I decided to add a separate issue for it, and here are the exact steps to reproduce: 1. Opened NVMe drive from Linux (using VirtualBox, not real installation). 2. Deleted some folders and files, shut down Linux. 3. Opened same drive in KolibriOS - deleted files are displayed in some kind of hidden folder. 4. Tried to delete it - system froze in process. Not sure what is the reason of problem, maybe it is just me doing something wrong, but decided to share it here just in case.
nvme_37ea6e2d16_virtualbox_3.png
136 KiB
nvme_37ea6e2d16_virtualbox_3.png
Burer changed title from System crash when trying to delete a deleted folder to System freеzе when trying to delete a deleted folder 2024-08-09 10:42:51 +00:00
ramenu commented 2024-08-09 13:53:19 +00:00
Member
Copy Link

I think this is related to #1 (comment) but I'm not sure.

I'll add a new commit providing very verbose logs later, it will impact performance considerably, but at least it will provide us some insight about what the issue may be, rather than just making assumptions. If it's too much though let me know and I will decrease it. :)

I think this is related to https://git.kolibrios.org/GSoC/kolibrios-nvme-driver/issues/1#issuecomment-471 but I'm not sure. I'll add a new commit providing very verbose logs later, it will impact performance considerably, but at least it will provide us some insight about what the issue may be, rather than just making assumptions. If it's too much though let me know and I will decrease it. :)
👍 1
ramenu self-assigned this 2024-08-09 13:54:08 +00:00
Sweetbread changed title from System freеzе when trying to delete a deleted folder to System freеzеs when trying to delete a deleted folder 2024-08-10 16:57:30 +00:00
Burer commented 2024-08-12 18:26:33 +00:00
Author
Copy Link

Followup of #6 (comment).
Tried with commit c02d64b35a and freshly created deleted folder. Both deletion and copying run smoothly, so this problem looks to be solved, at least for me in VirtualBox.
Will also try in VMWare and update this post later.
UPD. Also tested on VMWare. ISO image with manual driver and no debug output on screen, and IMG image with driver autoload and debug output on screen. Both works fine for deletion and copying.

Followup of https://git.kolibrios.org/GSoC/kolibrios-nvme-driver/issues/6#issuecomment-520. Tried with commit c02d64b35a and freshly created deleted folder. Both deletion and copying run smoothly, so this problem looks to be solved, at least for me in VirtualBox. Will also try in VMWare and update this post later. UPD. Also tested on VMWare. ISO image with manual driver and no debug output on screen, and IMG image with driver autoload and debug output on screen. Both works fine for deletion and copying.
nvme_c02d64b35a_virtualbox_1.png
114 KiB
nvme_c02d64b35a_virtualbox_1.png
👍 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
dunkaist ramenu Sweetbread
No Assignees ramenu
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GSoC/kolibrios-nvme-driver#3
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?