KolibriOS/kolibrios
15
21
Fork 36
Code Issues 129 Pull Requests 31 Actions 2 Projects 1 Releases Wiki Activity

TinyGL: #223

Merged
mxlgv merged 1 commits from tinygl-optimize into main 2025-05-04 18:00:08 +00:00
Conversation 5 Commits 1 Files Changed 23 +1155 -722
IgorA commented 2025-04-29 19:02:48 +00:00
Member
Copy Link

TinyGL:

  • Fixed setting of GL_FRONT_AND_BACK mode;
  • Fixed setting of GL_SPOT_DIRECTION angle;
  • Optimization of drawing triangles and lines;
  • Input parameters are adjusted to the OpenGL standard in gluCylinder and gluSphere functions;
  • Added gluDisk function (The gluDisk function draws a disk-shaped quadric figure. Essentially, a disk is the same cylinder with zero height, but its texture coordinates do not coincide with the cylinder, so a separate function is needed);
  • Optimize function calc_buf;
  • Clean code.

Flag:

  • Added lighting.

info3ds, info3ds_u, test_glu0, test_glu1, test_glu2,
textures0, textures1, textures2:

  • Updated programs using gluCylinder and gluSphere.
TinyGL: - Fixed setting of `GL_FRONT_AND_BACK` mode; - Fixed setting of `GL_SPOT_DIRECTION` angle; - Optimization of drawing triangles and lines; - Input parameters are adjusted to the OpenGL standard in `gluCylinder` and `gluSphere` functions; - Added `gluDisk` function (The gluDisk function draws a disk-shaped quadric figure. Essentially, a disk is the same cylinder with zero height, but its texture coordinates do not coincide with the cylinder, so a separate function is needed); - Optimize function `calc_buf`; - Clean code. Flag: - Added lighting. info3ds, info3ds_u, test_glu0, test_glu1, test_glu2, textures0, textures1, textures2: - Updated programs using `gluCylinder` and `gluSphere`.
IgorA added 1 commit 2025-04-29 19:02:51 +00:00
TinyGL:
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 36s
Details
Build system / Build (pull_request) Successful in 8m44s
Details
1756212605 
- fixed setting of 'GL_FRONT_AND_BACK' mode
- fixed setting of 'GL_SPOT_DIRECTION' angle
- optimization of drawing triangles and lines
- fixes in 'gluCylinder' and 'gluSphere' functions
- 'gluDisk' function added
- updated programs using 'gluCylinder' and 'gluSphere'
- optimize function 'calc_buf'
- clean code
Flag: add lighting
dunkaist approved these changes 2025-04-29 21:08:42 +00:00
Dismissed
mxlgv requested changes 2025-04-30 00:50:20 +00:00
Dismissed
mxlgv left a comment
Owner
Copy Link

For now, the question is: is there a versioning of the library and do these changes violate the ABI?

I have no complaints about the changes themselves. The patch is huge, but the changes are related. However, the description seems a bit vague to me. Could you clarify some things. Exactly what was fixed and why it was added. And what programs were the changes made to and why.

Look at the commit. It would be nice if it looked something like this: 03cfdeb50f

Ignore things like

Reviewed-on: #210
Reviewed-by: Max Logaev <maxlogaev@proton.me>
Co-authored-by: IgorA <aie85playm@gmail.com>
Co-committed-by: IgorA <aie85playm@gmail.com>

and (#210)

This is generated by gitea on merge.

For now, the question is: is there a versioning of the library and do these changes violate the ABI? I have no complaints about the changes themselves. The patch is huge, but the changes are related. However, the description seems a bit vague to me. Could you clarify some things. Exactly what was fixed and why it was added. And what programs were the changes made to and why. Look at the commit. It would be nice if it looked something like this: https://git.kolibrios.org/KolibriOS/kolibrios/commit/03cfdeb50fcb8d21cc851ad594029bd378b90903 Ignore things like ``` Reviewed-on: #210 Reviewed-by: Max Logaev <maxlogaev@proton.me> Co-authored-by: IgorA <aie85playm@gmail.com> Co-committed-by: IgorA <aie85playm@gmail.com> ``` and `(#210)` This is generated by gitea on merge.
mxlgv added the
PR
Request changes
 label 2025-04-30 00:51:39 +00:00
IgorA commented 2025-04-30 06:35:19 +00:00
Author
Member
Copy Link

changed the description according to the sample

changed the description according to the sample
IgorA force-pushed tinygl-optimize from 1756212605 to f44f6c982b 2025-04-30 11:02:23 +00:00 Compare
IgorA dismissed dunkaist's review 2025-04-30 11:02:24 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

IgorA commented 2025-04-30 11:02:55 +00:00
Author
Member
Copy Link

For now, the question is: is there a versioning of the library and do these changes violate the ABI?

There are no versions in the library. Determined by revision.
Binary compatibility with programs is broken. 'gluCylinder' and 'gluSphere' functions took incorrect parameters:
gluCylinder ;(GLUquadricObj, double*, double*, double*, int, int)
gluSphere ;(GLUquadricObj, float, int, int)

It is correct to accept such parameters:
gluCylinder ;(GLUquadricObj, double, double, double, int, int)
gluSphere ;(GLUquadricObj, double, int, int)

> For now, the question is: is there a versioning of the library and do these changes violate the ABI? There are no versions in the library. Determined by revision. Binary compatibility with programs is broken. 'gluCylinder' and 'gluSphere' functions took incorrect parameters: gluCylinder ;(GLUquadricObj, double*, double*, double*, int, int) gluSphere ;(GLUquadricObj, float, int, int) It is correct to accept such parameters: gluCylinder ;(GLUquadricObj, double, double, double, int, int) gluSphere ;(GLUquadricObj, double, int, int)
IgorA force-pushed tinygl-optimize from f44f6c982b to f42e35f19a 2025-05-01 19:56:22 +00:00 Compare
IgorA force-pushed tinygl-optimize from f42e35f19a to ce66c14c59 2025-05-02 19:14:00 +00:00 Compare
IgorA force-pushed tinygl-optimize from ce66c14c59 to 0c6fca2d92 2025-05-04 14:32:54 +00:00 Compare
mxlgv approved these changes 2025-05-04 17:39:48 +00:00
mxlgv scheduled this pull request to auto merge when all checks succeed 2025-05-04 17:49:44 +00:00
mxlgv force-pushed tinygl-optimize from 0c6fca2d92 to 062aa527fb 2025-05-04 17:50:05 +00:00 Compare
mxlgv canceled auto merging this pull request when all checks succeed 2025-05-04 17:51:02 +00:00
mxlgv added
PR
Ready to merge
 and removed
PR
Request changes
 labels 2025-05-04 17:53:04 +00:00
mxlgv scheduled this pull request to auto merge when all checks succeed 2025-05-04 17:56:40 +00:00
mxlgv canceled auto merging this pull request when all checks succeed 2025-05-04 17:56:46 +00:00
mxlgv merged commit c18da5afae into main 2025-05-04 18:00:08 +00:00
mxlgv deleted branch tinygl-optimize 2025-05-04 18:00:08 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
mxlgv
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
PR
Ready to merge
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#223
Delete Branch "tinygl-optimize"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?