Update defined filetype icons #226

New Issue

2025-05-03T09:38:11Z

ace-dent commented

2025-05-03 09:38:11 +00:00

We define many file types to have specific icons:
https://git.kolibrios.org/KolibriOS/kolibrios/src/branch/main/data/common/File%20Managers/icons.ini

Is it misleading to provide specific icons for files not supported by any programs in the OS? For uncommon and 'un-loadable' files, perhaps a generic blank file type icon is better?
Should the list be tailored at build time for Floppy / Full distros, depending on file support?
Can the list be reduced by smarter use of substring or wildcard matching? e.g. jpe and jpeg.
The list should also be reviewed for missing common types.

We define many file types to have specific icons: https://git.kolibrios.org/KolibriOS/kolibrios/src/branch/main/data/common/File%20Managers/icons.ini - [x] Is it misleading to provide specific icons for files not supported by any programs in the OS? For uncommon and 'un-loadable' files, perhaps a generic blank file type icon is better? - [x] Should the list be tailored at build time for Floppy / Full distros, depending on file support? - [x] Can the list be reduced by smarter use of substring or wildcard matching? e.g. `jpe` and `jpeg`. - [x] The list should also be reviewed for missing common types.

ace-dent added the

labels 2025-05-03 09:38:11 +00:00

Leency commented

2026-06-23 15:55:36 +00:00

It would be very nice to have

3=doc,docx,exc,inf,log,ob07,odt,rtf,txt,wtx

instead of

doc=3
docx=3
exc=3
inf=3
log=3
ob07=3
ob7=3
odt=3
rtf=3
txt=3
wtx=3

but this change requires fixing both Eolite and OpenDial.

It would be very nice to have 3=doc,docx,exc,inf,log,ob07,odt,rtf,txt,wtx instead of doc=3 docx=3 exc=3 inf=3 log=3 ob07=3 ob7=3 odt=3 rtf=3 txt=3 wtx=3 but this change requires fixing both Eolite and OpenDial.

icons.ini

1.3 KiB

Leency commented

2026-06-23 16:03:06 +00:00

Can the list be reduced by smarter use of substring or wildcard matching? e.g. jpe and jpeg.

Small benefit. Risk of wrong ext detection.

> Can the list be reduced by smarter use of substring or wildcard matching? e.g. jpe and jpeg. Small benefit. Risk of wrong ext detection.

Leency commented

2026-06-27 23:12:36 +00:00

It would be very nice to have

3=doc,docx,exc,inf,log,ob07,odt,rtf,txt,wtx

instead of

doc=3
docx=3
exc=3
inf=3
log=3
ob07=3
ob7=3
odt=3
rtf=3
txt=3
wtx=3

but this change requires fixing both Eolite and OpenDial.

#534

> It would be very nice to have > > 3=doc,docx,exc,inf,log,ob07,odt,rtf,txt,wtx > > instead of > > doc=3 > docx=3 > exc=3 > inf=3 > log=3 > ob07=3 > ob7=3 > odt=3 > rtf=3 > txt=3 > wtx=3 > > but this change requires fixing both Eolite and OpenDial. #534

Leency commented

2026-06-27 23:14:17 +00:00

Is it misleading to provide specific icons for files not supported by any programs in the OS? For uncommon and 'un-loadable' files, perhaps a generic blank file type icon is better?

That's fine.

Should the list be tailored at build time for Floppy / Full distros, depending on file support?

Nope, lets keep it simple.

Can the list be reduced by smarter use of substring or wildcard matching? e.g. jpe and jpeg.

No.

The list should also be reviewed for missing common types.

Probably yes.

> Is it misleading to provide specific icons for files not supported by any programs in the OS? For uncommon and 'un-loadable' files, perhaps a generic blank file type icon is better? That's fine. > Should the list be tailored at build time for Floppy / Full distros, depending on file support? Nope, lets keep it simple. > Can the list be reduced by smarter use of substring or wildcard matching? e.g. jpe and jpeg. No. > The list should also be reviewed for missing common types. Probably yes.

Leency closed this issue

2026-06-27 23:14:17 +00:00

ace-dent referenced a pull request that will close this issue

2026-06-27 23:37:01 +00:00

data/icons.ini: transform format to icon2ext.ini (fix #226) #534

Burer commented

2026-06-28 05:53:33 +00:00

Can the list be reduced by smarter use of substring or wildcard matching? e.g. jpe and jpeg.

In fact, such functionality was especially dropped last year, as it matched the wrong extensions (e.g., each extension starting with c was matched as a C source code file).

> - [x] Can the list be reduced by smarter use of substring or wildcard matching? e.g. jpe and `jpeg`. In fact, such functionality was especially dropped last year, as it matched the wrong extensions (e.g., each extension starting with `c` was matched as a C source code file).

👍 1

Burer referenced a pull request that will close this issue

2026-06-28 05:54:16 +00:00

data/icons.ini: transform format to icon2ext.ini (fix #226) #534

Burer referenced this issue from a commit

2026-07-12 06:00:36 +00:00

data/icons.ini: transform format to icon2ext.ini (fix #226) (#534)

Sign in to join this conversation.