KolibriOS/kolibrios
15
21
Fork 36
Code Issues 129 Pull Requests 31 Actions 2 Projects 1 Releases Wiki Activity

Game/Invaders: Review unused graphic asset #236

New Issue
Open
opened 2025-05-15 11:19:50 +00:00 by ace-dent · 0 comments
ace-dent commented 2025-05-15 11:19:50 +00:00
Member
Copy Link

When reviewing the code for Invaders I spotted a possible typo.

kolibrios/programs/games/invaders/invaders.asm Lines 1469 to 1472 in 4550e15838
gif_bullet file 'bullet2.gif'
.size = $ - gif_bullet
gif_bullet2 file 'bullet2.gif'
.size = $ - gif_bullet2

  • Investigate what was the author's original intent? Should there be 2 bullet types?
  • Possibly delete the unused GIF image bullet, rename bullet2 and clean-up code.
When reviewing the code for `Invaders` I spotted a possible typo. https://git.kolibrios.org/KolibriOS/kolibrios/src/commit/4550e15838c11a6e5f7d1236783dcd062d964516/programs/games/invaders/invaders.asm#L1469-L1472 - [ ] Investigate what was the author's original intent? Should there be 2 bullet types? - [ ] Possibly delete the unused GIF image `bullet`, rename `bullet2` and clean-up code.
ace-dent added the
Priority
Low
Category/Applications
Kind
Enhancement
 labels 2025-05-15 11:19:50 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label Category/Applications
Kind
Enhancement
Priority
Low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#236
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?