KolibriOS/kolibrios
15
24
Fork 61
Code Issues 128 Pull Requests 31 Actions Projects 1 Releases Wiki Activity

Game/Invaders: Review unused graphic asset #236

New Issue
Closed
opened 2025-05-15 11:19:50 +00:00 by ace-dent · 3 comments
ace-dent commented 2025-05-15 11:19:50 +00:00
Member
Copy Link
Copy Source

When reviewing the code for Invaders I spotted a possible typo.

kolibrios/programs/games/invaders/invaders.asm Lines 1469 to 1472 in 4550e15838
gif_bullet file 'bullet2.gif'
.size = $ - gif_bullet
gif_bullet2 file 'bullet2.gif'
.size = $ - gif_bullet2

  • Investigate what was the author's original intent? Should there be 2 bullet types?
  • Possibly delete the unused GIF image bullet, rename bullet2 and clean-up code.
When reviewing the code for `Invaders` I spotted a possible typo. https://git.kolibrios.org/KolibriOS/kolibrios/src/commit/4550e15838c11a6e5f7d1236783dcd062d964516/programs/games/invaders/invaders.asm#L1469-L1472 - [ ] Investigate what was the author's original intent? Should there be 2 bullet types? - [ ] Possibly delete the unused GIF image `bullet`, rename `bullet2` and clean-up code.
ace-dent added the
Priority
Low
Category/Applications
Kind
Enhancement
 labels 2025-05-15 11:19:50 +00:00
hidnplayr commented 2026-05-11 21:17:44 +00:00
Member
Copy Link
Copy Source

Yes, there were supposed to be two bullet types.
One being bullet from user to enemies, and the other vice-versa (described as enemy shoot-back here: https://wiki.kolibrios.org/wiki/Invaders).

Yes, there were supposed to be two bullet types. One being bullet from user to enemies, and the other vice-versa (described as enemy shoot-back here: https://wiki.kolibrios.org/wiki/Invaders).
ace-dent commented 2026-05-12 10:59:06 +00:00
Author
Member
Copy Link
Copy Source

@hidnplayr - thanks for the extra information. Are you happy for this unused resource to be removed, or will it be used in future?

@hidnplayr - thanks for the extra information. Are you happy for this unused resource to be removed, or will it be used in future?
hidnplayr commented 2026-05-12 16:11:05 +00:00
Member
Copy Link
Copy Source

I have no further plans to develop this game any time soon.
It was written mostly as an exercise for myself in FASM.

Why you want to spend the effort to remove this unused image is beyond me (especially since game is no longer in floppy distribution).
You may do as you please.

I have no further plans to develop this game any time soon. It was written mostly as an exercise for myself in FASM. Why you want to spend the effort to remove this unused image is beyond me (especially since game is no longer in floppy distribution). You may do as you please.
Burer closed this issue 2026-05-16 08:37:39 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label Category/Applications
Kind
Enhancement
Priority
Low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent (Andrew) Burer Doczom (Mikhail Frolov) dunkaist (Ivan B) Egor00f (Егор) hidnplayr IgorA Leency (Kiril Lipatov) mxlgv (Max Logaev) ramenu rgimad sdongles (Serhii Sakhno) Sweetbread (Gleb Zaharov)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#236
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?