KolibriOS/kolibrios
15
21
Fork 36
Code Issues 129 Pull Requests 31 Actions 1 Projects 1 Releases Wiki Activity

OpenDial: Incorrect work with icons.ini #96

New Issue
Closed
opened 2025-02-10 18:02:02 +00:00 by Burer · 3 comments
Burer commented 2025-02-10 18:02:02 +00:00
Owner
Copy Link

OpenDial have some strange behavior with files of certain extensions.
Specifically, files with c extension don't have proper icon with default icons.ini.
But if c selector is moved before dic selector, everything works as intended.
Maybe this problem occurs with any other combination of selectors, but currently I was able to reproduce it only with c and dic.

P.S. Independent of this bug, I suggest sorting all selectors in icons.ini in alphabetical order, just for easier navigation.

OpenDial have some strange behavior with files of certain extensions. Specifically, files with `c` extension don't have proper icon with default `icons.ini`. But if `c` selector is moved before `dic` selector, everything works as intended. Maybe this problem occurs with any other combination of selectors, but currently I was able to reproduce it only with `c` and `dic`. P.S. Independent of this bug, I suggest sorting all selectors in `icons.ini` in alphabetical order, just for easier navigation.
opendial_icons_bug_2.jpg
97 KiB
opendial_icons_bug_1.jpg
96 KiB
opendial_icons_bug_2.jpg opendial_icons_bug_1.jpg
Burer added the Category/Applications
Kind
Bug
Priority
Low
 labels 2025-02-10 18:02:26 +00:00
dunkaist added reference main 2025-02-10 18:05:45 +00:00
dunkaist commented 2025-02-11 00:27:49 +00:00
Owner
Copy Link

'dic=3' has 'c=3' as its substring. The File browser widget of box_lib is happy with that. The bug is in fb_get_icon_number.

'dic=3' has 'c=3' as its substring. The File browser widget of box_lib is happy with that. The bug is in [fb_get_icon_number](https://github.com/KolibriOS/kolibrios/blob/main/programs/develop/libraries/box_lib/trunk/filebrowser.asm#L761).
👍 1
dunkaist commented 2025-02-11 21:18:59 +00:00
Owner
Copy Link

Should be fixed in 195f996c1b. Please, check https://builds.kolibrios.org/en_US/data/data/

Should be fixed in https://git.kolibrios.org/KolibriOS/kolibrios/commit/195f996c1b5d634e09e55cd000688f8d333baac2. Please, check https://builds.kolibrios.org/en_US/data/data/
👍 1
Burer commented 2025-02-12 17:10:22 +00:00
Author
Owner
Copy Link

Tested .iso image with commit 195f996. Seems to be fixed.
Also, sorted icons.ini in c07e2a9857 by order icon_number->file_extension.

Tested .iso image with commit 195f996. Seems to be fixed. Also, sorted icons.ini in c07e2a9857 by order icon_number->file_extension.
👍 1
Burer closed this issue 2025-02-12 17:10:22 +00:00
Sign in to join this conversation.
main
Branches Tags
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label Category/Applications
Kind
Bug
Priority
Low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#96
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?