KolibriOS/kolibrios
15
24
Fork 61
Code Issues 126 Pull Requests 38 Actions Projects 1 Releases Wiki Activity

[Apps/Pipet] Fixed wrong window colors on some skins and optimized size #162

Merged
mxlgv merged 6 commits from apps-pipet-fix-colors into main 2025-03-19 23:18:29 +00:00
Conversation 7 Commits 6 Files Changed 2
+56 -92
Burer commented 2025-03-17 17:02:16 +00:00
Owner
Copy Link
Copy Source

Fixed wrong window colors on some skins.
Example with Oasis skin is attached.

Fixed wrong window colors on some skins. Example with Oasis skin is attached.
image.png
33 KiB
image.png
Burer added the
Kind
Enhancement
FASMCategory/Applications labels 2025-03-17 17:02:16 +00:00
Burer requested review from dunkaist 2025-03-17 17:02:19 +00:00
Burer requested review from Leency 2025-03-17 17:02:20 +00:00
Burer requested review from mxlgv 2025-03-17 17:02:20 +00:00
Sweetbread changed title from WIP [Apps/Piped] Fixed wrong window colors on some skins to WIP: [Apps/Piped] Fixed wrong window colors on some skins 2025-03-17 18:01:56 +00:00
Burer changed title from WIP: [Apps/Piped] Fixed wrong window colors on some skins to WIP: [Apps/Piped] Fixed wrong window colors on some skins and optimized size 2025-03-18 13:22:02 +00:00
Burer marked the pull request as ready for review 2025-03-18 14:08:43 +00:00
Burer force-pushed apps-pipet-fix-colors from 33b264b880 to 89fb19caaf 2025-03-18 14:09:06 +00:00 Compare
Burer changed title from [Apps/Piped] Fixed wrong window colors on some skins and optimized size to [Apps/Pipet] Fixed wrong window colors on some skins and optimized size 2025-03-18 14:11:45 +00:00
mxlgv reviewed 2025-03-18 14:27:45 +00:00
programs/other/pipet/pipet.asm
@@ -232,10 +218,10 @@ draw_update:
jle .du_loop_rect_row
mov ebx, 118 * 65536 + 12
mxlgv commented 2025-03-18 14:27:45 +00:00
Owner
Copy Link
Copy Source

May be use 118 SHL 16?

May be use `118 SHL 16`?
Burer commented 2025-03-18 14:30:28 +00:00
Author
Owner
Copy Link
Copy Source

Is it an overall FASM recommendation?
I found current style more reasonable, as it is same to sysfuncs description on Wiki.

PS: Would be good to have some kind of macros, to use something like mov reg <X, Y>, similar to mcalls

Is it an overall FASM recommendation? I found current style more reasonable, as it is same to sysfuncs description on Wiki. PS: Would be good to have some kind of macros, to use something like `mov reg <X, Y>`, similar to mcalls
👍 1
Burer marked this conversation as resolved
mxlgv reviewed 2025-03-18 14:36:48 +00:00
programs/other/pipet/pipet.asm Outdated
@@ -499,3 +483,3 @@
if lang eq ru_RU
header db '����⪠', 0
header db '�¨¯¥âª ', 0
mxlgv commented 2025-03-18 14:36:48 +00:00
Owner
Copy Link
Copy Source

If you're interested, in the programms root there is encoding.inc.. If you use it for example:
https://git.kolibrios.org/KolibriOS/kolibrios/src/branch/main/kernel/trunk/data32.inc#L51. Then you can save the file in UTF-8 encoding

If you're interested, in the `programms` root there is `encoding.inc.`. If you use it for example: https://git.kolibrios.org/KolibriOS/kolibrios/src/branch/main/kernel/trunk/data32.inc#L51. Then you can save the file in UTF-8 encoding
Burer commented 2025-03-18 14:39:40 +00:00
Author
Owner
Copy Link
Copy Source

Got it, thank you!
Definitely will use in next commits.

Got it, thank you! Definitely will use in next commits.
🚀 1
Burer marked this conversation as resolved
mxlgv approved these changes 2025-03-18 15:14:28 +00:00
Dismissed
mxlgv added the
PR
Ready to merge
 label 2025-03-18 15:15:24 +00:00
mxlgv added
PR
Review required
 and removed
PR
Ready to merge
 labels 2025-03-18 15:17:47 +00:00
mxlgv commented 2025-03-18 15:22:40 +00:00
Owner
Copy Link
Copy Source

Waiting for review and approval from @Leency

Waiting for review and approval from @Leency
Leency dismissed mxlgv's review 2025-03-18 20:14:59 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Leency commented 2025-03-18 20:29:30 +00:00
Owner
Copy Link
Copy Source

@mxlgv it was working well, and now it is with my changes)

@mxlgv it was working well, and now it is with my changes)
Burer marked the pull request as work in progress 2025-03-19 06:33:23 +00:00
Burer marked the pull request as ready for review 2025-03-19 06:35:36 +00:00
Burer force-pushed apps-pipet-fix-colors from 3b98fd7e25 to d4cd8cb00e 2025-03-19 06:36:26 +00:00 Compare
mxlgv approved these changes 2025-03-19 15:13:49 +00:00
Dismissed
mxlgv force-pushed apps-pipet-fix-colors from d4cd8cb00e to 440d63aade 2025-03-19 22:43:24 +00:00 Compare
mxlgv approved these changes 2025-03-19 23:05:40 +00:00
mxlgv added
PR
Ready to merge
 and removed
PR
Review required
 labels 2025-03-19 23:05:59 +00:00
mxlgv merged commit af41fe4aa7 into main 2025-03-19 23:18:29 +00:00
mxlgv deleted branch apps-pipet-fix-colors 2025-03-19 23:18:30 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
dunkaist
Leency
mxlgv
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label Category/Applications FASM
Kind
Enhancement
PR
Ready to merge
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent (Andrew) Burer Doczom (Mikhail Frolov) dunkaist (Ivan B) hidnplayr IgorA Leency (Kiril Lipatov) mxlgv (Max Logaev) ramenu rgimad sdongles (Serhii Sakhno) Sweetbread (Gleb Zaharov)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#162
Delete Branch "apps-pipet-fix-colors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?