KolibriOS/kolibrios
15
24
Fork 61
Code Issues 132 Pull Requests 31 Actions Projects 1 Releases Wiki Activity

WIP: programs/system: Post-SVN tidy #246

Closed
ace-dent wants to merge 30 commits from ace-dent:PR-CleanupSVN-2 into main
pull from: ace-dent:PR-CleanupSVN-2
merge into: KolibriOS:main
Conversation 6 Commits 30 Files Changed 171
+562006 -10053
ace-dent commented 2025-05-19 19:19:11 +00:00
Member
Copy Link
Copy Source

DO NOT MERGE! This monolithic PR will be split into smaller sets.

  • Move source code from trunk into program root directory.
  • Fix build and ASM files. Add SPDX license header where appropriate.
  • Note: Line endings standardised from CRLF > LF, so best to view diffs with whitespace changes hidden.

(Work towards #75, point 3)

DO NOT MERGE! This monolithic PR will be split into smaller sets. - Move source code from `trunk` into program root directory. - Fix build and ASM files. Add SPDX license header where appropriate. - Note: Line endings standardised from `CRLF` > `LF`, so best to view diffs with whitespace changes hidden. (Work towards #75, point 3)
ace-dent added the
Kind
Build
Category/Applications
Priority
Low
 labels 2025-05-19 19:19:11 +00:00
ace-dent force-pushed PR-CleanupSVN-2 from 1aaabf3b8a to d89aff7458 2025-05-20 18:08:21 +00:00 Compare
ace-dent force-pushed PR-CleanupSVN-2 from d89aff7458 to 03da8574be 2025-05-20 18:13:58 +00:00 Compare
ace-dent added 1 commit 2025-05-20 18:24:39 +00:00
system/MyKey: Post-SVN clean up
Build system / Build (pull_request) Successful in 4m23s
Details
Build system / Check kernel codestyle (pull_request) Successful in 22s
Details
311de65cb6 
- Fix ASM include paths.
- Note: Line endings standardised from `CRLF` > `LF`, so best to view diffs with whitespace changes hidden.
ace-dent added 4 commits 2025-05-20 19:21:00 +00:00
system/run: Post-SVN clean up 3ea561f6b5 
- Move source code from `trunk` into program root directory.
- Update build files and ASM include paths.
system/setup: Post-SVN clean up e780abaac1 
- Move source code from `trunk` into program root directory.
- Update build files and ASM include paths.
system/skincfg: Post-SVN clean up c475a94751 
- Move source code from `trunk` into program root directory.
- Update build files and ASM include paths.
system/taskbar: Post-SVN clean up
Build system / Check kernel codestyle (pull_request) Successful in 21s
Details
Build system / Build (pull_request) Failing after 42s
Details
5e946ad5ea 
- Move source code from `trunk` into program root directory.
- Update build files and ASM include paths.
ace-dent added 3 commits 2025-05-20 19:52:24 +00:00
system/skincfg: Post-SVN clean up 810ff2d356 
- Fix ASM include paths; code reused in more places.
- Note: Line endings standardised from `CRLF` > `LF`, so best to view diffs with whitespace changes hidden.
system/zkey: Post-SVN clean up b434807d61 
- Move source code from `trunk` into program root directory.
- Update build files and ASM include paths.
system/end: Post-SVN clean up
Build system / Check kernel codestyle (pull_request) Successful in 23s
Details
Build system / Build (pull_request) Failing after 53s
Details
e030e6a32f 
- Move source code from `trunk` into program root directory.
- Update build files and ASM include paths.
ace-dent added 1 commit 2025-05-20 19:56:36 +00:00
system/run: Post-SVN clean up
Build system / Check kernel codestyle (pull_request) Successful in 20s
Details
Build system / Build (pull_request) Failing after 3h12m59s
Details
9c49034f74 
- Fix ASM include paths.
ace-dent changed title from WIP: Post-SVN cleanup (Part 2) to programs/system: Post-SVN cleanup 2025-05-20 20:02:34 +00:00
ace-dent commented 2025-05-20 20:29:19 +00:00
Author
Member
Copy Link
Copy Source

Updates these programs:

  • system/board
  • system/calendar
  • system/cpu
  • system/docky
  • system/docpack
  • system/end
  • system/eskin
  • system/hdd_info
  • system/icon
  • system/kobra
  • system/launch
  • system/launcher
  • system/menu
  • system/mousemul
  • system/MyKey
  • system/rdsave
  • system/run
  • system/setup
  • system/skincfg
  • system/taskbar
  • system/zkey
Updates these programs: - `system/board` - `system/calendar` - `system/cpu` - `system/docky` - `system/docpack` - `system/end` - `system/eskin` - `system/hdd_info` - `system/icon` - `system/kobra` - `system/launch` - `system/launcher` - `system/menu` - `system/mousemul` - `system/MyKey` - `system/rdsave` - `system/run` - `system/setup` - `system/skincfg` - `system/taskbar` - `system/zkey`
❤️ 1
Leency commented 2025-05-20 20:35:50 +00:00
Owner
Copy Link
Copy Source

Mega like for this change!❤️👍👍👍

Mega like for this change!❤️👍👍👍
🎉 1
ace-dent added 1 commit 2025-05-20 20:42:01 +00:00
system/board: Post-SVN clean up
Build system / Check kernel codestyle (pull_request) Successful in 29s
Details
Build system / Build (pull_request) Successful in 4m37s
Details
4ccd395af2 
- Fix ASM include paths.
- Note: Line endings standardised from `CRLF` > `LF`, so best to view diffs with whitespace changes hidden.
ace-dent requested review from Burer 2025-05-20 21:04:34 +00:00
ace-dent requested review from Leency 2025-05-20 21:04:35 +00:00
ace-dent requested review from Sweetbread 2025-05-20 21:04:35 +00:00
ace-dent added the
PR
Review required
 label 2025-05-20 21:04:45 +00:00
ace-dent changed title from programs/system: Post-SVN cleanup to programs/system: Post-SVN tidy 2025-05-20 21:07:03 +00:00
ace-dent commented 2025-05-23 13:21:25 +00:00
Author
Member
Copy Link
Copy Source

Putting back to WIP. I need to ensure we preserve the git file history for system/eskin.asm

Putting back to WIP. I need to ensure we preserve the git file history for `system/eskin.asm`
ace-dent marked the pull request as work in progress 2025-05-23 13:21:32 +00:00
ace-dent added
PR
Request changes
 and removed
PR
Review required
 labels 2025-05-23 13:21:49 +00:00
ace-dent added 1 commit 2025-05-23 13:31:18 +00:00
Revert "system/eskin: Post-SVN clean up"
Build system / Check kernel codestyle (pull_request) Successful in 22s
Details
Build system / Build (pull_request) Failing after 48s
Details
7aba2a0850 
This reverts commit e01add279b.
ace-dent added 1 commit 2025-05-23 13:39:28 +00:00
system/eskin: Post-SVN clean up
Build system / Check kernel codestyle (pull_request) Successful in 20s
Details
Build system / Build (pull_request) Successful in 4m16s
Details
9d55345605 
- Update ASM include paths. Minimal changes to ensure git maintains file history.
- Note: file still has ‘odd’ line endings with many trailing whitespaces.
ace-dent added
PR
Review required
 and removed
PR
Request changes
 labels 2025-05-23 15:11:17 +00:00
ace-dent marked the pull request as ready for review 2025-05-23 15:11:27 +00:00
ace-dent commented 2025-05-23 15:14:31 +00:00
Author
Member
Copy Link
Copy Source

As discussed with @Sweetbread on Discord: https://discord.com/channels/631286773720416295/844285887218450482/1375488167351685180
Squash all but the last commit when merging.

As discussed with @Sweetbread on Discord: https://discord.com/channels/631286773720416295/844285887218450482/1375488167351685180 Squash all but the last commit when merging.
ace-dent added 1 commit 2025-05-31 21:16:47 +00:00
programs/system: Post-SVN tidy
Build system / Check kernel codestyle (pull_request) Successful in 1m24s
Details
Build system / Build (pull_request) Successful in 6m37s
Details
fc655c8c11 
- Tidy `build_all.bat` build file; comment out absent programs.
ace-dent requested review from dunkaist 2026-04-08 22:12:59 +00:00
ace-dent marked the pull request as work in progress 2026-04-08 23:01:13 +00:00
ace-dent removed review request for Burer 2026-04-08 23:01:21 +00:00
ace-dent removed review request for Leency 2026-04-08 23:01:30 +00:00
ace-dent removed review request for Sweetbread 2026-04-08 23:01:41 +00:00
ace-dent removed review request for dunkaist 2026-04-08 23:01:50 +00:00
ace-dent removed the
PR
Review required
 label 2026-04-08 23:12:40 +00:00
dunkaist approved these changes 2026-04-09 01:03:20 +00:00
contrib/C_Layer/ASM/loadboxlib.asm
@@ -159,8 +162,8 @@ public path_show_draw as '_path_show_draw'
public fb_draw_panel as '_filebrowse_draw'
public fb_mouse as '_filebrowse_mouse'
public fb_key as '_filebrowse_key'
dunkaist commented 2026-04-09 00:57:59 +00:00
Owner
Copy Link
Copy Source

What has been changed in this line?

What has been changed in this line?
ace-dent commented 2026-04-09 08:29:13 +00:00
Author
Member
Copy Link
Copy Source

Thanks @dunkaist - That line was not changed!?... I have double-checked. Perhaps an issue with how Gitea is displaying it? However, no need to review this PR - it is being replaced by multiple smaller ones!

Thanks @dunkaist - That line was not changed!?... I have double-checked. Perhaps an issue with how Gitea is displaying it? However, no need to review this PR - it is being replaced by multiple smaller ones!
ace-dent commented 2026-04-10 10:13:22 +00:00
Author
Member
Copy Link
Copy Source

Closing monolithic PR, as it has been merged in 3 parts: #408 #410 #413
Thanks to the entire team for testing, feedback and support. 🙏

Closing monolithic PR, as it has been merged in 3 parts: #408 #410 #413 Thanks to the entire team for testing, feedback and support. 🙏
ace-dent closed this pull request 2026-04-10 10:13:22 +00:00
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 1m24s
Required
Details
Build system / Build (pull_request) Successful in 6m37s
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
dunkaist
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label Category/Applications
Kind
Build
Priority
Low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent (Andrew) Burer Doczom (Mikhail Frolov) dunkaist (Ivan B) Egor00f (Егор) hidnplayr IgorA Leency (Kiril Lipatov) mxlgv (Max Logaev) ramenu rgimad sdongles (Serhii Sakhno) Sweetbread (Gleb Zaharov)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#246
Delete Branch "ace-dent:PR-CleanupSVN-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?