KolibriOS/kolibrios
15
21
Fork 36
Code Issues 129 Pull Requests 31 Actions 1 Projects 1 Releases Wiki Activity

apps/piano: refactoring and improvement #302

Merged
mxlgv merged 7 commits from rewrite-piano into main 2026-03-07 20:10:52 +00:00
Conversation 6 Commits 7 Files Changed 5 +4 -8
3 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 38b47500ce - Show all commits

3
.asm-lsp.toml Normal file
View File

@@ -0,0 +1,3 @@
[default_config]
assembler = "fasm"
instruction_set = "x86"

3
programs/media/piano/keymap.asm
View File

@@ -2,9 +2,6 @@
;
; Piano - Default Keymap (256 bytes)
; Copyright (C) 2025 KolibriOS team
;
; Contributor Burer - Main code
; Contributor Doczom - Idea
; ====================================================================
mxlgv marked this conversation as resolved Outdated
mxlgv commented 2026-02-21 20:34:07 +00:00
Outdated
Review
Copy Link

Move co-authors to the commit body

Move co-authors to the commit body

6
programs/media/piano/piano.asm
View File

@@ -3,11 +3,7 @@
; Piano - Toy Piano
; Copyright (C) 2019-2025 KolibriOS team
;
; Contributor ??? - Initial code
; Contributor Antonio - Refactoring and new functionality
; Contributor Burer - Refactoring and Spanish translation
; Contributor Doczom - Refactoring and bugfixes
; Contributor qullarwee - New keyboard layout
; Authors: Antonio and Leency
mxlgv marked this conversation as resolved Outdated
mxlgv commented 2026-02-21 19:10:31 +00:00
Outdated
Review
Copy Link

I read several pages of the topic and concluded that the program was actually authored by Antonio, with support from Leency. The original code is an example that has nothing in common with the piano developed by Antonio and Leency. Therefore, I propose listing them as the authors:

; Authors: Antonio and Leency
I read several pages of the [topic](https://board.kolibrios.org/viewtopic.php?t=3831) and concluded that the program was actually authored by Antonio, with support from Leency. The original code is an example that has nothing in common with the piano developed by Antonio and Leency. Therefore, I propose listing them as the authors: ```asm ; Authors: Antonio and Leency ```
; ====================================================================
mxlgv marked this conversation as resolved Outdated
mxlgv commented 2026-02-21 19:14:02 +00:00
Outdated
Review
Copy Link

Your changes will already be stored using git. Just add the people who helped you as "Co-authored-by" in commit body.

Your changes will already be stored using git. Just add the people who helped you as "Co-authored-by" in commit body.