KolibriOS/kolibrios
15
21
Fork 36
Code Issues 129 Pull Requests 31 Actions 1 Projects 1 Releases Wiki Activity

system/docs: update docs and SF constants to match actual kernel #306

Merged
Burer merged 9 commits from docs-review into main 2026-02-26 17:25:20 +00:00
Conversation 10 Commits 9 Files Changed 3 +6 -6
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 3b8f9b67db - Show all commits

6
kernel/trunk/docs/sysfuncr.txt
View File

@@ -5054,7 +5054,7 @@ Architecture Software Developer's Manual, Volume 3, Appendix B);
Параметры:
* eax = 77 - номер функции
* ebx = 0 - номер подфункции
* ecx = указатель на контрольное значение фьютекса (dword)
mxlgv marked this conversation as resolved Outdated
mxlgv commented 2026-01-24 20:10:00 +00:00
Outdated
Review
Copy Link

There is no mistake here. Reverse this change

There is no mistake here. Reverse this change
* ecx = контрольное значение фьютекса (dword)
mxlgv marked this conversation as resolved Outdated
mxlgv commented 2026-01-27 22:50:34 +00:00
Outdated
Review
Copy Link

It’s true that this is a pointer to dword. Anything larger than dword will probably be ignored.

It’s true that this is a pointer to dword. Anything larger than dword will probably be ignored.
Возвращаемое значение:
* eax = дескриптор фьютекса, 0 при ошибке
mxlgv marked this conversation as resolved Outdated
mxlgv commented 2026-01-27 22:52:20 +00:00
Outdated
Review
Copy Link

I apologize, it seems I expressed myself incorrectly. Everything here is correct; it is a descriptor and not a pointer (it doesn’t matter to us how this is implemented in the kernel); even just a pointer can be considered a “descriptor”. Please roll back

I apologize, it seems I expressed myself incorrectly. Everything here is correct; it is a descriptor and not a pointer (it doesn’t matter to us how this is implemented in the kernel); even just a pointer can be considered a “descriptor”. Please roll back
@@ -5083,7 +5083,7 @@ Architecture Software Developer's Manual, Volume 3, Appendix B);
* eax = 77 - номер функции
* ebx = 2 - номер подфункции
* ecx = дескриптор фьютекса
mxlgv marked this conversation as resolved Outdated
mxlgv commented 2026-01-27 22:53:05 +00:00
Outdated
Review
Copy Link

Please roll back. See message above

Please roll back. See message above
* edx = указатель на контрольное значение фьютекса (dword)
* edx = контрольное значение фьютекса (dword)
* esi = таймаут в сотых секунды, 0 - ждать бесконечно
Возвращаемое значение:
* eax = 0 - успешно,
@@ -5112,7 +5112,7 @@ Architecture Software Developer's Manual, Volume 3, Appendix B);
* Подфункции 4-7 зарезервированы и сейчас возвращают -1.
mxlgv marked this conversation as resolved
mxlgv commented 2026-01-24 20:13:21 +00:00
Review
Copy Link

Add here that for now only pipe file descriptors are supported

Add here that for now only pipe file descriptors are supported
* Подфункции 8, 9 и 12 не реализованы и возвращают -EBADF (-9).
======================================================================
======= Функция 77, подфункция 10, Прочитать из файла. =======
=========== Функция 77, подфункция 10, Прочитать из файла. ===========
mxlgv marked this conversation as resolved Outdated
mxlgv commented 2026-01-27 22:58:27 +00:00
Outdated
Review
Copy Link

Seems missing ====

Seems missing `====`
======================================================================
Параметры:
* eax = 77 - номер функции

6
kernel/trunk/docs/sysfuncs.txt
View File

@@ -5268,7 +5268,7 @@ Returned value:
Parameters:
* eax = 77 - function number
* ebx = 0 - subfunction number
* ecx = pointer to futex control value (dwort)
* ecx = futex control value (dword)
mxlgv marked this conversation as resolved Outdated
mxlgv commented 2026-01-27 23:13:52 +00:00
Outdated
Review
Copy Link

Correct: Pointer to futex dword control value.

Correct: Pointer to futex dword control value.
Returned value:
* eax = futex handle, 0 on error
mxlgv marked this conversation as resolved Outdated
mxlgv commented 2026-01-27 23:12:23 +00:00
Outdated
Review
Copy Link

There is no mistake here. Reverse this change

There is no mistake here. Reverse this change
@@ -5298,7 +5298,7 @@ Parameters:
* eax = 77 - function number
* ebx = 2 - subfunction number
* ecx = futex handle
mxlgv marked this conversation as resolved Outdated
mxlgv commented 2026-01-27 23:11:26 +00:00
Outdated
Review
Copy Link

There is no mistake here. Reverse this change

There is no mistake here. Reverse this change
* edx = pointer to futex control value (dword)
* edx = futex control value (dword)
mxlgv marked this conversation as resolved Outdated
mxlgv commented 2026-01-27 23:11:32 +00:00
Outdated
Review
Copy Link

There is no mistake here. Reverse this change

There is no mistake here. Reverse this change
mxlgv commented 2026-01-28 12:34:43 +00:00
Outdated
Review
Copy Link

Control value. NOT a pointer. Please note:

kolibrios/kernel/trunk/posix/futex.inc Line 117 in 1173ca7b26
lock cmpxchg [ecx], edx

Control value. NOT a pointer. Please note: https://git.kolibrios.org/KolibriOS/kolibrios/src/commit/1173ca7b2669f3ed6f37231ef7512a52029bc126/kernel/trunk/posix/futex.inc#L117
* esi = timeout in hundredths of a second, 0 - wait forever
Returned value:
* eax = 0 - successfull
@@ -5327,7 +5327,7 @@ Remarks:
* Subfunctions 4-7 are reserved and currently return -1.
* Subfunctions 8-9 and 12 are not implemented and return -EBADF (-9).
======================================================================
=========== Function 77, Subfunction 10, Read from file. ============
============ Function 77, Subfunction 10, Read from file. ============
mxlgv marked this conversation as resolved Outdated
mxlgv commented 2026-01-02 20:51:50 +00:00
Outdated
Review
Copy Link

Maybe - instead of ,?

Maybe `-` instead of `,`?
======================================================================
Parameters:
* eax = 77 - function number