KolibriOS/kolibrios
15
24
Fork 61
Code Issues 132 Pull Requests 31 Actions Projects 1 Releases Wiki Activity

libs/kosfuncs: update KOSfuncs.inc constants (fix #323) #374

Merged
Burer merged 3 commits from jaskaran-singh-77/kolibrios:kosfuncs-cleanup into main 2026-04-19 09:44:30 +00:00
Conversation 6 Commits 3 Files Changed 1
+86 -90
jaskaran-singh-77 commented 2026-03-16 16:25:00 +00:00
Contributor
Copy Link
Copy Source

Added missing constants:

  • SSF_SET_CF_ENC (30.4)
    SSF_GET_CF_ENC (30.5)
    SSF_RECT_BG(39.3)
  • SSF_RENAME (70.10)
    SF_FILE_EXT (80 )

Removed obsolete constants:

SF_MIDI (20) and subfunctions

  • SSF_MPU_MIDI_BASE (21.1)
  • SF_PORT_IN_OUT (43)
  • Duplicate aliases for SF_BACKGROUND_GET

Resolves #323

Added missing constants: - SSF_SET_CF_ENC (30.4) SSF_GET_CF_ENC (30.5) SSF_RECT_BG(39.3) - SSF_RENAME (70.10) SF_FILE_EXT (80 ) Removed obsolete constants: SF_MIDI (20) and subfunctions - SSF_MPU_MIDI_BASE (21.1) - SF_PORT_IN_OUT (43) - Duplicate aliases for SF_BACKGROUND_GET Resolves #323
Burer changed title from Fix #323: Update KOSfuncs.inc constants to libs/kosfuncs: update KOSfuncs.inc constants (fix #323) 2026-03-18 18:47:32 +00:00
Burer approved these changes 2026-03-18 18:48:42 +00:00
Dismissed
jaskaran-singh-77 marked the pull request as work in progress 2026-03-20 12:41:13 +00:00
jaskaran-singh-77 marked the pull request as ready for review 2026-03-20 13:38:25 +00:00
Doczom requested changes 2026-03-21 17:49:24 +00:00
Dismissed
programs/KOSfuncs.inc Outdated
@@ -108,11 +106,7 @@ SF_MOUSE_GET=37
SSF_SCROLL_DATA=7
SF_DRAW_LINE=38
SF_BACKGROUND_GET=39
Doczom commented 2026-03-21 17:49:20 +00:00
Owner
Copy Link
Copy Source

there is no constant for the system function 39.3. it must be added.

there is no constant for the system function 39.3. it must be added.
jaskaran-singh-77 commented 2026-03-23 06:51:02 +00:00
Author
Contributor
Copy Link
Copy Source

Done

Done
Burer marked this conversation as resolved
mxlgv requested changes 2026-03-23 14:00:53 +00:00
mxlgv left a comment
Owner
Copy Link
Copy Source

In the task description it was written about redundant comments. I think we need to get rid of all the comments since it's already in the documentation.

In the task description it was written about redundant comments. I think we need to get rid of all the comments since it's already in the documentation.
mxlgv commented 2026-03-23 14:14:16 +00:00
Owner
Copy Link
Copy Source

@jaskaran-singh-77
This does not solve the issue, you ignored some of the points that needed to be done

@jaskaran-singh-77 This does not solve the issue, you ignored some of the points that needed to be done
Burer approved these changes 2026-04-07 15:58:02 +00:00
Doczom approved these changes 2026-04-09 17:47:33 +00:00
Doczom requested review from mxlgv 2026-04-09 17:47:43 +00:00
Doczom requested review from dunkaist 2026-04-16 12:01:20 +00:00
Burer added 3 commits 2026-04-19 09:07:24 +00:00
Fix #323: Add missing and remove obsolete constants da9cb0ae91
Added SSF_RECT_BG constant for function 39.3 54ad729006
Remove redundant comments from KOSfuncs.inc
Build system / Check kernel codestyle (pull_request) Successful in 2m13s
Details
Build system / Build (pull_request) Successful in 11m53s
Details
3754edeed4
Burer force-pushed kosfuncs-cleanup from 495bc156a7 to 3754edeed4 2026-04-19 09:07:24 +00:00 Compare
Burer merged commit e0dc42d79b into main 2026-04-19 09:44:30 +00:00
Burer deleted branch kosfuncs-cleanup 2026-04-19 09:44:32 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Burer
Doczom
mxlgv
dunkaist
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent (Andrew) Burer Doczom (Mikhail Frolov) dunkaist (Ivan B) Egor00f (Егор) hidnplayr IgorA Leency (Kiril Lipatov) mxlgv (Max Logaev) ramenu rgimad sdongles (Serhii Sakhno) Sweetbread (Gleb Zaharov)
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#374
Delete Branch "jaskaran-singh-77/kolibrios:kosfuncs-cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?