KolibriOS/kolibrios
15
25
Fork 61
Code Issues 133 Pull Requests 32 Actions 1 Projects 1 Releases Wiki Activity

[GSoC] Add a program that demonstrates rescaling at resizing #385

Closed
AndreiO wants to merge 4 commits from AndreiO/kolibrios:add-proportional-rectangles-program into main
pull from: AndreiO/kolibrios:add-proportional-rectangles-program
merge into: KolibriOS:main
Conversation 2 Commits 4 Files Changed 1
+101
AndreiO commented 2026-03-22 00:47:23 +00:00
First-time contributor
Copy Link
Copy Source

As requested in https://board.kolibrios.org/viewtopic.php?t=5980

As requested in [https://board.kolibrios.org/viewtopic.php?t=5980](https://board.kolibrios.org/viewtopic.php?t=5980)
AndreiO added 2 commits 2026-03-22 00:47:30 +00:00
Added a program that demonstrates rescaling at resizing ac37e44733
Fixed typo
Build system / Check kernel codestyle (pull_request) Has been cancelled
Details
Build system / Build (pull_request) Has been cancelled
Details
b8702b1a7f
dunkaist requested changes 2026-03-23 19:52:17 +00:00
dunkaist left a comment
Owner
Copy Link
Copy Source

@AndreiO, in general, looks good. Please, fix what I mentioned below

@AndreiO, in general, looks good. Please, fix what I mentioned below
programs/demos/rectangles/rectangles.asm
@@ -0,0 +12,4 @@
dd START
dd I_END
dd MEM_END
dd MEM_END
dunkaist commented 2026-03-23 19:48:53 +00:00
Owner
Copy Link
Copy Source

No stack?

No stack?
AndreiO commented 2026-03-23 22:38:43 +00:00
Author
First-time contributor
Copy Link
Copy Source

I forgot that mcall pushes to the stack. How much space should I reserve?

I forgot that mcall pushes to the stack. How much space should I reserve?
dunkaist commented 2026-03-27 09:04:27 +00:00
Owner
Copy Link
Copy Source

If you don't use any stack at all, it's fine. Just make sure you don't forget to add some when you need to 'call' instead of 'jmp'.

If you don't use any stack at all, it's fine. Just make sure you don't forget to add some when you need to 'call' instead of 'jmp'.
programs/demos/rectangles/rectangles.asm Outdated
@@ -0,0 +52,4 @@
mcall SF_DRAW_RECT
shl ebx, 16
mov bx, [w1]
dunkaist commented 2026-03-23 19:49:19 +00:00
Owner
Copy Link
Copy Source

Please, follow the code style: https://board.kolibrios.org/viewtopic.php?t=1950

Please, follow the code style: https://board.kolibrios.org/viewtopic.php?t=1950
dunkaist marked this conversation as resolved
programs/demos/rectangles/rectangles.asm Outdated
@@ -0,0 +94,4 @@
I_END:
w1: rw 1
dunkaist commented 2026-03-23 19:50:05 +00:00
Owner
Copy Link
Copy Source

No need for a colon here and for other data definitions

No need for a colon here and for other data definitions
dunkaist marked this conversation as resolved
AndreiO added 1 commit 2026-03-23 22:33:16 +00:00
Made the proportional rectangles program use the proper style
Build system / Check kernel codestyle (pull_request) Has been cancelled
Details
Build system / Build (pull_request) Has been cancelled
Details
3a815a110e
AndreiO added 1 commit 2026-03-23 22:34:56 +00:00
Removed colones from data definitions from proportional rectangles program
Build system / Check kernel codestyle (pull_request) Has been cancelled
Details
Build system / Build (pull_request) Has been cancelled
Details
ca9595a9ed
dunkaist commented 2026-03-27 09:06:21 +00:00
Owner
Copy Link
Copy Source

@AndreiO, looks good to me. Your test task is complete now.

@AndreiO, looks good to me. Your test task is complete now.
Burer changed title from Add a program that demonstrates rescaling at resizing to [GSoC] Add a program that demonstrates rescaling at resizing 2026-04-28 06:51:45 +00:00
Burer closed this pull request 2026-06-07 16:38:55 +00:00
Some required checks failed
Build system / Check kernel codestyle (pull_request) Has been cancelled
Required
Details
Build system / Build (pull_request) Has been cancelled
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
dunkaist
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent (Andrew) Burer Doczom (Mikhail Frolov) dunkaist (Ivan B) Egor00f (Егор) hidnplayr IgorA Leency (Kiril Lipatov) mxlgv (Max Logaev) ramenu rgimad sdongles (Serhii Sakhno) Sweetbread (Gleb Zaharov)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#385
Delete Branch "AndreiO/kolibrios:add-proportional-rectangles-program"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?