KolibriOS/kolibrios
16
25
Fork 62
Code Issues 143 Pull Requests 42 Actions Projects 1 Releases Wiki Activity

refactor-kosfuncs #391

Closed
nitinsoni4115 wants to merge 2 commits from nitinsoni4115/kolibrios:refactor-kosfuncs into main
pull from: nitinsoni4115/kolibrios:refactor-kosfuncs
merge into: KolibriOS:main
Conversation 3 Commits 2 Files Changed 1
+119 -192
nitinsoni4115 commented 2026-03-28 17:10:12 +00:00
Contributor
Copy Link
Copy Source

Refactors KOSfuncs.inc (#323):

  • Removed redundant and duplicate comments
  • Cleaned up unnecessary aliases
  • Improved readability and structure

Changes are minimal and safe to avoid breaking compatibility.

Refactors KOSfuncs.inc (#323): - Removed redundant and duplicate comments - Cleaned up unnecessary aliases - Improved readability and structure Changes are minimal and safe to avoid breaking compatibility.
nitinsoni4115 commented 2026-03-28 17:10:25 +00:00
Author
Contributor
Copy Link
Copy Source

Hi! 👋

This PR focuses on cleaning up KOSfuncs.inc by removing redundant comments and unnecessary aliases.

I kept the changes minimal to avoid breaking existing functionality.

Let me know if anything should be adjusted. Thanks!

Hi! 👋 This PR focuses on cleaning up KOSfuncs.inc by removing redundant comments and unnecessary aliases. I kept the changes minimal to avoid breaking existing functionality. Let me know if anything should be adjusted. Thanks!
Burer commented 2026-03-29 09:17:22 +00:00
Owner
Copy Link
Copy Source

How changed files relates to PR topic?
image.png

Also, we already have PR for this issue: #374
If you want to contribue - use that PR as basis, please.

How changed files relates to PR topic? <img width="301" alt="image.png" src="attachments/6e7636a9-bffc-4c19-8867-6e1054c21a73"> Also, we already have PR for this issue: #374 If you want to contribue - use that PR as basis, please.
image.png
16 KiB
nitinsoni4115 added 1 commit 2026-03-29 16:45:30 +00:00
Refactor KOSfuncs.inc: remove redundant comments and clean up formatting
Build system / Check kernel codestyle (pull_request) Has been cancelled
Details
Build system / Build (pull_request) Has been cancelled
Details
f529412c5a 
- Remove inline comments from function/constant definitions
- Add logical whitespace between related function groups
- Clean up deprecated SF_MIDI section
- No functional changes, only documentation cleanup
nitinsoni4115 force-pushed refactor-kosfuncs from 5af1bc63f9 to f529412c5a 2026-03-29 16:45:30 +00:00 Compare
nitinsoni4115 added 1 commit 2026-03-29 16:49:43 +00:00
Merge branch 'main' into refactor-kosfuncs
Build system / Check kernel codestyle (pull_request) Has been cancelled
Details
Build system / Build (pull_request) Has been cancelled
Details
63e3adca5c
nitinsoni4115 commented 2026-03-29 16:50:11 +00:00
Author
Contributor
Copy Link
Copy Source

Hi @Burer! I've cleaned up the PR — removed all unrelated IRC file changes. Now only KOSfuncs.inc is modified. Could you please approve the workflow run? Thank you!

Hi @Burer! I've cleaned up the PR — removed all unrelated IRC file changes. Now only KOSfuncs.inc is modified. Could you please approve the workflow run? Thank you!
nitinsoni4115 closed this pull request 2026-03-29 17:53:41 +00:00
Some checks are pending
1 workflow awaiting approval

The workflow will only run after approval from the repository maintainer.

Build system / Check kernel codestyle (pull_request) Has been cancelled
Details
Build system / Build (pull_request) Has been cancelled
Details
Test PR / Build *
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Category
Applications
Category
Drivers
Category
General
Category
Kernel
Category
Libraries
Eolite
FS
Good First PR
The issue is suitable to beginners
 GSoC
This issue or PR in the Google Source of Code program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Lang/C
Lang/FASM
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Subsystem/API
Subsystem/Audio
infinity service, audio drivers, midi, speacker, audio programs
 Subsystem/Graphics
vesa, vga, framebuffer, cursors, blitter, and video drivers
 Subsystem/IPC and events
pipes, signals, events, shared memory
 Subsystem/Memory
virt and phys memory allocators, malloc and other
 Subsystem/Network
Subsystem/Services(daemon)
userspace and kernel(for example: serial) services
 Subsystem/Taskmanager
process, threads, run apps, scheduler
 Subsystem/VFS
drivers from filesystem, fs api, blkdev, programs that work with the file system
 Subsystem/Window
windows, skins, buttons, mouse and keyboard code for windows (not the base code)
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent (Andrew) bad_Dr3dd0x Burer Doczom (Mikhail Frolov) dunkaist (Ivan B) Egor00f (Егор Ярин) hidnplayr IgorA Leency (Kiril Lipatov) mxlgv (Max Logaev) ramenu rgimad sdongles (Serhii Sakhno) Sweetbread (Gleb Zaharov)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#391
Delete Branch "nitinsoni4115/kolibrios:refactor-kosfuncs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?