KolibriOS/kolibrios
15
24
Fork 61
Code Issues 132 Pull Requests 31 Actions Projects 1 Releases Wiki Activity

Fix #65: Replace WebSVN links with Gitea URLs in asmxygen.py #393

Merged
Burer merged 6 commits from nitinsoni4115/kolibrios:fix-asmxygen-links into main 2026-05-17 14:01:31 +00:00
Conversation 7 Commits 6 Files Changed 1
+4 -3
nitinsoni4115 commented 2026-03-29 17:21:50 +00:00
Contributor
Copy Link
Copy Source

Updates the link_root variable to point to the new Gitea repository
instead of the old WebSVN links:

Also updates the line anchor format to match Gitea's format:

  • Old: #line-{line_number}
  • New: #L{line_number}
Updates the link_root variable to point to the new Gitea repository instead of the old WebSVN links: - Old: http://websvn.kolibrios.org/filedetails.php?repname=Kolibri+OS&path=/kernel/trunk - New: https://git.kolibrios.org/KolibriOS/kolibrios/src/branch/main Also updates the line anchor format to match Gitea's format: - Old: #line-{line_number} - New: #L{line_number}
👍 1
nitinsoni4115 added 1 commit 2026-03-29 17:21:51 +00:00
Fix #65: Replace WebSVN links with Gitea URLs in asmxygen.py
Build system / Check kernel codestyle (pull_request) Has been cancelled
Details
Build system / Build (pull_request) Has been cancelled
Details
e30e8cc124 
Updates the link_root variable to point to the new Gitea repository
instead of the old WebSVN links:
- Old: http://websvn.kolibrios.org/filedetails.php?repname=Kolibri+OS&path=/kernel/trunk
- New: https://git.kolibrios.org/KolibriOS/kolibrios/src/branch/main

Also updates the line anchor format to match Gitea's format:
- Old: #line-{line_number}
- New: #L{line_number}
nitinsoni4115 added 1 commit 2026-03-29 17:22:54 +00:00
Merge branch 'main' into fix-asmxygen-links
Build system / Check kernel codestyle (pull_request) Has been cancelled
Details
Build system / Build (pull_request) Has been cancelled
Details
3b49a3c1da
Burer requested changes 2026-04-06 09:53:41 +00:00
Dismissed
kernel/trunk/asmxygen.py
@@ -401,3 +401,3 @@
contents += (f"@par Source\n" +
f"<a href='{link_root}/{self.file}" +
f"#line-{self.line}'>{self.file}:{self.line}</a>\n")
f"#L{self.line}'>{self.file}:{self.line}</a>\n")
Burer commented 2026-04-06 09:53:10 +00:00
Owner
Copy Link
Copy Source

What is sence of this change?

What is sence of this change?
nitinsoni4115 commented 2026-04-06 11:12:12 +00:00
Author
Contributor
Copy Link
Copy Source

The #line- format was WebSVN-specific. Gitea uses
#L{line} format (same as GitHub/GitLab), so this
change is correct.

The #line- format was WebSVN-specific. Gitea uses #L{line} format (same as GitHub/GitLab), so this change is correct.
nitinsoni4115 marked this conversation as resolved
kernel/trunk/asmxygen.py Outdated
@@ -1040,3 +1040,2 @@
if __name__ == "__main__":
link_root = "http://websvn.kolibrios.org/filedetails.php"
link_root += "?repname=Kolibri+OS&path=/kernel/trunk"
link_root = "https://git.kolibrios.org/KolibriOS/kolibrios/src/branch/main"
Burer commented 2026-04-06 09:53:38 +00:00
Owner
Copy Link
Copy Source

You changed link to /kernel/trunk folder with link to repo root?
Is that correct?

You changed link to /kernel/trunk folder with link to repo root? Is that correct?
nitinsoni4115 commented 2026-04-06 11:12:26 +00:00
Author
Contributor
Copy Link
Copy Source

You are right! The link_root was missing /kernel/trunk.
Fixed in the latest commit 28e57ceff.
Correct URL now generates:
https://git.kolibrios.org/KolibriOS/kolibrios/src/branch/main/kernel/trunk/{file}#L{line}

You are right! The link_root was missing /kernel/trunk. Fixed in the latest commit 28e57ceff. Correct URL now generates: https://git.kolibrios.org/KolibriOS/kolibrios/src/branch/main/kernel/trunk/{file}#L{line}
nitinsoni4115 marked this conversation as resolved
nitinsoni4115 added 1 commit 2026-04-06 11:11:07 +00:00
Fix link_root: add /kernel/trunk to Gitea URL
Build system / Check kernel codestyle (pull_request) Has been cancelled
Details
Build system / Build (pull_request) Has been cancelled
Details
345974c742
nitinsoni4115 added 1 commit 2026-04-06 11:12:53 +00:00
Merge branch 'main' into fix-asmxygen-links
Build system / Check kernel codestyle (pull_request) Has been cancelled
Details
Build system / Build (pull_request) Has been cancelled
Details
84194a890e
ace-dent commented 2026-04-08 11:55:20 +00:00
Member
Copy Link
Copy Source

Thanks for attending to this. 🙏

Thanks for attending to this. 🙏
nitinsoni4115 commented 2026-04-09 13:23:10 +00:00
Author
Contributor
Copy Link
Copy Source

Hi @Burer! Both changes are now correct:

  1. #L{line} format - correct for Gitea (same as GitHub/GitLab)
  2. link_root fixed in commit 345974c74 - /kernel/trunk added

Please review

Hi @Burer! Both changes are now correct: 1. #L{line} format - correct for Gitea (same as GitHub/GitLab) 2. link_root fixed in commit 345974c74 - /kernel/trunk added Please review
ace-dent commented 2026-04-09 13:26:09 +00:00
Member
Copy Link
Copy Source

@nitinsoni4115 - please carefully check all my comments on #65. When you are happy everything is correct, I can also review 🙏

@nitinsoni4115 - please carefully check all my comments on #65. When you are happy everything is correct, I can also review 🙏
ace-dent requested review from ace-dent 2026-04-09 13:26:33 +00:00
nitinsoni4115 added 1 commit 2026-04-10 16:06:51 +00:00
Fix #65: Update all link_root URLs and add VCS comment
Build system / Check kernel codestyle (pull_request) Successful in 29s
Details
Build system / Build (pull_request) Successful in 30m4s
Details
8290d2b6e5
nitinsoni4115 added 1 commit 2026-04-10 16:08:52 +00:00
Merge branch 'main' into fix-asmxygen-links
Build system / Check kernel codestyle (pull_request) Successful in 45s
Details
Build system / Build (pull_request) Successful in 35m5s
Details
f4401d8ba4
nitinsoni4115 commented 2026-04-10 16:09:25 +00:00
Author
Contributor
Copy Link
Copy Source

Hi @ace-dent! I've reviewed all comments on issue #65
and made the following updates in the latest commit:

  • link_root updated to correct Gitea URL with /kernel/trunk
  • #L{line} anchor format used (Gitea standard)
  • Added VCS dependency comment explaining the URL
    depends on hosting platform

Everything looks correct now. Please review when ready!

Hi @ace-dent! I've reviewed all comments on issue #65 and made the following updates in the latest commit: - link_root updated to correct Gitea URL with /kernel/trunk - #L{line} anchor format used (Gitea standard) - Added VCS dependency comment explaining the URL depends on hosting platform Everything looks correct now. Please review when ready!
dunkaist approved these changes 2026-05-16 19:36:16 +00:00
Burer approved these changes 2026-05-17 14:00:55 +00:00
Burer merged commit 9b9f10b231 into main 2026-05-17 14:01:31 +00:00
Burer deleted branch fix-asmxygen-links 2026-05-17 14:01:31 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
ace-dent
dunkaist
Burer
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent (Andrew) Burer Doczom (Mikhail Frolov) dunkaist (Ivan B) Egor00f (Егор) hidnplayr IgorA Leency (Kiril Lipatov) mxlgv (Max Logaev) ramenu rgimad sdongles (Serhii Sakhno) Sweetbread (Gleb Zaharov)
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#393
Delete Branch "nitinsoni4115/kolibrios:fix-asmxygen-links"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?