KolibriOS/kolibrios
15
24
Fork 61
Code Issues 132 Pull Requests 31 Actions Projects 1 Releases Wiki Activity

games/invaders: review graphical assets in code (fix #236) #394

Merged
Burer merged 4 commits from nitinsoni4115/kolibrios:fix-invaders-bullet-asset into main 2026-05-16 08:37:38 +00:00
Conversation 2 Commits 4 Files Changed 1
+9 -13
nitinsoni4115 commented 2026-03-29 17:27:23 +00:00
Contributor
Copy Link
Copy Source
  • Remove the unused gif_bullet2 file definition
  • Remove the unused gif_bullet2 decodeimg call
  • Remove the unused img_bullet2 memory allocation
  • Fix gif_menu4.size to use gif_menu4
  • Comment out the unused img_alienpiece allocation
  • Preserve img_bullet from bullet2.gif for bullet rendering
- Remove the unused `gif_bullet2` file definition - Remove the unused `gif_bullet2` `decodeimg` call - Remove the unused `img_bullet2` memory allocation - Fix `gif_menu4.size` to use `gif_menu4` - Comment out the unused `img_alienpiece` allocation - Preserve `img_bullet` from `bullet2.gif` for bullet rendering
nitinsoni4115 added 1 commit 2026-03-29 17:27:23 +00:00
Fix #236: Remove unused bullet asset from invaders game
Build system / Check kernel codestyle (pull_request) Has been cancelled
Details
Build system / Build (pull_request) Has been cancelled
Details
ad68015044 
Issue: Both gif_bullet and gif_bullet2 referenced the same file (bullet2.gif),
and img_bullet2 was never actually used in the game logic, leading to:
- Redundant asset decoding on startup
- Wasted memory allocation (BULLET_X*BULLET_Y*3+8 bytes)
- Unused bullet.gif file in the repository

Solution: Remove the unused img_bullet2 variable and all related code:
- Remove gif_bullet2 file definition
- Remove gif_bullet2 decodeimg call
- Remove img_bullet2 memory allocation

The game continues to use img_bullet (from bullet2.gif) for all bullet rendering.
nitinsoni4115 added 1 commit 2026-03-29 17:27:32 +00:00
Merge branch 'main' into fix-invaders-bullet-asset
Build system / Check kernel codestyle (pull_request) Has been cancelled
Details
Build system / Build (pull_request) Has been cancelled
Details
b998b3fb89
nitinsoni4115 added 1 commit 2026-04-25 14:38:53 +00:00
Merge branch 'main' into fix-invaders-bullet-asset
Build system / Check kernel codestyle (pull_request) Successful in 24s
Details
Build system / Build (pull_request) Successful in 13m28s
Details
18149971cc
Burer added 1 commit 2026-04-26 05:23:03 +00:00
games/invaders: review graphics assets in code
Build system / Check kernel codestyle (pull_request) Successful in 50s
Details
Build system / Build (pull_request) Successful in 10m7s
Details
ec92b1a5d7
Burer changed title from Fix #236: Remove unused bullet asset from invaders game to games/invaders: review graphical assets in code (fix #236) 2026-04-26 05:25:08 +00:00
Burer approved these changes 2026-04-26 05:46:12 +00:00
hidnplayr commented 2026-05-10 20:35:25 +00:00
Member
Copy Link
Copy Source

Just for reference, this bullet was originally intended to be shot from the enemy to the player, but the associated game logic was never implemented

Just for reference, this bullet was originally intended to be shot from the enemy to the player, but the associated game logic was never implemented
👍 1
Burer merged commit fac0425ac0 into main 2026-05-16 08:37:38 +00:00
Burer deleted branch fix-invaders-bullet-asset 2026-05-16 08:37:39 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Burer
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent (Andrew) Burer Doczom (Mikhail Frolov) dunkaist (Ivan B) Egor00f (Егор) hidnplayr IgorA Leency (Kiril Lipatov) mxlgv (Max Logaev) ramenu rgimad sdongles (Serhii Sakhno) Sweetbread (Gleb Zaharov)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#394
Delete Branch "nitinsoni4115/kolibrios:fix-invaders-bullet-asset"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?