KolibriOS/kolibrios
15
24
Fork 59
Code Issues 125 Pull Requests 27 Actions Projects 1 Releases Wiki Activity

programs/system: Post-SVN tidy (part 3) #413

Merged
Burer merged 14 commits from ace-dent/kolibrios-gitea:PR-TidySVN-system-3 into main 2026-04-10 16:30:26 +00:00
Conversation 5 Commits 14 Files Changed 68
+5543 -5485
ace-dent commented 2026-04-09 19:32:42 +00:00
Member
Copy Link
Copy Source
  • Move source code from trunk into root directory for each program.
  • Update build files and ASM include paths. Add SPDX license header where appropriate.
  • Note: Line endings standardised from CRLF > LF, so best to view diffs with whitespace changes hidden.

(Work towards #75, point 3)

- Move source code from `trunk` into root directory for each program. - Update build files and ASM include paths. Add SPDX license header where appropriate. - Note: Line endings standardised from `CRLF` > `LF`, so best to view diffs with whitespace changes hidden. (Work towards #75, point 3)
ace-dent added the
Kind
Build
Category/Applications
Priority
Low
 labels 2026-04-09 19:32:42 +00:00
ace-dent added 12 commits 2026-04-09 19:32:43 +00:00
system/eskin: Post-SVN clean up d9a6bd3274 
- Move source code from `trunk` into program root directory.
- Update build files.
system/eskin: Post-SVN clean up 084a169748 
- Update ASM include paths.
system/end: Post-SVN clean up 6c05fda970 
- Move source code from `trunk` into program root directory.
- Update build files and ASM include paths.
system/run: Post-SVN clean up 620c1d5337 
- Move source code from `trunk` into program root directory.
- Update build files and ASM include paths.
system/setup: Post-SVN clean up 3d3e458e97 
- Move source code from `trunk` into program root directory.
- Update build files and ASM include paths.
system/skincfg: Post-SVN clean up a70a4145c1 
- Move source code from `trunk` into program root directory.
- Update build files and ASM include paths.
system/skincfg: Post-SVN clean up a4e74108cd 
- Fix ASM include paths; code reused in more places.
- Note: Line endings standardised from `CRLF` > `LF`, so best to view diffs with whitespace changes hidden.
system/run: Post-SVN clean up f921e6dac6 
- Fix ASM include paths.
system/board: Post-SVN clean up acf3672c00 
- Fix ASM include paths.
- Note: Line endings standardised from `CRLF` > `LF`, so best to view diffs with whitespace changes hidden.
system/taskbar: Post-SVN clean up fa5f4dfab4 
- Move source code from `trunk` into program root directory.
- Update build files and ASM include paths.
system/zkey: Post-SVN clean up c083a3d6e3 
- Move source code from `trunk` into program root directory.
- Update build files and ASM include paths.
programs/system: Post-SVN tidy
Build system / Check kernel codestyle (pull_request) Successful in 39s
Details
Build system / Build (pull_request) Failing after 55s
Details
513d945d20 
- Tidy `build_all.bat` build file; comment out absent programs.
ace-dent commented 2026-04-09 19:37:06 +00:00
Author
Member
Copy Link
Copy Source

This PR is split (/cherry picked) from the monolithic PR #246 - for easier merging! 🤞
This is part 3... the final set for system 🎉

Updates these programs (for testing):

  • system/board
  • system/end
  • system/eskin
  • system/run
  • system/setup
  • system/skincfg
  • system/taskbar
  • system/zkey
This PR is split (/cherry picked) from the monolithic PR #246 - for easier merging! 🤞 This is part 3... the final set for `system` 🎉 Updates these programs (for testing): - `system/board` - `system/end` - `system/eskin` - `system/run` - `system/setup` - `system/skincfg` - `system/taskbar` - `system/zkey`
ace-dent added 1 commit 2026-04-09 19:47:39 +00:00
system/taskbar: Post-SVN clean up
Build system / Check kernel codestyle (pull_request) Successful in 23s
Details
Build system / Build (pull_request) Successful in 11m6s
Details
06a4944fa2 
- Fix file path for KEYMAP.
ace-dent requested review from Burer 2026-04-09 19:53:34 +00:00
ace-dent requested review from Doczom 2026-04-09 19:53:35 +00:00
ace-dent requested review from dunkaist 2026-04-09 19:53:36 +00:00
ace-dent requested review from Sweetbread 2026-04-09 19:53:37 +00:00
ace-dent added the
PR
Review required
 label 2026-04-09 19:53:48 +00:00
dunkaist approved these changes 2026-04-09 21:41:39 +00:00
Doczom approved these changes 2026-04-10 06:47:38 +00:00
Burer commented 2026-04-10 07:24:12 +00:00
Owner
Copy Link
Copy Source

Minor note

build_all.bat line 137 changes system\PANEL\trunk\@TASKBAR.ASM to system\PANEL\@TASKBAR.ASM, but the directory PANEL doesn't exist - it's taskbar (I suppose?).
The correct path should be system\taskbar\TASKBAR.ASM.
This is a pre-existing issue (not introduced by this PR), and data/Tupfile.lua has the correct path, so Tup builds are unaffected, but still would be nice to fix.

**Minor note** `build_all.bat` line 137 changes `system\PANEL\trunk\@TASKBAR.ASM` to `system\PANEL\@TASKBAR.ASM`, but the directory `PANEL` doesn't exist - it's `taskbar` (I suppose?). The correct path should be `system\taskbar\TASKBAR.ASM`. This is a pre-existing issue (not introduced by this PR), and `data/Tupfile.lua` has the correct path, so Tup builds are unaffected, but still would be nice to fix.
ace-dent added 1 commit 2026-04-10 09:57:39 +00:00
programs/system: Post-SVN tidy
Build system / Check kernel codestyle (pull_request) Successful in 30s
Details
Build system / Build (pull_request) Successful in 10m40s
Details
26651747a5 
- Fix `build_all.bat` path for `taskbar`.
ace-dent commented 2026-04-10 09:59:41 +00:00
Author
Member
Copy Link
Copy Source

Thanks @Burer - nice catch!
I've added the fix... but ignored the other possible fixes, (e.g. for @SS, etc.)... as these would be untested guess work(!)...
I think it needs to be a dedicated PR if we decide to restore the Windows build system...

Thanks @Burer - nice catch! I've added the fix... but ignored the other possible fixes, (e.g. for `@SS`, etc.)... as these would be untested guess work(!)... I think it needs to be a dedicated PR if we decide to restore the Windows build system...
Burer merged commit 7bcb400040 into main 2026-04-10 16:30:26 +00:00
Burer deleted branch PR-TidySVN-system-3 2026-04-10 16:30:27 +00:00
ace-dent removed the
PR
Review required
 label 2026-04-10 17:05:10 +00:00
ace-dent removed review request for Sweetbread 2026-04-10 17:05:18 +00:00
ace-dent removed review request for Burer 2026-04-10 17:05:35 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
dunkaist
Doczom
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label Category/Applications
Kind
Build
Priority
Low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent (Andrew) Burer Doczom (Mikhail Frolov) dunkaist (Ivan B) hidnplayr IgorA Leency (Kiril Lipatov) mxlgv (Max Logaev) ramenu rgimad sdongles (Serhii Sakhno) Sweetbread (Gleb Zaharov)
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#413
Delete Branch "ace-dent/kolibrios-gitea:PR-TidySVN-system-3"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?