KolibriOS/kolibrios
15
24
Fork 61
Code Issues 128 Pull Requests 31 Actions Projects 1 Releases Wiki Activity

libraries/box_lib: Post-SVN tidy #433

Merged
Burer merged 3 commits from ace-dent/kolibrios-gitea:PR-TidySVN-develop-5 into main 2026-04-23 11:50:22 +00:00
Conversation 9 Commits 3 Files Changed 106
+19579 -18766
ace-dent commented 2026-04-21 00:20:52 +00:00
Member
Copy Link
Copy Source
  • Move source code from trunk into root directory.
  • Update build files and ASM include paths. Add SPDX license header where appropriate.
  • Note: Line endings standardised from CRLF > LF, so best to view diffs with whitespace changes hidden.

(Work towards #75, point 3)

- Move source code from `trunk` into root directory. - Update build files and ASM include paths. Add SPDX license header where appropriate. - Note: Line endings standardised from `CRLF` > `LF`, so best to view diffs with whitespace changes hidden. (Work towards [#75](https://git.kolibrios.org/KolibriOS/kolibrios/issues/75), point 3)
ace-dent added the
Kind
Build
Category/Libraries
Priority
Low
 labels 2026-04-21 00:20:52 +00:00
ace-dent commented 2026-04-21 00:26:00 +00:00
Author
Member
Copy Link
Copy Source

This PR is split (/cherry picked) from the monolithic PR #251 - for easier merging! 🤞
This part is just focused on the box_lib library, as it affects many files.

Beyond the main library files, other dependent programs were updated:

  • contrib/C_Layer/ASM/loadboxlib.asm
  • programs/develop/h2d2b/h2d2b.asm
  • programs/develop/heed/heed.asm
  • programs/develop/info3ds/info3ds.asm and info3ds_u.asm
  • programs/develop/kol_f_edit/kol_f_edit.asm and templates box_l.ced and buf2d.ced
  • programs/develop/libraries/crypt_des/example/crypt_files.asm
  • programs/develop/libraries/exif/examples/viev_exif.asm
  • programs/develop/libraries/fontslib/trunk/font_ex.asm
  • programs/develop/libraries/http/examples/deflate.asm and get.asm
  • programs/develop/libraries/nnp/examples/nnp_points.asm
  • programs/develop/str_double/str_double.asm
  • programs/fs/opendial/opendial.asm
  • programs/fs/unz/unz.asm
  • programs/games/nu_pogodi/nu_pogod.asm
  • programs/games/snake/snake.asm
  • programs/media/log_el/log_el.asm
  • programs/media/scrshoot/scrshoot.asm
  • programs/media/zsea/zSea.asm
  • programs/network/downloader/downloader.asm
  • programs/network/ftpc/gui.inc
  • programs/network/ircc/ircc.asm
  • programs/network/netstat/netstat.asm
  • programs/network/tftpc/tftpc.asm
  • programs/network/vncc/vncc.asm
  • programs/other/calcplus/calcplus.asm
  • programs/other/cnc_control/cnc_control.asm
  • programs/other/cnc_editor/cnc_editor.asm
  • programs/other/ha/HACONFIG.ASM
  • programs/other/kpack/trunk/kpack.asm
  • programs/other/outdated/dictionary/dictionary.ASM
  • programs/other/planet_v/planet_v.asm
  • programs/other/rtfread/rtfread.asm
  • programs/other/t_edit/t_edit.asm
  • programs/other/t_edit_synt/te_syntax.asm
  • programs/system/MyKey/MyKey.asm
  • programs/system/RunOD/RunOD.asm
  • programs/system/colrdial/color_dialog.asm
  • programs/system/cpu/cpu.asm
  • programs/system/format/format.asm
  • programs/system/hdd_info/hdd_info.asm
  • programs/system/icon_new/icon.asm
  • programs/system/keybi/keybi.asm
  • programs/system/open/open.asm
  • programs/system/rdsave/rdsave.asm
  • programs/system/run/run.asm
  • programs/system/terminal/terminal.asm
  • programs/testing/fspeed/fspeed.asm
  • programs/testing/mgb/mgb.asm
This PR is split (/cherry picked) from the monolithic PR #251 - for easier merging! 🤞 This part is just focused on the `box_lib` library, as it affects **many** files. Beyond the main library files, other dependent programs were updated: - `contrib/C_Layer/ASM/loadboxlib.asm` - `programs/develop/h2d2b/h2d2b.asm` - `programs/develop/heed/heed.asm` - `programs/develop/info3ds/info3ds.asm` and `info3ds_u.asm` - `programs/develop/kol_f_edit/kol_f_edit.asm` and templates `box_l.ced` and `buf2d.ced` - `programs/develop/libraries/crypt_des/example/crypt_files.asm` - `programs/develop/libraries/exif/examples/viev_exif.asm` - `programs/develop/libraries/fontslib/trunk/font_ex.asm` - `programs/develop/libraries/http/examples/deflate.asm` and `get.asm` - `programs/develop/libraries/nnp/examples/nnp_points.asm` - `programs/develop/str_double/str_double.asm` - `programs/fs/opendial/opendial.asm` - `programs/fs/unz/unz.asm` - `programs/games/nu_pogodi/nu_pogod.asm` - `programs/games/snake/snake.asm` - `programs/media/log_el/log_el.asm` - `programs/media/scrshoot/scrshoot.asm` - `programs/media/zsea/zSea.asm` - `programs/network/downloader/downloader.asm` - `programs/network/ftpc/gui.inc` - `programs/network/ircc/ircc.asm` - `programs/network/netstat/netstat.asm` - `programs/network/tftpc/tftpc.asm` - `programs/network/vncc/vncc.asm` - `programs/other/calcplus/calcplus.asm` - `programs/other/cnc_control/cnc_control.asm` - `programs/other/cnc_editor/cnc_editor.asm` - `programs/other/ha/HACONFIG.ASM` - `programs/other/kpack/trunk/kpack.asm` - `programs/other/outdated/dictionary/dictionary.ASM` - `programs/other/planet_v/planet_v.asm` - `programs/other/rtfread/rtfread.asm` - `programs/other/t_edit/t_edit.asm` - `programs/other/t_edit_synt/te_syntax.asm` - `programs/system/MyKey/MyKey.asm` - `programs/system/RunOD/RunOD.asm` - `programs/system/colrdial/color_dialog.asm` - `programs/system/cpu/cpu.asm` - `programs/system/format/format.asm` - `programs/system/hdd_info/hdd_info.asm` - `programs/system/icon_new/icon.asm` - `programs/system/keybi/keybi.asm` - `programs/system/open/open.asm` - `programs/system/rdsave/rdsave.asm` - `programs/system/run/run.asm` - `programs/system/terminal/terminal.asm` - `programs/testing/fspeed/fspeed.asm` - `programs/testing/mgb/mgb.asm`
ace-dent commented 2026-04-21 00:26:08 +00:00
Author
Member
Copy Link
Copy Source

@Burer - Fixed the 2 binary files that referenced box_lib/trunk:

  • programs/develop/kol_f_edit/box_l.ced
  • programs/develop/kol_f_edit/buf2d.ced
@Burer - Fixed the 2 binary files that referenced `box_lib/trunk`: - [x] `programs/develop/kol_f_edit/box_l.ced` - [x] `programs/develop/kol_f_edit/buf2d.ced`
ace-dent force-pushed PR-TidySVN-develop-5 from 6789783cd0 to 92ac16f979 2026-04-21 00:31:54 +00:00 Compare
ace-dent force-pushed PR-TidySVN-develop-5 from 92ac16f979 to fbd8e5787b 2026-04-21 00:37:36 +00:00 Compare
ace-dent force-pushed PR-TidySVN-develop-5 from fbd8e5787b to a9e02c2972 2026-04-21 00:46:43 +00:00 Compare
Burer commented 2026-04-21 10:23:18 +00:00
Owner
Copy Link
Copy Source

Would appreciate some insight into the nature of those files before editing; they contain many NULL bytes, etc.! 🧐

These .ced files are kol_f_edit project templates stored in a custom binary format, so they are not plain text and lots of NULL bytes are normal.

The safest way to edit them is with kol_f_edit itself, since it reads and writes this format correctly.

I can try doing it, and uploading updated files to this PR, if you need some help with this.

> Would appreciate some insight into the nature of those files before editing; they contain many NULL bytes, etc.! 🧐 These `.ced` files are `kol_f_edit` project templates stored in a custom binary format, so they are not plain text and lots of `NULL` bytes are normal. The safest way to edit them is with `kol_f_edit` itself, since it reads and writes this format correctly. I can try doing it, and uploading updated files to this PR, if you need some help with this.
👍 1
ace-dent requested review from Burer 2026-04-21 11:25:50 +00:00
ace-dent requested review from Doczom 2026-04-21 11:25:51 +00:00
ace-dent requested review from dunkaist 2026-04-21 11:25:53 +00:00
ace-dent requested review from Sweetbread 2026-04-21 11:25:54 +00:00
ace-dent added the
PR
Review required
 label 2026-04-21 11:26:51 +00:00
ace-dent commented 2026-04-21 12:37:46 +00:00
Author
Member
Copy Link
Copy Source

@Burer - thanks for the fix. Committed.

@Burer - thanks for the [fix](https://discord.com/channels/631286773720416295/844285887218450482/1496123819360784424). Committed.
Burer approved these changes 2026-04-21 15:27:19 +00:00
ace-dent added 2 commits 2026-04-22 07:14:02 +00:00
develop/libraries/box_lib: Post-SVN tidy 687e2d2d0a 
- Move source code from `trunk` into root directory.
- Update build files and ASM include paths. This touches *many* files.
- Note: Line endings standardised from `CRLF` > `LF`, so best to view diffs with whitespace changes hidden.
develop/libraries/box_lib: Post-SVN tidy
Build system / Check kernel codestyle (pull_request) Successful in 1m18s
Details
Build system / Build (pull_request) Successful in 11m5s
Details
4e7f1eb5f7 
- Fix paths in binary template files for `kol_f_edit`. Thanks to @Burer 🙏.
ace-dent force-pushed PR-TidySVN-develop-5 from 10e0de205d to 4e7f1eb5f7 2026-04-22 07:14:02 +00:00 Compare
dunkaist approved these changes 2026-04-22 16:25:58 +00:00
Doczom requested changes 2026-04-23 02:26:01 +00:00
Dismissed
Doczom left a comment
Owner
Copy Link
Copy Source

file not found src="../../../../../../other/t_edit/t_edit.png" in programs/develop/libraries/box_lib/doc/t_edit/t_edit.htm

file not found src="../../../../../../other/t_edit/t_edit.png" in programs/develop/libraries/box_lib/doc/t_edit/t_edit.htm
👀 1
ace-dent added 1 commit 2026-04-23 09:55:38 +00:00
develop/libraries/box_lib: Post-SVN tidy
Build system / Check kernel codestyle (pull_request) Successful in 2m47s
Details
Build system / Build (pull_request) Successful in 12m42s
Details
76cfde3cd7 
- Check and fix paths in HTML documentation. Thanks @Doczom.
ace-dent commented 2026-04-23 09:57:52 +00:00
Author
Member
Copy Link
Copy Source

Thanks @Doczom - another great find!
I checked again all HTML docs and corrected the path. However, I think the longer term fix is to address the surprising dependency; this is noted in #261 .

Thanks @Doczom - another great find! I checked again all HTML docs and corrected the path. However, I think the longer term _fix_ is to address the surprising dependency; this is noted in #261 .
ace-dent requested review from Doczom 2026-04-23 10:03:27 +00:00
Doczom approved these changes 2026-04-23 11:45:39 +00:00
Burer merged commit 2cda4a9682 into main 2026-04-23 11:50:22 +00:00
Burer deleted branch PR-TidySVN-develop-5 2026-04-23 11:50:24 +00:00
ace-dent removed review request for Sweetbread 2026-04-23 12:06:09 +00:00
ace-dent removed the
PR
Review required
 label 2026-04-23 12:06:56 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Burer
dunkaist
Doczom
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label Category/Libraries
Kind
Build
Priority
Low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent (Andrew) Burer Doczom (Mikhail Frolov) dunkaist (Ivan B) Egor00f (Егор) hidnplayr IgorA Leency (Kiril Lipatov) mxlgv (Max Logaev) ramenu rgimad sdongles (Serhii Sakhno) Sweetbread (Gleb Zaharov)
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#433
Delete Branch "ace-dent/kolibrios-gitea:PR-TidySVN-develop-5"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?