KolibriOS/kolibrios
15
24
Fork 61
Code Issues 126 Pull Requests 38 Actions Projects 1 Releases Wiki Activity

WIP: Kernel UI: add maximize button support for skinned windows (bounty #283) #437

Draft
dMartian wants to merge 1 commits from dMartian/kolibrios:add-skinned-window-maximize into main
pull from: dMartian/kolibrios:add-skinned-window-maximize
merge into: KolibriOS:main
Conversation 2 Commits 1 Files Changed 45
+290 -63
dMartian commented 2026-05-02 01:49:10 +00:00
First-time contributor
Copy Link
Copy Source

Adds maximize/restore titlebar button support for skinned windows.

  • Adds skin button type 3 for maximize
  • Registers maximize as system button ID 0xFFFE
  • Routes the button to the existing window maximize/restore handler
  • Derives a maximize button for legacy skins from close/minimize geometry
  • Draws a generic maximize/restore glyph for skinned windows
  • Updates skin macros so new skins can declare maximize = [...]
  • Fixes kernel Makefile recipe indentation and default language for make kernel

Checks:

  • git diff --check
  • make -n kernel
Adds maximize/restore titlebar button support for skinned windows. - Adds skin button type 3 for maximize - Registers maximize as system button ID 0xFFFE - Routes the button to the existing window maximize/restore handler - Derives a maximize button for legacy skins from close/minimize geometry - Draws a generic maximize/restore glyph for skinned windows - Updates skin macros so new skins can declare maximize = [...] - Fixes kernel Makefile recipe indentation and default language for make kernel Checks: - git diff --check - make -n kernel
dMartian added 1 commit 2026-05-02 01:49:11 +00:00
Add skinned window maximize button support
Build system / Check kernel codestyle (pull_request) Successful in 28s
Details
Build system / Build (pull_request) Successful in 9m34s
Details
c9b666b292
Burer changed title from WIP: Kernel UI: add maximize button support for skinned windows to WIP: Kernel UI: add maximize button support for skinned windows (bounty #283) 2026-05-02 13:44:10 +00:00
Burer commented 2026-05-08 16:28:58 +00:00
Owner
Copy Link
Copy Source

Hi!

I tested yout PR. Basic functionality looks okay, but visuals definitely have problems.

  1. This new button should look just like other two buttons, without breaking the general style.
  2. Also, it should be positioned between other two buttons not at the left.
  3. Your friend mentioned that with your patch applied, none of the games launched. Did you tested this?

I understand that these changes will require editing all skins, but I am ready to help you with graphics if you explain what format is needed, and we can start with just default skin.

image.png
Hi! I tested yout PR. Basic functionality looks okay, but visuals definitely have problems. 1. This new button should look just like other two buttons, without breaking the general style. 2. Also, it should be positioned between other two buttons not at the left. 3. Your friend mentioned that with your patch applied, none of the games launched. Did you tested this? I understand that these changes will require editing all skins, but I am ready to help you with graphics if you explain what format is needed, and we can start with just default skin. <img width="337" alt="image.png" src="attachments/f494cad7-4ab2-4e65-874b-308a184519e7">
image.png
4.2 KiB
hidnplayr commented 2026-05-28 17:59:10 +00:00
Member
Copy Link
Copy Source

May I suggest to add backwards compatibility; to have skins with or without maximize button.
It should not be so hard to do, and will ease the transition.

May I suggest to add backwards compatibility; to have skins with or without maximize button. It should not be so hard to do, and will ease the transition.
Some checks are pending
Build system / Check kernel codestyle (pull_request) Successful in 28s
Details
Build system / Build (pull_request) Successful in 9m34s
Details
This pull request is marked as a work in progress.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u http://git.kolibrios.org/dMartian/kolibrios add-skinned-window-maximize:dMartian-add-skinned-window-maximize
git checkout dMartian-add-skinned-window-maximize
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent (Andrew) Burer Doczom (Mikhail Frolov) dunkaist (Ivan B) hidnplayr IgorA Leency (Kiril Lipatov) mxlgv (Max Logaev) ramenu rgimad sdongles (Serhii Sakhno) Sweetbread (Gleb Zaharov)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#437
Delete Branch "dMartian/kolibrios:add-skinned-window-maximize"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?