KolibriOS/kolibrios
15
24
Fork 61
Code Issues 132 Pull Requests 34 Actions Projects 1 Releases Wiki Activity

RTL8169: enable gigabit and restart auto-negotiation on init #440

Merged
hidnplayr merged 2 commits from hidnplayr/kolibrios:main into main 2026-05-15 17:03:18 +00:00
Conversation 4 Commits 2 Files Changed 1
+13 -6
hidnplayr commented 2026-05-15 15:19:54 +00:00
Member
Copy Link
Copy Source

Fix bug in enabling gigabit and restart auto-negotiation setup for most RTL8169/RTL8168/RTL8111

Fix bug in enabling gigabit and restart auto-negotiation setup for most RTL8169/RTL8168/RTL8111
hidnplayr added 1 commit 2026-05-15 15:19:55 +00:00
RTL8169: enable gigabit and restart auto-negotiation on init
Build system / Check kernel codestyle (pull_request) Successful in 1m31s
Details
Build system / Build (pull_request) Successful in 10m53s
Details
1880a0063b
hidnplayr commented 2026-05-15 15:29:12 +00:00
Author
Member
Copy Link
Copy Source

Verified to be working on:

  • RTL8111B
  • RTL8169SC
  • RTL8168EVL
Verified to be working on: - RTL8111B - RTL8169SC - RTL8168EVL
dunkaist reviewed 2026-05-15 16:27:07 +00:00
drivers/ethernet/RTL8169.asm Outdated
@@ -585,3 +585,2 @@
DEBUGF 2, "Detected chip: %s\n", ecx
cmp dword[esi], 0
jne @f
; cmp dword[esi], 0
dunkaist commented 2026-05-15 16:27:07 +00:00
Owner
Copy Link
Copy Source

If you may need this for a quick debug later, ok. If you just commented out and forgot, please, remove.

If you may need this for a quick debug later, ok. If you just commented out and forgot, please, remove.
hidnplayr marked this conversation as resolved
dunkaist requested review from Burer 2026-05-15 16:27:37 +00:00
hidnplayr added 1 commit 2026-05-15 17:00:42 +00:00
TxConfig should always be printed when DEBUG_LEVEL is 1 (remove dead code)
Build system / Check kernel codestyle (pull_request) Successful in 34s
Details
Build system / Build (pull_request) Successful in 9m43s
Details
dc9eb25380
hidnplayr merged commit 8235572f7b into main 2026-05-15 17:03:18 +00:00
hidnplayr commented 2026-05-15 17:21:03 +00:00
Author
Member
Copy Link
Copy Source

@Burer: Sorry, I pushed a button too early

@Burer: Sorry, I pushed a button too early
hidnplayr commented 2026-05-16 09:56:14 +00:00
Author
Member
Copy Link
Copy Source

Also tested just now on an RTL8101E (It's like an RTL8169 but without gigabit), it still works fine

Also tested just now on an RTL8101E (It's like an RTL8169 but without gigabit), it still works fine
Sign in to join this conversation.
Reviewers
No Reviewers
dunkaist
Burer
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent (Andrew) Burer Doczom (Mikhail Frolov) dunkaist (Ivan B) Egor00f (Егор) hidnplayr IgorA Leency (Kiril Lipatov) mxlgv (Max Logaev) ramenu rgimad sdongles (Serhii Sakhno) Sweetbread (Gleb Zaharov)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#440
Delete Branch "hidnplayr/kolibrios:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?