data/menu: fix welcome.htm path + localize welcome.htm to all system languages #466

Merged
Burer merged 8 commits from menu-fix-welcome-path into main 2026-06-07 16:11:27 +00:00
Owner
  • "Welcome" menu item now uses absolute path /sys/welcome.htm (relative path failed to open when other tab was already open).
    image.png
  • Add full RU and ES translations of welcome.htm, keeping the original tone, plus per-language build rules
  • Fix typos/grammar and trailing whitespace in EN welcome.htm
- "Welcome" menu item now uses absolute path `/sys/welcome.htm` (relative path failed to open when other tab was already open). ![image.png](/attachments/95807efd-7c16-4c0e-b0b1-305bdd5331ad) - Add full RU and ES translations of welcome.htm, keeping the original tone, plus per-language build rules - Fix typos/grammar and trailing whitespace in EN welcome.htm
Leency added 1 commit 2026-06-03 09:10:18 +00:00
menu.dat: set full path for welcome.htm
Build system / Check kernel codestyle (pull_request) Successful in 1m8s
Build system / Build (pull_request) Successful in 11m2s
3a683380a4
Burer added 1 commit 2026-06-04 10:44:31 +00:00
data/welcome.htm: add RU/ES translations, set absolute path, fix en text
Build system / Check kernel codestyle (pull_request) Successful in 1m38s
Build system / Build (pull_request) Successful in 11m46s
5621ed361e
- Add localized welcome.htm for RU and ES images
- Localize the ES menu label (Welcome -> Bienvenida).
- EN welcome.htm: fix typos/grammar and trailing whitespace.
Burer changed title from menu.dat: set full path for welcome.htm to data/menu: fix welcome.html path + localize welcome.htm to all system languages 2026-06-04 10:46:36 +00:00
Burer changed title from data/menu: fix welcome.html path + localize welcome.htm to all system languages to data/menu: fix welcome.htm path + localize welcome.htm to all system languages 2026-06-04 10:46:49 +00:00
Burer approved these changes 2026-06-04 12:12:30 +00:00
Burer requested review from ace-dent 2026-06-04 12:12:37 +00:00
Burer requested review from Doczom 2026-06-04 12:12:37 +00:00
Burer requested review from dunkaist 2026-06-04 12:12:37 +00:00
Member

@Leency - tested the floppy images from the CI build artefact.
Looks good for en_US. A bit confused why I cannot find sys/welcome.htm when using a file browser!?
Testing with RU and ES builds gives me Webpage Not Available error page html.

@Leency - tested the floppy images from the CI build artefact. Looks good for `en_US`. A bit confused why I cannot find `sys/welcome.htm` when using a file browser!? Testing with `RU` and `ES` builds gives me `Webpage Not Available` error page html.
Burer added 1 commit 2026-06-06 12:21:06 +00:00
data/welcome.htm: add to autobuild, remove styles, fix russian translation
Build system / Check kernel codestyle (pull_request) Successful in 24s
Build system / Build (pull_request) Successful in 10m5s
b52df69e9e
Owner

@ace-dent

Try now, please, should be fixed.

@ace-dent Try now, please, should be fixed.
Doczom approved these changes 2026-06-06 13:56:10 +00:00
Member

Thanks @Burer. Issues:

  • Builds have file named sys/Welcome.htm (Sentence case) but should be standardised to sys/welcome.htm (lowercase), to match URL path, etc.
  • Spanish es_ES build seems to have the wrong text encoding. Extended ASCII characters (with accents) appear as Cyrillic characters. See screenshot. e.g. programación --> programaciвn. Do we need to use code pages- or can we just use UTF-8?
Thanks @Burer. Issues: - Builds have file named `sys/Welcome.htm` (Sentence case) but should be standardised to `sys/welcome.htm` (lowercase), to match URL path, etc. - Spanish `es_ES` build seems to have the wrong text encoding. Extended ASCII characters (with accents) appear as Cyrillic characters. See screenshot. e.g. `programación` --> `programaciвn`. Do we need to use code pages- or can we just use UTF-8?
Burer added 1 commit 2026-06-06 16:39:48 +00:00
data/welcome.htm: convert all files to utf-8, set encoding in header
Build system / Check kernel codestyle (pull_request) Successful in 52s
Build system / Build (pull_request) Successful in 27m1s
0dd66517df
Owner

@ace-dent

I believe first problem is just display quirk in Eolite, as it displays all names in SentenceCase, while real names are UPPERCASE (to fit in 8.3 name standart).

Encoding problem should be fixed now, all thee documents are proper UTF-8 with corresponding meta in header.

@ace-dent I believe first problem is just display quirk in Eolite, as it displays all names in SentenceCase, while real names are UPPERCASE (to fit in 8.3 name standart). Encoding problem should be fixed now, all thee documents are proper UTF-8 with corresponding meta in header.
Member

Thanks @Burer. Spanish build now simply doesn't display those extended ASCII characters with accents. See screenshot.

Thanks @Burer. Spanish build now simply doesn't display those extended ASCII characters with accents. See screenshot.
Burer added 1 commit 2026-06-07 07:04:40 +00:00
data/welcome.htm: normalize encodings, line-endings and names
Build system / Check kernel codestyle (pull_request) Successful in 56s
Build system / Build (pull_request) Successful in 10m59s
8c03544599
Owner

@ace-dent

Should be fixed now, check, please.

@ace-dent Should be fixed now, check, please.
Member

@Burer - browsing your recent commit, you seem to have set every locale to CP-866 - including en_US? Also the Spanish version seems to be stripped of all accented characters ?

@Burer - browsing your recent commit, you seem to have set every locale to CP-866 - including `en_US`? Also the Spanish version seems to be stripped of all accented characters ?
Owner

@ace-dent

  1. Yes, as utf-8 gives much bigger file size for Cyrillic text, and current set of characters is fully supported by cp866 for all three languages. I could skip meta in header for EN and ES, as it is just pure ASCII now, but decided to write cp866 for consistency. It shouldn't affect file size in floppy sectors from what I can see.
  2. Yes, as even with utf-8 set in meta, KolibriOS seems to just not have that characters in charset or/and iconv.obj, so they were just skipped on rendering. Current ES text is fully valid - I rephrase words where it was needed.

UPD. Gitea now can display CP866 properly, so be carefull to not confuse it with UTF-8.

@ace-dent 1. Yes, as `utf-8` gives much bigger file size for Cyrillic text, and current set of characters is fully supported by `cp866` for all three languages. I could skip `meta` in header for EN and ES, as it is just pure ASCII now, but decided to write `cp866` for consistency. It shouldn't affect file size in floppy sectors from what I can see. 2. Yes, as even with `utf-8` set in meta, KolibriOS seems to just not have that characters in charset or/and iconv.obj, so they were just skipped on rendering. Current ES text is fully valid - I rephrase words where it was needed. UPD. Gitea now can display CP866 properly, so be carefull to not confuse it with UTF-8.
Member

@Burer -

  1. Sure CP-866 is more compact, but certainly for Spanish (and English!) we should stick to UTF-8; we only add an extra byte for an extended ASCII character, most are single byte characters- so it's not much overhead.
  2. Should the <meta> be inside <head> section? I'm not Spanish- but I would suggest it might be more acceptable to simply have the English text, rather than Spanish text with many words misspelled?
  3. I'm fairly sure the characters in question are all available in our system font. See screenshots. For example cafe should be café, and we have e-acute-accent as hex 0xE9.
@Burer - 1. Sure CP-866 is more compact, but certainly for Spanish (and English!) we should stick to UTF-8; we only add an extra byte for an extended ASCII character, most are single byte characters- so it's not much overhead. 2. Should the `<meta>` be inside `<head>` section? I'm not Spanish- but I would suggest it might be more acceptable to simply have the English text, rather than Spanish text with many words misspelled? 3. I'm fairly sure the characters in question are all available in our system font. See screenshots. For example `cafe` should be `café`, and we have e-acute-accent as hex `0xE9`.
Burer added 1 commit 2026-06-07 14:08:39 +00:00
data/welcome.htm: seta charset in header to utf-8 for EN and ES
Build system / Check kernel codestyle (pull_request) Successful in 26s
Build system / Build (pull_request) Failing after 40s
d05a424e55
Burer added 1 commit 2026-06-07 15:26:26 +00:00
data/welcome.htm: wrap meta and title inside head tag
Build system / Check kernel codestyle (pull_request) Successful in 26s
Build system / Build (pull_request) Failing after 35s
818f891939
Burer added 1 commit 2026-06-07 15:43:36 +00:00
Remove accidentally committed kterm submodule
Build system / Check kernel codestyle (pull_request) Successful in 25s
Build system / Build (pull_request) Successful in 17m52s
05a1361296
Member

LGTM

LGTM
ace-dent approved these changes 2026-06-07 16:07:52 +00:00
Burer merged commit 6e5f7642db into main 2026-06-07 16:11:27 +00:00
Burer deleted branch menu-fix-welcome-path 2026-06-07 16:11:27 +00:00
Sign in to join this conversation.
No labels
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#466