libraries/libmpg123: fix broken SVN repository link #469

Merged

Burer merged 1 commits from burer/PR-RefTextSVN-1-reopen AGit into main 2026-06-05 14:30:15 +00:00

Conversation 6 Commits 1 Files Changed 1

+1 -1

Burer commented 2026-06-03 16:25:25 +00:00

Owner

Copy Link

Copy Source

Re-opens #468 (accidentally merged, then rolled back from main). Resubmitting for review.

Re-opens #468 (accidentally merged, then rolled back from main). Resubmitting for review.

Burer referenced this pull request 2026-06-03 16:26:49 +00:00

libraries/libmpg123: Remove outdated link #468

Burer commented 2026-06-03 16:27:29 +00:00

Author

Owner

Copy Link

Copy Source

@ace-dent

Are you sure this URL is outdated?
I checked it, and it seems to be working.

@ace-dent Are you sure this URL is outdated? I checked it, and it seems to be working.

ace-dent commented 2026-06-04 12:41:36 +00:00

Member

Copy Link

Copy Source

@Burer - hmmm... I was assuming I could point a Browser at that URL and get something... perhaps SVN client might work? Please Close this PR if you feel it is not valid.

Background: I want to remove all unnecessary SVN text references from the source, to make cleaning up easier.

@Burer - hmmm... I was assuming I could point a Browser at that URL and get something... perhaps SVN client might work? Please Close this PR if you feel it is not valid. Background: I want to remove all unnecessary `SVN` text references from the source, to make cleaning up easier.

Burer commented 2026-06-05 05:28:30 +00:00

Author

Owner

Copy Link

Copy Source

@ace-dent

I see the problem now. Authors added SVN link, but prefixed it with http://, which is worng.

Proper link should be this:
svn://svn.mplayerhq.hu/mplayer/trunk

This way, it can be easily fetched using any SVN client.

I will modify this PR today, to fix link, not detele. Please, approve it after that.

Removing SVN references is valid when it comes to KolibriOS closed SVN server, but I see no reason to remove such third-party links, that leads to working (even if not updated in a long time) repos.

@ace-dent I see the problem now. Authors added SVN link, but prefixed it with `http://`, which is worng. Proper link should be this: `svn://svn.mplayerhq.hu/mplayer/trunk` This way, it can be easily fetched using any SVN client. <img alt="image.png" src="attachments/d0c1c5eb-7c87-4570-9aa5-1f28ca46f398"> I will modify this PR today, to fix link, not detele. Please, approve it after that. Removing SVN references is valid when it comes to KolibriOS closed SVN server, but I see no reason to remove such third-party links, that leads to working (even if not updated in a long time) repos.

image.png

84 KiB

Burer changed title from libraries/libmpg123: Remove outdated link to WIP: libraries/libmpg123: fix broken SVN repository link 2026-06-05 05:29:59 +00:00

Burer added 1 commit 2026-06-05 06:24:15 +00:00

libmpg123: fix outdated MPlayer link to the working svn:// URL ... 3ebabbe506

The http://svn.mplayerhq.hu/mplayer/trunk/ changelog URL in
dct36_3dnowext.S is dead, but the MPlayer SVN repository is still
reachable at svn://svn.mplayerhq.hu/mplayer/trunk. Point the comment
there instead of dropping the reference.

Burer force-pushed burer/PR-RefTextSVN-1-reopen from ddf8037ffb to 3ebabbe506 2026-06-05 06:24:15 +00:00 Compare

Burer marked the pull request as ready for review 2026-06-05 06:26:17 +00:00

Burer requested review from ace-dent 2026-06-05 06:26:22 +00:00

Burer requested review from Doczom 2026-06-05 06:26:22 +00:00

Burer requested review from dunkaist 2026-06-05 06:26:22 +00:00

Burer requested review from Leency 2026-06-05 06:26:22 +00:00

ace-dent commented 2026-06-05 08:00:30 +00:00

Member

Copy Link

Copy Source

@Burer LGTM

@Burer LGTM

❤️ 1

ace-dent approved these changes 2026-06-05 08:00:50 +00:00

Doczom approved these changes 2026-06-05 14:24:50 +00:00

Burer merged commit 618b0389ff into main 2026-06-05 14:30:15 +00:00

Egor00f referenced this issue from a commit 2026-06-06 15:23:29 +00:00

libraries/libmpg123: fix broken SVN repository link (#469)

Sign in to join this conversation.

Reviewers

No Reviewers

dunkaist

Leency

ace-dent

Doczom

Labels

Clear labels

Influence/Text/TYPO

AI

Eolite

FS

GSoC

This issue or PR in the Google Source of Code program

Good First PR

The issue is suitable to beginners

HLL

HardwareTested

IRCC

Influence/Settings

Lang/C

Lang/FASM

Pay for the code

Paid task

Subsystem/API

Subsystem/Audio

infinity service, audio drivers, midi, speacker, audio programs

Subsystem/Graphics

vesa, vga, framebuffer, cursors, blitter, and video drivers

Subsystem/IPC and events

pipes, signals, events, shared memory

Subsystem/Memory

virt and phys memory allocators, malloc and other

Subsystem/Network

Subsystem/Services(daemon)

userspace and kernel(for example: serial) services

Subsystem/Taskmanager

process, threads, run apps, scheduler

Subsystem/VFS

drivers from filesystem, fs api, blkdev, programs that work with the file system

Subsystem/Window

windows, skins, buttons, mouse and keyboard code for windows (not the base code)

Category

Applications

Category

Drivers

Category

General

Category

Kernel

Category

Libraries

Kind

Breaking

Breaking change that won't be backward compatible

Kind

Bug

Something is not working

Kind

Build

Kind

Documentation

Documentation changes

Kind

Enhancement

Improve existing functionality

Kind

Feature

New functionality

Kind

Security

This is security issue

Kind

Testing

Issue or pull request related to testing

PR

Ready to merge

Pull request is ready for merge

PR

Conflicts

PR conflicts with main

PR

Dependent

This PR is dependent on another PR

PR

Request changes

Changes requested in pull request

PR

Review required

Priority

Critical

1

The priority is critical

Priority

High

2

The priority is high

Priority

Medium

3

The priority is medium

Priority

Low

4

The priority is low

Reviewed

Confirmed

Issue has been confirmed

Reviewed

Duplicate

This issue or pull request already exists

Reviewed

Invalid

Invalid issue

Reviewed

Won't Fix

This issue won't be fixed

Status

Abandoned

Somebody has started to work on this but abandoned work

Status

Blocked

Something is blocking this issue or pull request

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

ace-dent (Andrew) b00bl1k (Alexey Ryabov) bad_Dr3dd0x Burer Doczom (Mikhail Frolov) dunkaist (Ivan B) Egor00f (Егор Ярин) hidnplayr IgorA Leency (Kiril Lipatov) mxlgv (Max Logaev) ramenu rgimad sdongles (Serhii Sakhno) Sweetbread (Gleb Zaharov)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#469