kernel: fix minor typos #485
Dismiss Review
Are you sure you want to dismiss this review?
Labels
Clear labels
Eolite
FS
Good First PR
GSoC
HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Lang/C
Lang/FASM
Pay for the code
Subsystem/API
Subsystem/Audio
Subsystem/Graphics
Subsystem/IPC and events
Subsystem/Memory
Subsystem/Network
Subsystem/Services(daemon)
Subsystem/Taskmanager
Subsystem/VFS
Subsystem/Window
Category
Applications
Category
Drivers
Category
General
Category
Kernel
Category
Libraries
The issue is suitable to beginners
This issue or PR in the Google Source of Code program
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
infinity service, audio drivers, midi, speacker, audio programs
vesa, vga, framebuffer, cursors, blitter, and video drivers
pipes, signals, events, shared memory
virt and phys memory allocators, malloc and other
userspace and kernel(for example: serial) services
process, threads, run apps, scheduler
drivers from filesystem, fs api, blkdev, programs that work with the file system
windows, skins, buttons, mouse and keyboard code for windows (not the base code)
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Total Time Spent: 1 hour 45 minutes
ace-dent
1 hour 45 minutes
No due date set.
Depends on
#487 kernel: expand CP850 macro
KolibriOS/kolibrios
Reference: KolibriOS/kolibrios#485
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
äandüin German boot screen text.CRLF>LFand trailing whitespace removed automatically due to.editorconfig; best to view diffs with whitespace changes at EOL hidden.be4d61a252tof8c64f88ce6d2f98f40etof8c64f88cef8c64f88cetod9fea5a926Sorry, I miss-clicked
@Sweetbread - no worries. Thanks for the speedy review! 🙏
Hi, @ace-dent!
As always, thank you for this routine work.
I run a few spellcheckers over kernel folder, and here is all the results I found.
I suppose, we should go over all of them.
I am ready to help with fixing all of these on weekend.
Just, please, be carefull to not break anything when editing not comments, as sometimes code can rely on specific length of text, or even specific chars.
Part A - English
kernel/trunk/asmxygen.py:258 -openned=>openedkernel/trunk/asmxygen.py:787 -Skept=>Skippedkernel/trunk/asmxygen.py:942 -coment=>commentkernel/trunk/blkdev/ahci.inc:163 -correspoding=>correspondingkernel/trunk/blkdev/bd_drv.inc:253 -simultaniously=>simultaneouslykernel/trunk/blkdev/cd_drv.inc:174 -TRASMIT=>TRANSMITkernel/trunk/blkdev/cd_drv.inc:443 -occured=>occurredkernel/trunk/blkdev/flp_drv.inc:201 -occured=>occurredkernel/trunk/boot/bootvesa.inc:118 -swith=>switchkernel/trunk/boot/bootvesa.inc:440 -bellow=>belowkernel/trunk/bootloader/uefi4kos/kolibri.ini:18 -alowed=>allowedkernel/trunk/bus/usb/common.inc:65 -occured=>occurredkernel/trunk/bus/usb/hub.inc:772 -occured=>occurredkernel/trunk/const.inc:103 -virual=>virtual,visual,viralkernel/trunk/const.inc:174 -priviledge=>privilegekernel/trunk/core/heap.inc:862 -chek=>checkkernel/trunk/core/heap.inc:889 -addres=>addresskernel/trunk/core/memory.inc:1343 -addres=>addresskernel/trunk/core/mtrr.inc:117 -recongifure=>reconfigurekernel/trunk/core/taskman.inc:673 -infomation=>informationkernel/trunk/core/v86.inc:248 -occured=>occurredkernel/trunk/detect/dev_hdcd.inc:225 -Standart=>Standardkernel/trunk/detect/dev_hdcd.inc:266 -occured=>occurredkernel/trunk/detect/dev_hdcd.inc:394 -readyness=>readinesskernel/trunk/docs/sysfuncs.txt:228 -Paramters=>Parameterskernel/trunk/docs/sysfuncs.txt:1768 -Paramters=>Parameterskernel/trunk/docs/sysfuncs.txt:2927 -interpretes=>interpretskernel/trunk/docs/sysfuncs.txt:5233 -occured=>occurredkernel/trunk/docs/sysfuncs.txt:5286 -successfull=>successfulkernel/trunk/docs/sysfuncs.txt:5304 -successfull=>successfulkernel/trunk/docs/usbapi.txt:157 -occured=>occurredkernel/trunk/docs/usbapi.txt:174 -occured=>occurredkernel/trunk/fs/exfat.inc:51 -availabe=>availablekernel/trunk/fs/exfat.inc:1881 -Bloks=>Blocks,Blokeskernel/trunk/fs/fat.inc:62 -availabe=>availablekernel/trunk/fs/iso9660.inc:948 -programm=>program,programmekernel/trunk/fs/iso9660.inc:974 -copping=>coping,copying,croppingkernel/trunk/fs/ntfs.inc:414 -adress=>addresskernel/trunk/fs/xfs.asm:144 -AGs=>tags,ageskernel/trunk/gui/background.inc:511 -bufer=>bufferkernel/trunk/gui/event.inc:40 -previos=>previouskernel/trunk/kernel.asm:2245 -varify=>verifykernel/trunk/kernel.asm:2529 -sheduler=>schedulerkernel/trunk/kernel.asm:2538 -sheduler=>schedulerkernel/trunk/kernel.asm:3265 -succesful=>successfulkernel/trunk/kernel.asm:3278 -succesful=>successfulkernel/trunk/kernel.asm:4126 -bufer=>bufferkernel/trunk/kernel.asm:4350 -standart=>standardkernel/trunk/kernel.asm:4441 -Lenght=>Lengthkernel/trunk/network/ARP.inc:441 -entrys=>entries,entrykernel/trunk/network/IPv4.inc:197 -wich=>whichkernel/trunk/network/IPv4.inc:279 -definately=>definitelykernel/trunk/network/IPv4.inc:485 -substract=>subtractkernel/trunk/network/IPv4.inc:546 -remeber=>rememberkernel/trunk/network/queue.inc:36 -entrys=>entries,entrykernel/trunk/network/tcp_input.inc:141 -substract=>subtractkernel/trunk/network/tcp_input.inc:333 -occured=>occurredkernel/trunk/network/tcp_input.inc:1158 -lineary=>linearlykernel/trunk/network/tcp_input.inc:1245 -handeling=>handlingkernel/trunk/network/tcp_output.inc:268 -bufer=>bufferkernel/trunk/network/tcp_subr.inc:488 -persistance=>persistencekernel/trunk/network/udp.inc:118 -substract=>subtractkernel/trunk/sec_loader/boot_st.inc:51 -parametr=>parameterkernel/trunk/sec_loader/boot_st.inc:52 -parametr=>parameterkernel/trunk/sec_loader/boot_st.inc:53 -parametr=>parameterkernel/trunk/sec_loader/boot_st.inc:60 -Incorect=>Incorrectkernel/trunk/sec_loader/boot/build.bat:3 -bulding=>buildingkernel/trunk/sec_loader/boot/build.bat:13 -firs=>firstkernel/trunk/sec_loader/debug_msg.inc:29 -Adress=>Addresskernel/trunk/sec_loader/listing.inc:179 -unfortunatelly=>unfortunatelykernel/trunk/sec_loader/loader.lst:34 -parametr=>parameterkernel/trunk/sec_loader/loader.lst:38 -parametr=>parameterkernel/trunk/sec_loader/loader.lst:43 -parametr=>parameterkernel/trunk/sec_loader/loader.lst:71 -Incorect=>Incorrectkernel/trunk/sec_loader/parse_any.inc:434 -chacking=>checkingkernel/trunk/sec_loader/parse_any.inc:448 -chacking=>checkingkernel/trunk/sec_loader/parse_any.inc:484 -parametrs=>parameterskernel/trunk/sec_loader/parse_any.inc:497 -bufer=> bufferkernel/trunk/sec_loader/parse_def_sect.inc:514 -dafault=>defaultkernel/trunk/sec_loader/parse_def_sect.inc:1312 -adress=>addresskernel/trunk/sec_loader/parse_def_sect.inc:1679 -desination=>destinationkernel/trunk/sec_loader/parse_def_sect.inc:1742 -convertion=>conversionkernel/trunk/sec_loader/parse_def_sect.inc:1768 -succesfuly=>successfullykernel/trunk/sec_loader/parse_loader.inc:41 -alredy=>alreadykernel/trunk/sec_loader/parse_loader.inc:62 -previosly=>previouslykernel/trunk/sec_loader/parse_loader.inc:73 -parametrs=>parameterskernel/trunk/sec_loader/parse_loader.inc:194 -parametrs=>parameterskernel/trunk/sec_loader/parse.inc:67 -parametrs=>parameterskernel/trunk/sec_loader/sl_equ.inc:41 -statick=>statickernel/trunk/sec_loader/sl_equ.inc:70 -scroling=>scrollingkernel/trunk/sec_loader/sl_equ.inc:70 -poin=>pointkernel/trunk/sec_loader/sl_equ.inc:81 -previos=>previouskernel/trunk/sec_loader/startos.ini:76 -Standart=>Standardkernel/trunk/video/framebuffer.inc:145 -standart=>standardkernel/trunk/video/vesa20.inc:942 -begining=>beginningkernel/trunk/video/vesa20.inc:969 -begining=>beginningStylistic / Optional (36)
kernel/trunk/blkdev/ahci.inc:1416 -doesnt=>doesn't,does notkernel/trunk/blkdev/ahci.inc:1430 -doesnt=>doesn't,does notkernel/trunk/blkdev/cd_drv.inc:323 -DOESNT=>DOESN'T,DOES NOTkernel/trunk/blkdev/flp_drv.inc:72 -readed=>read,re-add,re-addedkernel/trunk/blkdev/flp_drv.inc:145 -doesnt=>doesn't,does notkernel/trunk/boot/bootvesa.inc:229 -isnt=>isn'tkernel/trunk/core/apic.inc:240 -readed=>read,re-add,re-addedkernel/trunk/core/mtrr.inc:558 -splitted=>splitkernel/trunk/core/mtrr.inc:559 -splitted=>splitkernel/trunk/docs/sysfuncs.txt:687 -deactive=>deactivatekernel/trunk/docs/sysfuncs.txt:1123 -doubleclick=>double-clickkernel/trunk/docs/sysfuncs.txt:1129 -doubleclick=>double-clickkernel/trunk/docs/sysfuncs.txt:1131 -doubleclick=>double-clickkernel/trunk/docs/sysfuncs.txt:1136 -doubleclick=>double-clickkernel/trunk/docs/sysfuncs.txt:1844 -doubleclick=>double-clickkernel/trunk/gui/mouse.inc:393 -isnt=>isn'tkernel/trunk/kernel.asm:76 -bootup=>boot up,boot-upkernel/trunk/kernel.asm:1954 -deactive=>deactivatekernel/trunk/network/IPv4.inc:287 -hasnt=>hasn'tkernel/trunk/network/socket.inc:1167 -allright=>all right,alrightkernel/trunk/network/socket.inc:1369 -eachother=>each otherkernel/trunk/network/tcp_input.inc:443 -didnt=>didn'tkernel/trunk/network/tcp_input.inc:961 -didnt=>didn'tkernel/trunk/network/tcp_input.inc:1486 -didnt=>didn'tkernel/trunk/network/tcp_output.inc:127 -havent=>haven'tkernel/trunk/network/tcp_output.inc:277 -didnt=>didn'tkernel/trunk/network/tcp_usreq.inc:128 -didnt=>didn'tkernel/trunk/network/udp.inc:348 -didnt=>didn'tkernel/trunk/runtests.py:114 -unuseful=>uselesskernel/trunk/runtests.py:212 -dependant=>dependentkernel/trunk/runtests.py:214 -dependant=>dependentkernel/trunk/sec_loader/listing.inc:94 -MACROSES=>MACROSkernel/trunk/sec_loader/listing.inc:133 -MACROSES=>MACROSkernel/trunk/sec_loader/listing.inc:262 -MACROSES=>MACROSkernel/trunk/sec_loader/listing.inc:354 -MACROSES=>MACROSkernel/trunk/sec_loader/listing.inc:506 -MACROSES=>MACROSRussian -
kernel/trunk/boot/bootstr-ru_RU.incГАРAНТИЙ=>ГАРАНТИЙ- LatinAinside a Cyrillic word (mixed script)Нажимите=>Нажмите- wrong verb form; line 51 already uses the correctНажмитеGerman -
kernel/trunk/boot/bootstr-de_DE.incWahlen=>Wählen/Waehlen- dropped umlautvideomode=>Videomodus- English + lowercase; L40/L58 already useVideomodusDrucken=>Drücken/Druecken- meaning change: Drucken = to print, Drücken = to presswahlen=>wählen/waehlen- dropped umlautneutzen=>benutzen- not a word, typofur(×2) =>für/fuer- dropped umlautgewahlt=>gewählt/gewaehlt- dropped umlauthangen=>hängen/haengen- dropped umlautEstonian -
kernel/trunk/boot/bootstr-et_EE.incvideomode- English word; the rest of the file usesvideo resolutsioonesimese programm- possible grammar (case agreement), needs native reviewvõimaldama ... keelake ... teha- mixed mood (infinitive vs imperativekeelake), needs native review@Burer - thanks for finding more work! 😅
I presume you are using AI here?
I'd prefer to keep PR's small / atomic for easier review and faster merging. Can you move your TODO list into an Issue, and we can tackle it with separate PRs?
These few typos already touch 20 files. I'd like to get this merged as is, please.
d9fea5a926toa57dadb62dThanks @Sweetbread for taking on the German text.
Is there a reason to include in this PR rather than creating a separate one?It is not work I'm able to test or verify... sadly I don't know any German :-/
If you strongly feel it should be merged with my changes, please can you modify the PR's text to include your changes.@ace-dent
I used
codespellandpyspellcheckerfor raw results, and Claude AI for filtering, as they contained many false positives.I have nothing againsts splitting this PR into smaller ones, but is there any principle in current changes? They touches files in 11 different folders inside
kernel/trunk.Maybe it would be better to go through folders one by one?
I can reorganize my list for this.
@Sweetbread
Are you sure using umlaut in kernel files is a good idea?
I believe they should stay as ASCII-pure as possible, at least code itself.
Thanks @Burer - no need to reorganise the list (for me!).
As a compromise- can we just do theen_ENchanges on this PR?@ace-dent
I see no problems in that.
But changes in other languages are relatively small (like, overall 13 entries), and I am ready to review Russian and Estonian, and Sweetbread is ready to review German, so is it really worth splitting?
But once again, it's totally up to you, and it's totally okay for me.
@Burer - if you're happy to take responsibility for Quality Assurance on those languages- it's fine by me. :-)
I just don't have the language skills, or the ability to produce custom builds (
de_DE, etc.) for testing.@ace-dent
I am ready :)
And, as soon as
DEandESdoesn't build at all, at least for now, we don't really have any risk here, I suppose.Cause to add them to autobuild properly, many files would need to be updated to match mainstream versions anyway.
Thus, I will commit changes to
RU,DE,ESfiles later today.@Burer -
Well... this is my concern! Changing the characters in the
de_DEboot screen may well break things!I know from previous work this is a delicate area using some character set 'hacks' (overlays).
Because I'm the author of this PR, I don't want breaking changes introduced under my name! 🙏
I politely request that anything we cannot test should be in a separate PR.
Ich lerne Deutsch a bit and can confirm, that für is actually spelled with an umlaut. Also, I don't think we should divide those small typos by languages
@ace-dent
I will review code in detail to make sure changes in code don't break anything for each of the touched languages.
Also, all responsibilities for the possible bad result lie on me as a reviewer in this case.
I am almost sure that DE and EE builds are broken right now, so even if we commit something wrong, it would be just a small piece of all the things we would need to fix if we would like to restore those builds one day.
If you really want, I can pull non-EN changes into a separate PR, no problem.
029947872ato403dcfde30225f9fae26toa0a54fe597a0a54fe597toadc8c96388ad00d1d8edtof40d213fa9f40d213fa9tob0ae7b7e83@Sweetbread - You can now useäandüin German boot screen. It is necessary to use the CP850 encoding macro. For reference, see:bootstr-es_ES.inc. Personally I'd only use the macro on text-lines that require it.Fixes removed to merge via dedicated PR. See #487
b0ae7b7e83tob967b56ec2@Sweetbread with #487 merged, we can use the
cp850macro with the German boot strings. Would you like to fix in a commit, or shall I have a go? Cheers.Hi @Sweetbread @Burer - this PR has been open for awhile... I will fix the German issues now and suggest we move the
et_EEto a dedicated issue- if none of us are fluent in Estonian. Then we can move this towards getting merged.Ready for review. 🙏
Issues identified by @Burer that have not been addressed, are covered by #488 and #505
kernel: minor typosto kernel: fix minor typosThanks @Burer for the recent commit. How does this affect
kernel/trunk/sec_loader/loader.lstas noted in PR #488 ?Is there a reason to not fix the variable name
incorect_section_define?Verified. sec_loader should not break
@ace-dent
I decided not to fix it, as it would require more deep digging in code to fix it everywhere properly.
Let's keep complex things for another PR.