kernel: expand CP850 macro #487

2026-06-09T16:24:26Z

ace-dent commented

2026-06-09 16:24:26 +00:00

Add more detailed (and precise) comments.
Expand cp850 macro to encode more code points; useful for German characters ä and ü.
Note: all of the current CP850 encodings map directly to CP437.

- Add more detailed (and precise) comments. - Expand `cp850` macro to encode more code points; useful for German characters `ä` and `ü`. - Note: all of the current CP850 encodings map directly to CP437.

ace-dent added the

labels 2026-06-09 16:24:26 +00:00

ace-dent added 1 commit 2026-06-09 16:24:26 +00:00

kernel: expand CP850 macro

Build system / Check kernel codestyle (pull_request) Successful in 50s

Details

Build system / Build (pull_request) Successful in 17m16s

Details

46839bf81a

- Add more detailed (and precise) comments.
- Expand `cp850` macro to encode more code points; useful for German characters `ä` and `ü`.
- Note: all of the current CP850 encodings map directly to CP437.

ace-dent requested review from Burer 2026-06-09 16:24:26 +00:00

ace-dent requested review from Doczom 2026-06-09 16:24:26 +00:00

ace-dent requested review from dunkaist 2026-06-09 16:24:27 +00:00

ace-dent requested review from Sweetbread 2026-06-09 16:24:27 +00:00

ace-dent referenced this pull request

2026-06-09 16:40:25 +00:00

kernel: fix minor typos #485

Burer added a new dependency 2026-06-09 16:50:03 +00:00

#485 kernel: fix minor typos

ace-dent commented

2026-06-09 16:52:27 +00:00

This PR is necessary to fix some typos on the German de_DE boot screen, which will be addressed by #485 .

This PR is necessary to fix some typos on the German `de_DE` boot screen, which will be addressed by #485 .

Burer added 1 commit 2026-06-10 12:59:33 +00:00

kernel/encoding: clarify CP437/850 comment

Build system / Check kernel codestyle (pull_request) Successful in 29s

Details

Build system / Build (pull_request) Successful in 9m53s

Details

ea4bea4178

Burer approved these changes 2026-06-10 13:03:53 +00:00

Leency approved these changes 2026-06-11 20:15:38 +00:00

ace-dent commented

2026-06-12 03:05:51 +00:00

@Burer - I don't want to stall merging, but the comment you changed was a useful note to future developers (and me!). Were you concerned it wasn't accurate?

Burer commented

2026-06-12 05:44:51 +00:00

@ace-dent

Yes, many codepoints in initial range are actually different for CP437 and C850 - mosty symbols for box drawing, that are not present in CP850.

@ace-dent Yes, many codepoints in initial range are actually different for CP437 and C850 - mosty symbols for box drawing, that are not present in CP850. ![image.png](/attachments/009eb804-4423-44b0-aeb7-51a9396cde0a)

image.png

27 KiB

👍 1

ace-dent commented

2026-06-12 22:17:22 +00:00