KolibriOS/kolibrios
16
26
Fork 65
Code Issues 153 Pull Requests 45 Actions Projects 2 Releases Wiki Activity

ci/cd: fix tup cache rebuild #525

Merged
Burer merged 2 commits from ci/fix-tup-cache-rebuild into main 2026-06-26 06:15:53 +00:00
Conversation 2 Commits 2 Files Changed 3
+72 -16
Burer commented 2026-06-25 14:57:30 +00:00
Owner
Copy Link
Copy Source

Problem: sync-tup-ctime.py realigned every node's ctime, which hid real source changes whose Tupfile didn't change.

Fix: stamp the cache with its commit and on restore, git diff against it, keeping changed files dirty so tup rebuilds them.

Problem: `sync-tup-ctime.py` realigned every node's ctime, which hid real source changes whose Tupfile didn't change. Fix: stamp the cache with its commit and on restore, `git diff` against it, keeping changed files dirty so tup rebuilds them.
Burer added 1 commit 2026-06-25 14:57:30 +00:00
ci/cd: fix tup cache rebuild
Test PR / Build (ru_RU) (pull_request) Successful in 10m14s
Details
Test PR / Build (en_US) (pull_request) Successful in 10m19s
Details
Test PR / Build (es_ES) (pull_request) Successful in 10m19s
Details
ecb794cfb7
Burer requested review from Developers 2026-06-25 14:57:31 +00:00
Burer requested review from Owners 2026-06-25 14:57:31 +00:00
Burer added the
Kind
Bug
Priority
Critical
1
 labels 2026-06-25 14:59:05 +00:00
Doczom approved these changes 2026-06-25 17:56:59 +00:00
Sweetbread added
Priority
Medium
3
 and removed
Priority
Critical
1
 labels 2026-06-25 20:27:20 +00:00
Sweetbread approved these changes 2026-06-25 20:41:52 +00:00
Burer added 1 commit 2026-06-26 06:02:55 +00:00
ci/cd: fix dirty-path matching in tup cache sync
Test PR / Build (es_ES) (pull_request) Successful in 11m52s
Details
Test PR / Build (en_US) (pull_request) Successful in 11m56s
Details
Test PR / Build (ru_RU) (pull_request) Successful in 12m0s
Details
d18152c9a3 
The changed-files forcing never matched any tup node, so files changed
since the cached commit were silently realigned as clean instead of
forced dirty -- tup would skip rebuilding them (stale builds).

Two format mismatches between git's output and tup's node paths:

- tup's root dir node is named ".", so reconstructed paths came out as
  "./foo/bar" while git emits "foo/bar". Build the path with explicit
  forward slashes (host-independent) and strip the leading "./".
- git C-quotes non-ASCII paths by default (e.g. the cyrillic filename
  programs/develop/tinypy/examples/сlicker.py), which never matches the
  raw UTF-8 tup node name. Pass -c core.quotePath=false on git diff and
  read the changed-files list as UTF-8.

Also report matched/total changed paths and warn loudly when a non-empty
dirty list matches zero nodes, so a future format drift fails visibly
instead of silently shipping stale artifacts.
Burer merged commit 481b5779b8 into main 2026-06-26 06:15:53 +00:00
Burer deleted branch ci/fix-tup-cache-rebuild 2026-06-26 06:15:53 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Doczom
Sweetbread
KolibriOS/Developers
Labels
Clear labels
AI
Category
Applications
Category
Drivers
Category
General
Category
Kernel
Category
Libraries
Eolite
FS
Good First PR
The issue is suitable to beginners
 GSoC
This issue or PR in the Google Source of Code program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Lang/C
Lang/FASM
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Subsystem/API
Subsystem/Audio
infinity service, audio drivers, midi, speacker, audio programs
 Subsystem/Graphics
vesa, vga, framebuffer, cursors, blitter, and video drivers
 Subsystem/IPC and events
pipes, signals, events, shared memory
 Subsystem/Memory
virt and phys memory allocators, malloc and other
 Subsystem/Network
Subsystem/Services(daemon)
userspace and kernel(for example: serial) services
 Subsystem/Taskmanager
process, threads, run apps, scheduler
 Subsystem/VFS
drivers from filesystem, fs api, blkdev, programs that work with the file system
 Subsystem/Window
windows, skins, buttons, mouse and keyboard code for windows (not the base code)
No labels
Kind
Bug
Priority
Medium
3
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
ace-dent (Andrew) b00bl1k (Alexey Ryabov) bad_Dr3dd0x Burer Doczom (Mikhail Frolov) dunkaist (Ivan B) Egor00f (Егор Ярин) hidnplayr IgorA Leency (Kiril Lipatov) mxlgv (Max Logaev) ramenu rgimad sdongles (Serhii Sakhno) Sweetbread (Gleb Zaharov)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#525