apps/fplay: major player updates, performance, usability and UI improvements, bugfixes #560
Dismiss Review
Are you sure you want to dismiss this review?
Labels
Clear labels
Influence/Text/TYPO
AI
Eolite
FS
GSoC
Good First PR
HLL
HardwareTested
IRCC
Influence/Settings
Lang/C
Lang/FASM
Pay for the code
Subsystem/API
Subsystem/Audio
Subsystem/Graphics
Subsystem/IPC and events
Subsystem/Memory
Subsystem/Network
Subsystem/Services(daemon)
Subsystem/Taskmanager
Subsystem/VFS
Subsystem/Window
This issue or PR in the Google Source of Code program
The issue is suitable to beginners
Paid task
infinity service, audio drivers, midi, speacker, audio programs
vesa, vga, framebuffer, cursors, blitter, and video drivers
pipes, signals, events, shared memory
virt and phys memory allocators, malloc and other
userspace and kernel(for example: serial) services
process, threads, run apps, scheduler
drivers from filesystem, fs api, blkdev, programs that work with the file system
windows, skins, buttons, mouse and keyboard code for windows (not the base code)
Category
Applications
Category
Drivers
Category
General
Category
Kernel
Category
Libraries
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
PR
Ready to merge
Pull request is ready for merge
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
PR
Request changes
Changes requested in pull request
PR
Review required
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: KolibriOS/kolibrios#560
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Very briefly:
Новые возможности
Улучшено управление
Исправления
Fplay: major player updates, performance, usability and UI improvements, bugfixesto apps/fplay: major player updates, performance, usability and UI improvements, bugfixesThe changes look logical and I don’t see any obvious issues. No blocking comments from my side.
That said, I assume that the full context and potential impact on related systems are best known to the author and the team, so the final deployment decision and any associated risks remain with them — as per our usual review practice. My approval is a sanity check, not a full-scope guarantee.
pxgl.c (pixlib-gl.dll): - update_fb() declared a local "EGLImageKHR screen" that was never assigned, then overwrote px->screen with it right after the real screen EGLImage had been created and validated. px->screen ended up as stack garbage, so any later use or destruction of the screen image was undefined. Drop the dead local and the bogus assignment. pixlib3.c: - pxInit() used to be one-shot: once any driver was set, every later call returned early, so pxInit(0) could not switch to the software path after the GL driver had been loaded. Rework the init state: * pxInit(0) now always selects the software driver; * a successfully initialized HW driver is cached and reused; * a failed HW probe is remembered and not retried (no repeated slow service/dll probing); * pxFini() finalizes the cached HW driver and resets the state so a full re-init is possible. This lets a client probe the hardware path at runtime and fall back to software rendering (used by FPlay's present self-test: on setups where GL initializes but never reaches the screen, e.g. Intel GMA 3150 with the KMS driver, the player now detects it and switches to the software blitter instead of showing a black window). data/common/lib/pixlib-gl.dll: rebuilt with the fix. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>abbae96e8ato26be5afb58