apps/pcidev: calculate window height based on device count #562

Merged
Burer merged 2 commits from pcidev-precalculate-winh into main 2026-07-19 06:18:33 +00:00
Owner

Currently: pcidev gets all screen height
After fix: pcidev pre-calculate window height based on device count

Currently: pcidev gets all screen height After fix: pcidev pre-calculate window height based on device count
Leency requested review from Developers 2026-07-09 23:56:06 +00:00
Leency requested review from Owners 2026-07-09 23:56:07 +00:00
Burer approved these changes 2026-07-11 18:08:45 +00:00
Doczom requested changes 2026-07-13 22:18:41 +00:00
Dismissed
@@ -56,6 +56,7 @@ load_libraries l_libs_start,end_l_libs
mcall SF_SYS_MISC,SSF_MEM_ALLOC,4096*4 ; 16 Kb - I hope this will be enough for store of data
mov [store_text_area_start],eax
;-----------------------------------------------------------------------------
call calc_window_height ; fit window height to the number of devices
Owner

The height of the header is obtained only once, without taking into account changes in the height of the header during the program operation.

The height of the header is obtained only once, without taking into account changes in the height of the header during the program operation.
Owner

Should be fixed.

Should be fixed.
Doczom marked this conversation as resolved
@@ -377,0 +386,4 @@
imul eax, 10 ; each row is 10 pixels
add eax, 110 + 30 ; header area + bottom margin (~3 lines)
push eax
mcall 48, 4 ; get skin height into eax
Owner

magic numbers instead of constants

magic numbers instead of constants
Owner

Should be fixed.

Should be fixed.
Doczom marked this conversation as resolved
Burer changed title from pcidev: pre-calculate window height based on device count to apps/pcidev: calculate window height based on device count 2026-07-18 15:23:22 +00:00
Doczom approved these changes 2026-07-18 19:19:56 +00:00
Doczom left a comment
Owner

костыли, но да фиг с ними

костыли, но да фиг с ними
Owner

костыли, но да фиг с ними

Потом перепишу полностью, чтобы юзеры могли отправлять инфу о том, что у них работает, а что - нет.

> костыли, но да фиг с ними Потом перепишу полностью, чтобы юзеры могли отправлять инфу о том, что у них работает, а что - нет.
Burer added 2 commits 2026-07-19 06:14:36 +00:00
pcidev: reserve room for the MMIO block, follow skin changes
Test PR / Build (es_ES) (pull_request) Successful in 1m49s
Test PR / Build (ru_RU) (pull_request) Successful in 1m56s
Test PR / Build (en_US) (pull_request) Successful in 2m2s
19a95e5804
Try_MMIO draws below the last device: 7 BARs of up to 2 lines, so 140
pixels, not the 30 that were reserved.

The skin was measured once at startup. Measure it on every redraw and
apply only the difference, so a size the user picked is not discarded.

Name the numbers the height is built from.
Burer force-pushed pcidev-precalculate-winh from db7251041a to 19a95e5804 2026-07-19 06:14:36 +00:00 Compare
Burer merged commit bb58df2d87 into main 2026-07-19 06:18:33 +00:00
Burer deleted branch pcidev-precalculate-winh 2026-07-19 06:18:33 +00:00
Sign in to join this conversation.
No Reviewers
KolibriOS/Developers
No labels
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#562