KolibriOS/kolibrios
17
27
Fork 69
Code Issues 157 Pull Requests 49 Actions 1 Projects 2 Releases Wiki Activity

libimg: added support for saving 8-bit images in PNG format #599

Merged
Burer merged 1 commits from libimg-png-8-bit into main 2026-09-07 11:14:23 +00:00
Conversation 3 Commits 1 Files Changed 5
+247 -112
IgorA commented 2026-07-24 06:09:15 +00:00
Member
Copy Link
Copy Source

Еxample of an 8-bit png image with a palette https://git.kolibrios.org/KolibriOS/kolibrios/src/branch/main/programs/develop/libraries/TinyGL/asm_fork/examples/text_2.png

Еxample of an 8-bit png image with a palette https://git.kolibrios.org/KolibriOS/kolibrios/src/branch/main/programs/develop/libraries/TinyGL/asm_fork/examples/text_2.png
IgorA added the
Category
Libraries
Lang/FASM labels 2026-07-27 08:48:58 +00:00
Burer requested changes 2026-08-24 07:57:04 +00:00
Dismissed
Burer left a comment
Owner
Copy Link
Copy Source

🟡 get_pallete_colors derives the palette size by scanning for two adjacent zero dwords. That's fine for libimg-generated bpp8i images (compact palette + zero tail), but a legitimate palette containing two consecutive 0x00000000 entries mid-array would be truncated early, under-counting colormap_entries and corrupting pixels that index past the written palette. Please either document the assumption (palette must end with ≥2 zero entries) or pass the real entry count explicitly if it's known upstream.

🟡 `get_pallete_colors` derives the palette size by scanning for two adjacent zero dwords. That's fine for libimg-generated bpp8i images (compact palette + zero tail), but a legitimate palette containing two consecutive `0x00000000` entries mid-array would be truncated early, under-counting `colormap_entries` and corrupting pixels that index past the written palette. Please either document the assumption (palette must end with ≥2 zero entries) or pass the real entry count explicitly if it's known upstream.
Burer approved these changes 2026-08-24 07:57:14 +00:00
Doczom approved these changes 2026-08-28 16:27:15 +00:00
Burer added 1 commit 2026-09-07 10:38:50 +00:00
libimg: added support for saving 8-bit images in PNG format
Test PR / Build (en_US) (pull_request) Successful in 3m38s
Details
Test PR / Build (es_ES) (pull_request) Successful in 3m15s
Details
Test PR / Build (ru_RU) (pull_request) Successful in 2m34s
Details
bd6ff68016
Burer force-pushed libimg-png-8-bit from 77b3d793ab to bd6ff68016 2026-09-07 10:38:50 +00:00 Compare
CODEOWNERS rules requested review from system 2026-09-07 10:38:51 +00:00
Burer merged commit a3af661ed6 into main 2026-09-07 11:14:23 +00:00
Burer deleted branch libimg-png-8-bit 2026-09-07 11:14:24 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Burer
Doczom
KolibriOS/system
Labels
Clear labels
Influence/Text/TYPO
AI
Eolite
FS
GSoC
This issue or PR in the Google Source of Code program
 Good First PR
The issue is suitable to beginners
 HLL
HardwareTested
IRCC
Influence/Settings
Lang/C
Lang/FASM
Pay for the code
Paid task
 Subsystem/API
Subsystem/Audio
infinity service, audio drivers, midi, speacker, audio programs
 Subsystem/Graphics
vesa, vga, framebuffer, cursors, blitter, and video drivers
 Subsystem/IPC and events
pipes, signals, events, shared memory
 Subsystem/Memory
virt and phys memory allocators, malloc and other
 Subsystem/Network
Subsystem/Services(daemon)
userspace and kernel(for example: serial) services
 Subsystem/Taskmanager
process, threads, run apps, scheduler
 Subsystem/VFS
drivers from filesystem, fs api, blkdev, programs that work with the file system
 Subsystem/Window
windows, skins, buttons, mouse and keyboard code for windows (not the base code)
Category
Applications
Category
Drivers
Category
General
Category
Kernel
Category
Libraries
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
PR
Ready to merge
Pull request is ready for merge
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
PR
Request changes
Changes requested in pull request
PR
Review required
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels Lang/FASM
Category
Libraries
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
ace-dent (Andrew) b00bl1k (Alexey Ryabov) bad_Dr3dd0x Burer Doczom (Mikhail Frolov) dunkaist (Ivan B) Egor00f (Егор Ярин) hidnplayr IgorA Leency (Kiril Lipatov) mxlgv (Max Logaev) ramenu rgimad sdongles (Serhii Sakhno) Sweetbread (Gleb Zaharov)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#599