KolibriOS/kolibrios
17
27
Fork 69
Code Issues 157 Pull Requests 49 Actions 1 Projects 2 Releases Wiki Activity

fat: fix stack imbalance on fatal hd_extend_file error #631

Open
Leency wants to merge 1 commits from fat-fix-stack-imbalance into main
pull from: fat-fix-stack-imbalance
merge into: :main
Conversation 1 Commits 1 Files Changed 1
+4 -1
Leency commented 2026-08-04 09:41:32 +00:00
Owner
Copy Link
Copy Source

The FAT/device error path in fat_Write jumped to the shared one-dword
epilogue with four dwords live, so ret returned into the error-code
slot and faulted in ring 0. Give the path its own named label.

The FAT/device error path in fat_Write jumped to the shared one-dword epilogue with four dwords live, so ret returned into the error-code slot and faulted in ring 0. Give the path its own named label.
Leency added 1 commit 2026-08-04 09:41:33 +00:00
fat: fix stack imbalance on fatal hd_extend_file error
Check kernel codestyle / Check kernel codestyle (pull_request) Successful in 20s
Details
Test PR / Build (en_US) (pull_request) Successful in 2m5s
Details
Test PR / Build (ru_RU) (pull_request) Successful in 2m7s
Details
Test PR / Build (es_ES) (pull_request) Successful in 2m10s
Details
c720726d50 
The FAT/device error path in fat_Write jumped to the shared one-dword
epilogue with four dwords live, so ret returned into the error-code
slot and faulted in ring 0. Give the path its own named label.
Leency requested review from Doczom 2026-08-04 09:41:50 +00:00
Leency requested review from dunkaist 2026-08-04 09:41:51 +00:00
Burer approved these changes 2026-09-07 17:28:43 +00:00
All checks were successful
Check kernel codestyle / Check kernel codestyle (pull_request) Successful in 20s
Details
Test PR / Build (en_US) (pull_request) Successful in 2m5s
Required
Details
Test PR / Build (ru_RU) (pull_request) Successful in 2m7s
Required
Details
Test PR / Build (es_ES) (pull_request) Successful in 2m10s
Required
Details
This pull request doesn't have enough required approvals yet. 1 of 2 official approvals granted.
This pull request is blocked because it's outdated.
You are not authorized to merge this pull request.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fat-fix-stack-imbalance:fat-fix-stack-imbalance
git checkout fat-fix-stack-imbalance
Sign in to join this conversation.
Reviewers
No Reviewers
Doczom
dunkaist
Burer
Labels
Clear labels
Influence/Text/TYPO
AI
Eolite
FS
GSoC
This issue or PR in the Google Source of Code program
 Good First PR
The issue is suitable to beginners
 HLL
HardwareTested
IRCC
Influence/Settings
Lang/C
Lang/FASM
Pay for the code
Paid task
 Subsystem/API
Subsystem/Audio
infinity service, audio drivers, midi, speacker, audio programs
 Subsystem/Graphics
vesa, vga, framebuffer, cursors, blitter, and video drivers
 Subsystem/IPC and events
pipes, signals, events, shared memory
 Subsystem/Memory
virt and phys memory allocators, malloc and other
 Subsystem/Network
Subsystem/Services(daemon)
userspace and kernel(for example: serial) services
 Subsystem/Taskmanager
process, threads, run apps, scheduler
 Subsystem/VFS
drivers from filesystem, fs api, blkdev, programs that work with the file system
 Subsystem/Window
windows, skins, buttons, mouse and keyboard code for windows (not the base code)
Category
Applications
Category
Drivers
Category
General
Category
Kernel
Category
Libraries
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
PR
Ready to merge
Pull request is ready for merge
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
PR
Request changes
Changes requested in pull request
PR
Review required
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
ace-dent (Andrew) b00bl1k (Alexey Ryabov) bad_Dr3dd0x Burer Doczom (Mikhail Frolov) dunkaist (Ivan B) Egor00f (Егор Ярин) hidnplayr IgorA Leency (Kiril Lipatov) mxlgv (Max Logaev) ramenu rgimad sdongles (Serhii Sakhno) Sweetbread (Gleb Zaharov)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#631