KolibriOS/kolibrios
17
27
Fork 69
Code Issues 157 Pull Requests 49 Actions 1 Projects 2 Releases Wiki Activity

libc.obj: fix opendir #645

Merged
Egor00f merged 5 commits from Egor00f/kolibrios:update-opendir into main 2026-08-17 15:42:55 +00:00
Conversation 2 Commits 5 Files Changed 2
+44 -22
Egor00f commented 2026-08-12 20:51:37 +00:00
Owner
Copy Link
Copy Source

Changes:

  • ignore EOF error
  • fix buf size
    520 and 264 were mixed up
  • Separate checks for malloc and _ksys_read_dir
  • fix some potential errors:
    • size of list->objs[i].d_name
  • handle the case if list->objs is not allocated
  • update dir_example.c
    • it may have page fail if run it from shell, because it try call con_set_flags
    • fix mkdir test
    • show opendir error
# Changes: - [x] ignore `EOF` error - [x] fix buf size `520` and `264` were mixed up - [x] Separate checks for `malloc` and `_ksys_read_dir` - [x] fix some potential errors: + size of `list->objs[i].d_name` + handle the case if `list->objs` is not allocated - [x] update `dir_example.c` + it may have page fail if run it from `shell`, because it try call `con_set_flags` + fix `mkdir` test + show `opendir` error
Egor00f added the
Priority
Medium
3
Category
Libraries
Lang/C
Kind
Bug
 labels 2026-08-12 20:51:37 +00:00
Egor00f requested review from Developers 2026-08-12 20:51:38 +00:00
Egor00f requested review from Owners 2026-08-12 20:51:39 +00:00
Egor00f scheduled this pull request to auto merge when all checks succeed 2026-08-13 06:42:34 +00:00
Egor00f added 5 commits 2026-08-15 21:03:07 +00:00
Set errno based on _ksys_read_dir status instead of hardcoded ENOTDIR da0c888831
Separate checks for malloc and _ksys_read_dir 59dc8b1180
ignore EOF error 63f2084459
add check that memory for objects allocated 0cd9c37250
fix incorrect buf len && update dir_example.c
Test PR / Build (es_ES) (pull_request) Successful in 2m9s
Details
Test PR / Build (en_US) (pull_request) Successful in 2m14s
Details
Test PR / Build (ru_RU) (pull_request) Successful in 2m17s
Details
d7b3666592
Egor00f force-pushed update-opendir from 88d6119830 to d7b3666592 2026-08-15 21:03:07 +00:00 Compare
Leency approved these changes 2026-08-17 15:38:42 +00:00
dunkaist approved these changes 2026-08-17 15:42:52 +00:00
Egor00f merged commit e470ef5db5 into main 2026-08-17 15:42:55 +00:00
Egor00f deleted branch update-opendir 2026-08-17 15:42:56 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Leency
dunkaist
KolibriOS/Developers
Labels
Clear labels
Influence/Text/TYPO
AI
Eolite
FS
GSoC
This issue or PR in the Google Source of Code program
 Good First PR
The issue is suitable to beginners
 HLL
HardwareTested
IRCC
Influence/Settings
Lang/C
Lang/FASM
Pay for the code
Paid task
 Subsystem/API
Subsystem/Audio
infinity service, audio drivers, midi, speacker, audio programs
 Subsystem/Graphics
vesa, vga, framebuffer, cursors, blitter, and video drivers
 Subsystem/IPC and events
pipes, signals, events, shared memory
 Subsystem/Memory
virt and phys memory allocators, malloc and other
 Subsystem/Network
Subsystem/Services(daemon)
userspace and kernel(for example: serial) services
 Subsystem/Taskmanager
process, threads, run apps, scheduler
 Subsystem/VFS
drivers from filesystem, fs api, blkdev, programs that work with the file system
 Subsystem/Window
windows, skins, buttons, mouse and keyboard code for windows (not the base code)
Category
Applications
Category
Drivers
Category
General
Category
Kernel
Category
Libraries
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
PR
Ready to merge
Pull request is ready for merge
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
PR
Request changes
Changes requested in pull request
PR
Review required
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels Lang/C
Category
Libraries
Kind
Bug
Priority
Medium
3
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
ace-dent (Andrew) b00bl1k (Alexey Ryabov) bad_Dr3dd0x Burer Doczom (Mikhail Frolov) dunkaist (Ivan B) Egor00f (Егор Ярин) hidnplayr IgorA Leency (Kiril Lipatov) mxlgv (Max Logaev) ramenu rgimad sdongles (Serhii Sakhno) Sweetbread (Gleb Zaharov)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#645