Mathieu Morcos Matou1306
  • Joined on 2026-02-21
Matou1306 commented on pull request KolibriOS/kolibrios#344 2026-03-08 16:36:11 +00:00
WIP: quotes-fix

@mxlgv Hello, Thanks for the review. I implemented your requested changes, please take a look and tell me what else I can improve.

Matou1306 pushed to quotes-fix at Matou1306/kolibrios 2026-03-08 16:15:54 +00:00
a259518124 requested changes (all)
Matou1306 commented on pull request KolibriOS/kolibrios#344 2026-03-07 12:41:15 +00:00
WIP: quotes-fix

Hey @mxlgv, I just pushed your requested changes. Please take a look and let me know if there is anything else.

The only thing remaining is the relative path change you requested. I am not…

Matou1306 pushed to quotes-fix at Matou1306/kolibrios 2026-03-07 12:22:04 +00:00
0b422c07ac use SSF_START_APP instead of hardcoded subfunction number 7
Matou1306 pushed to quotes-fix at Matou1306/kolibrios 2026-03-07 12:15:23 +00:00
2c20243949 requested changes
Matou1306 commented on pull request KolibriOS/kolibrios#344 2026-03-05 20:39:04 +00:00
WIP: quotes-fix

@mxlgv Sorry for the delay, I had university exams today.

Regarding your question: initially, no, I didn't try it via SHELL. I just double-clicked the file from Eolite and got DGen opening but…

Matou1306 commented on pull request KolibriOS/kolibrios#344 2026-03-03 19:36:42 +00:00
WIP: quotes-fix

@mxlgv I implemented your suggested FASM wrapper and pushed the latest version. Please take a look and tell me your thoughts

(Note: I tested it with a dummy file with spaces in the path. The…

Matou1306 pushed to quotes-fix at Matou1306/kolibrios 2026-03-03 18:25:09 +00:00
d8d4759097 added quotkinizer binary
Matou1306 commented on pull request KolibriOS/kolibrios#344 2026-03-02 18:23:41 +00:00
WIP: quotes-fix

@mxlgv Oh my bad!! I just realized I totally missed this comment from last week! I had the page open so it didn't send me a notification. I apologize for the confusion and going in circles for a…

Matou1306 commented on pull request KolibriOS/kolibrios#344 2026-02-28 19:58:49 +00:00
WIP: quotes-fix

@mxlgv Just to make sure we're on the same page, I realized the PR description was outdated (updating it right away).

I completely removed the global macro and the @open changes. The current…

Matou1306 commented on issue KolibriOS/kolibrios#336 2026-02-27 16:21:54 +00:00
The @open application passes paths without quotes

@mxlgv Thanks for the detailed explanation. From what I understand you are suggesting we should go back to tailoring a fix for dgen specifically right?

I had already thought of such a method so…

Matou1306 pushed to main at Matou1306/kolibrios 2026-02-27 16:13:27 +00:00
cc1034d849 fb2reader: add to oberon07 build system (#343)
06c1497624 system/docs: update docs and SF constants to match actual kernel (#306)
b52da3e1c3 koldbg: use shared KOSfuncs definitions
Compare 3 commits »
Matou1306 pushed to quotes-fix at Matou1306/kolibrios 2026-02-27 16:05:43 +00:00
e7d1a0b5db dgen local fix for the quotes issue
cc1034d849 fb2reader: add to oberon07 build system (#343)
06c1497624 system/docs: update docs and SF constants to match actual kernel (#306)
b52da3e1c3 koldbg: use shared KOSfuncs definitions
Compare 4 commits »
Matou1306 commented on issue KolibriOS/kolibrios#336 2026-02-24 15:43:55 +00:00
The @open application passes paths without quotes

@mxlgv I understand that your architectual decision has changed and that you think that the global fix is too risky right now

I have spent the last few days digging into the codebase to…

Matou1306 commented on issue KolibriOS/kolibrios#336 2026-02-24 13:13:35 +00:00
The @open application passes paths without quotes

@mxlgv I opened #344 with the implementation we discussed.

I believe this covers the standardization method @Doczom suggested (quoting in @open then handling it in native apps).

Since this…

Matou1306 pushed to quotes-fix at Matou1306/kolibrios 2026-02-24 12:06:12 +00:00
c8efe352dc Fix @open to quote paths for DGEN compatibility
Matou1306 created pull request KolibriOS/kolibrios#344 2026-02-24 11:34:58 +00:00
quotes-fix
Matou1306 pushed to quotes-fix at Matou1306/kolibrios 2026-02-24 10:58:29 +00:00
6dd27a94f6 @open issue with dgen fixed (programs/fs/unz/unz.asm)
Matou1306 pushed to quotes-fix at Matou1306/kolibrios 2026-02-24 10:58:26 +00:00
4bd3d5c46b @open issue with dgen fixed (programs/other/kpack/trunk/kpack.asm)
Matou1306 pushed to quotes-fix at Matou1306/kolibrios 2026-02-24 10:58:21 +00:00
e7d9d0985d @open issue with dgen fixed (programs/system/run/trunk/run.asm)