Why this function isn't needed anymore?
I have checked the CI build, it has both the git-hash and release offset in it. The kernel ABI is printed to the log too. Looks good to me.
I see two issues here
- Your patch changes the whole file now, which is not necessary.
- You converted the existing indent style to what you like with no reason. What if the next developer…
It is not specific to win32. Therefore it should go to tools/bin, I believe.
You removed this include directive, but the file 'lang.inc' is still generated in Tupfile.lua. Please, change the two last lines in Tupfile.lua with the following one:
This file uses spaces for indentation. You added tabs. Mixing tabs and spaces in one file is bad. Please, keep the indentation style used in the file, i.e. spaces. Thank you.
To use the environment variables mentioned in this PR we need to export them. E.g. by calling such a script just before calling tup:
$ cat /path/to/kos32-export-env_vars
#!/bin/bash
REPO=…
I updated these two fasm binaries on the server:
/home/autobuild/tools/bin/fasm
/home/autobuild/tools/win32/bin/fasm
$ whoami
autobuild
$ fasm
flat assembler version 1.73.32
usage:…
If commit messages are descriptive, follow a consistent format, and include meaningful context, the generated changelog can be more useful.
I wish we could eventually motivate people to write…
I might be wrong but this looks like whishful thinking to me.
Automatically generating CHANGELOGs.
All the automatically generated changelogs I have seen are unreadable because you have to…