Added a compile-time assert to verify that incompat_feature_report_table contains exactly 32 dwords. Since this check is not related to initialized data, it is placed outside the iglobal/endg…
Updated the formatting to follow the kernel style guidelines. Also adjusted the data definitions to match the style used elsewhere in this file for better consistency.
Please let me know if…
- Replaced usage of callee-saved register 'esi' with caller-saved register 'eax' in DEBUGF to avoid unnecessary register preservation.
- Replaced 'jecxz' with 'test ecx, ecx' + 'jz .done', since…
Looks like the DEBUGF macro expands into quite a bit of code, pushing the distance to .done beyond the +-128 byte range supported by jecxz.
I'll switch this to test ecx, ecx + jz .done…
Thanks for all the guidance throughout this task — I really enjoyed working on it and learned a lot about the codebase and style. Looking forward to contributing more.
Thanks for the feedback!
Refactored the implementation to follow the suggested approach:
- used iglobal for data definitions
- used movi for small immediates to reduce code size
- removed…
Thanks for the suggestions! I updated the implementation accordingly.
- expanded incompat_feature_report_table to 32 entries
- replaced zero entries with "unknown"
- implemented the SHR-based…
Thanks for the feedback!
I updated the patch to:
- remove magic numbers
- iterate over unsupported feature bits using a loop based on the pseudocode you suggested
- use DEBUGF 1 to report…