2013-02-23 10:47:31 +01:00
|
|
|
/*
|
|
|
|
* Copyright © 2008,2010 Intel Corporation
|
|
|
|
*
|
|
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
|
|
* to deal in the Software without restriction, including without limitation
|
|
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
|
|
*
|
|
|
|
* The above copyright notice and this permission notice (including the next
|
|
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
|
|
* Software.
|
|
|
|
*
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
|
|
* IN THE SOFTWARE.
|
|
|
|
*
|
|
|
|
* Authors:
|
|
|
|
* Eric Anholt <eric@anholt.net>
|
|
|
|
* Chris Wilson <chris@chris-wilson.co.uk>
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <drm/drmP.h>
|
|
|
|
#include <drm/i915_drm.h>
|
|
|
|
#include "i915_drv.h"
|
|
|
|
#include "i915_trace.h"
|
|
|
|
#include "intel_drv.h"
|
|
|
|
//#include <linux/dma_remapping.h>
|
|
|
|
|
|
|
|
|
|
|
|
static unsigned long
|
|
|
|
copy_to_user(void __user *to, const void *from, unsigned long n)
|
|
|
|
{
|
|
|
|
memcpy(to, from, n);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static unsigned long
|
|
|
|
copy_from_user(void *to, const void __user *from, unsigned long n)
|
|
|
|
{
|
|
|
|
memcpy(to, from, n);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
struct eb_objects {
|
2013-04-24 22:04:21 +02:00
|
|
|
struct list_head objects;
|
2013-02-23 10:47:31 +01:00
|
|
|
int and;
|
2013-04-24 22:04:21 +02:00
|
|
|
union {
|
|
|
|
struct drm_i915_gem_object *lut[0];
|
2013-02-23 10:47:31 +01:00
|
|
|
struct hlist_head buckets[0];
|
2013-04-24 22:04:21 +02:00
|
|
|
};
|
2013-02-23 10:47:31 +01:00
|
|
|
};
|
|
|
|
|
|
|
|
static struct eb_objects *
|
2013-04-24 22:04:21 +02:00
|
|
|
eb_create(struct drm_i915_gem_execbuffer2 *args)
|
2013-02-23 10:47:31 +01:00
|
|
|
{
|
2013-04-24 22:04:21 +02:00
|
|
|
struct eb_objects *eb = NULL;
|
|
|
|
|
|
|
|
if (args->flags & I915_EXEC_HANDLE_LUT) {
|
|
|
|
int size = args->buffer_count;
|
|
|
|
size *= sizeof(struct drm_i915_gem_object *);
|
|
|
|
size += sizeof(struct eb_objects);
|
|
|
|
eb = kmalloc(size, GFP_TEMPORARY | __GFP_NOWARN | __GFP_NORETRY);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (eb == NULL) {
|
|
|
|
int size = args->buffer_count;
|
2013-02-23 10:47:31 +01:00
|
|
|
int count = PAGE_SIZE / sizeof(struct hlist_head) / 2;
|
2013-04-24 22:04:21 +02:00
|
|
|
BUILD_BUG_ON_NOT_POWER_OF_2(PAGE_SIZE / sizeof(struct hlist_head));
|
|
|
|
while (count > 2*size)
|
2013-02-23 10:47:31 +01:00
|
|
|
count >>= 1;
|
|
|
|
eb = kzalloc(count*sizeof(struct hlist_head) +
|
|
|
|
sizeof(struct eb_objects),
|
2013-04-24 22:04:21 +02:00
|
|
|
GFP_TEMPORARY);
|
2013-02-23 10:47:31 +01:00
|
|
|
if (eb == NULL)
|
|
|
|
return eb;
|
|
|
|
|
|
|
|
eb->and = count - 1;
|
2013-04-24 22:04:21 +02:00
|
|
|
} else
|
|
|
|
eb->and = -args->buffer_count;
|
|
|
|
|
|
|
|
INIT_LIST_HEAD(&eb->objects);
|
2013-02-23 10:47:31 +01:00
|
|
|
return eb;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
eb_reset(struct eb_objects *eb)
|
|
|
|
{
|
2013-04-24 22:04:21 +02:00
|
|
|
if (eb->and >= 0)
|
2013-02-23 10:47:31 +01:00
|
|
|
memset(eb->buckets, 0, (eb->and+1)*sizeof(struct hlist_head));
|
|
|
|
}
|
|
|
|
|
2013-04-24 22:04:21 +02:00
|
|
|
static int
|
|
|
|
eb_lookup_objects(struct eb_objects *eb,
|
|
|
|
struct drm_i915_gem_exec_object2 *exec,
|
|
|
|
const struct drm_i915_gem_execbuffer2 *args,
|
|
|
|
struct drm_file *file)
|
2013-02-23 10:47:31 +01:00
|
|
|
{
|
2013-04-24 22:04:21 +02:00
|
|
|
int i;
|
|
|
|
|
|
|
|
spin_lock(&file->table_lock);
|
|
|
|
for (i = 0; i < args->buffer_count; i++) {
|
|
|
|
struct drm_i915_gem_object *obj;
|
|
|
|
|
|
|
|
obj = to_intel_bo(idr_find(&file->object_idr, exec[i].handle));
|
|
|
|
if (obj == NULL) {
|
|
|
|
spin_unlock(&file->table_lock);
|
|
|
|
DRM_DEBUG("Invalid object handle %d at index %d\n",
|
|
|
|
exec[i].handle, i);
|
|
|
|
return -ENOENT;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!list_empty(&obj->exec_list)) {
|
|
|
|
spin_unlock(&file->table_lock);
|
|
|
|
DRM_DEBUG("Object %p [handle %d, index %d] appears more than once in object list\n",
|
|
|
|
obj, exec[i].handle, i);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
drm_gem_object_reference(&obj->base);
|
|
|
|
list_add_tail(&obj->exec_list, &eb->objects);
|
|
|
|
|
|
|
|
obj->exec_entry = &exec[i];
|
|
|
|
if (eb->and < 0) {
|
|
|
|
eb->lut[i] = obj;
|
|
|
|
} else {
|
|
|
|
uint32_t handle = args->flags & I915_EXEC_HANDLE_LUT ? i : exec[i].handle;
|
|
|
|
obj->exec_handle = handle;
|
2013-02-23 10:47:31 +01:00
|
|
|
hlist_add_head(&obj->exec_node,
|
2013-04-24 22:04:21 +02:00
|
|
|
&eb->buckets[handle & eb->and]);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
spin_unlock(&file->table_lock);
|
|
|
|
|
|
|
|
return 0;
|
2013-02-23 10:47:31 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
static struct drm_i915_gem_object *
|
|
|
|
eb_get_object(struct eb_objects *eb, unsigned long handle)
|
|
|
|
{
|
2013-04-24 22:04:21 +02:00
|
|
|
if (eb->and < 0) {
|
|
|
|
if (handle >= -eb->and)
|
|
|
|
return NULL;
|
|
|
|
return eb->lut[handle];
|
|
|
|
} else {
|
2013-02-23 10:47:31 +01:00
|
|
|
struct hlist_head *head;
|
|
|
|
struct hlist_node *node;
|
|
|
|
|
|
|
|
head = &eb->buckets[handle & eb->and];
|
|
|
|
hlist_for_each(node, head) {
|
2013-04-24 22:04:21 +02:00
|
|
|
struct drm_i915_gem_object *obj;
|
|
|
|
|
2013-02-23 10:47:31 +01:00
|
|
|
obj = hlist_entry(node, struct drm_i915_gem_object, exec_node);
|
|
|
|
if (obj->exec_handle == handle)
|
|
|
|
return obj;
|
|
|
|
}
|
|
|
|
return NULL;
|
2013-04-24 22:04:21 +02:00
|
|
|
}
|
2013-02-23 10:47:31 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
eb_destroy(struct eb_objects *eb)
|
|
|
|
{
|
2013-04-24 22:04:21 +02:00
|
|
|
while (!list_empty(&eb->objects)) {
|
|
|
|
struct drm_i915_gem_object *obj;
|
|
|
|
|
|
|
|
obj = list_first_entry(&eb->objects,
|
|
|
|
struct drm_i915_gem_object,
|
|
|
|
exec_list);
|
|
|
|
list_del_init(&obj->exec_list);
|
|
|
|
drm_gem_object_unreference(&obj->base);
|
|
|
|
}
|
2013-02-23 10:47:31 +01:00
|
|
|
kfree(eb);
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline int use_cpu_reloc(struct drm_i915_gem_object *obj)
|
|
|
|
{
|
|
|
|
return (obj->base.write_domain == I915_GEM_DOMAIN_CPU ||
|
|
|
|
!obj->map_and_fenceable ||
|
|
|
|
obj->cache_level != I915_CACHE_NONE);
|
|
|
|
}
|
|
|
|
|
2013-12-17 07:12:18 +01:00
|
|
|
static int
|
|
|
|
relocate_entry_cpu(struct drm_i915_gem_object *obj,
|
|
|
|
struct drm_i915_gem_relocation_entry *reloc)
|
|
|
|
{
|
|
|
|
uint32_t page_offset = offset_in_page(reloc->offset);
|
|
|
|
char *vaddr;
|
|
|
|
int ret = -EINVAL;
|
|
|
|
|
|
|
|
ret = i915_gem_object_set_to_cpu_domain(obj, 1);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
vaddr = (char *)MapIoMem((addr_t)i915_gem_object_get_page(obj,
|
|
|
|
reloc->offset >> PAGE_SHIFT), 4096, 3);
|
|
|
|
*(uint32_t *)(vaddr + page_offset) = reloc->delta;
|
|
|
|
FreeKernelSpace(vaddr);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
relocate_entry_gtt(struct drm_i915_gem_object *obj,
|
|
|
|
struct drm_i915_gem_relocation_entry *reloc)
|
|
|
|
{
|
|
|
|
struct drm_device *dev = obj->base.dev;
|
|
|
|
struct drm_i915_private *dev_priv = dev->dev_private;
|
|
|
|
uint32_t __iomem *reloc_entry;
|
|
|
|
void __iomem *reloc_page;
|
|
|
|
int ret = -EINVAL;
|
|
|
|
|
|
|
|
ret = i915_gem_object_set_to_gtt_domain(obj, true);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
ret = i915_gem_object_put_fence(obj);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
/* Map the page containing the relocation we're going to perform. */
|
|
|
|
reloc->offset += i915_gem_obj_ggtt_offset(obj);
|
|
|
|
reloc_page = (void*)MapIoMem(dev_priv->gtt.mappable_base +
|
|
|
|
(reloc->offset & PAGE_MASK), 4096, 0x18|3);
|
|
|
|
reloc_entry = (uint32_t __iomem *)
|
|
|
|
(reloc_page + offset_in_page(reloc->offset));
|
|
|
|
iowrite32(reloc->delta, reloc_entry);
|
|
|
|
FreeKernelSpace(reloc_page);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2013-02-23 10:47:31 +01:00
|
|
|
static int
|
|
|
|
i915_gem_execbuffer_relocate_entry(struct drm_i915_gem_object *obj,
|
|
|
|
struct eb_objects *eb,
|
2013-10-26 15:34:57 +02:00
|
|
|
struct drm_i915_gem_relocation_entry *reloc,
|
|
|
|
struct i915_address_space *vm)
|
2013-02-23 10:47:31 +01:00
|
|
|
{
|
|
|
|
struct drm_device *dev = obj->base.dev;
|
|
|
|
struct drm_gem_object *target_obj;
|
|
|
|
struct drm_i915_gem_object *target_i915_obj;
|
|
|
|
uint32_t target_offset;
|
|
|
|
int ret = -EINVAL;
|
|
|
|
|
|
|
|
/* we've already hold a reference to all valid objects */
|
|
|
|
target_obj = &eb_get_object(eb, reloc->target_handle)->base;
|
|
|
|
if (unlikely(target_obj == NULL))
|
|
|
|
return -ENOENT;
|
|
|
|
|
|
|
|
target_i915_obj = to_intel_bo(target_obj);
|
2013-10-26 15:34:57 +02:00
|
|
|
target_offset = i915_gem_obj_ggtt_offset(target_i915_obj);
|
2013-02-23 10:47:31 +01:00
|
|
|
|
|
|
|
/* Sandybridge PPGTT errata: We need a global gtt mapping for MI and
|
|
|
|
* pipe_control writes because the gpu doesn't properly redirect them
|
|
|
|
* through the ppgtt for non_secure batchbuffers. */
|
|
|
|
if (unlikely(IS_GEN6(dev) &&
|
|
|
|
reloc->write_domain == I915_GEM_DOMAIN_INSTRUCTION &&
|
|
|
|
!target_i915_obj->has_global_gtt_mapping)) {
|
|
|
|
i915_gem_gtt_bind_object(target_i915_obj,
|
|
|
|
target_i915_obj->cache_level);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Validate that the target is in a valid r/w GPU domain */
|
|
|
|
if (unlikely(reloc->write_domain & (reloc->write_domain - 1))) {
|
|
|
|
DRM_DEBUG("reloc with multiple write domains: "
|
|
|
|
"obj %p target %d offset %d "
|
|
|
|
"read %08x write %08x",
|
|
|
|
obj, reloc->target_handle,
|
|
|
|
(int) reloc->offset,
|
|
|
|
reloc->read_domains,
|
|
|
|
reloc->write_domain);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
if (unlikely((reloc->write_domain | reloc->read_domains)
|
|
|
|
& ~I915_GEM_GPU_DOMAINS)) {
|
|
|
|
DRM_DEBUG("reloc with read/write non-GPU domains: "
|
|
|
|
"obj %p target %d offset %d "
|
|
|
|
"read %08x write %08x",
|
|
|
|
obj, reloc->target_handle,
|
|
|
|
(int) reloc->offset,
|
|
|
|
reloc->read_domains,
|
|
|
|
reloc->write_domain);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
target_obj->pending_read_domains |= reloc->read_domains;
|
|
|
|
target_obj->pending_write_domain |= reloc->write_domain;
|
|
|
|
|
|
|
|
/* If the relocation already has the right value in it, no
|
|
|
|
* more work needs to be done.
|
|
|
|
*/
|
|
|
|
if (target_offset == reloc->presumed_offset)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
/* Check that the relocation address is valid... */
|
|
|
|
if (unlikely(reloc->offset > obj->base.size - 4)) {
|
|
|
|
DRM_DEBUG("Relocation beyond object bounds: "
|
|
|
|
"obj %p target %d offset %d size %d.\n",
|
|
|
|
obj, reloc->target_handle,
|
|
|
|
(int) reloc->offset,
|
|
|
|
(int) obj->base.size);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
if (unlikely(reloc->offset & 3)) {
|
|
|
|
DRM_DEBUG("Relocation not 4-byte aligned: "
|
|
|
|
"obj %p target %d offset %d.\n",
|
|
|
|
obj, reloc->target_handle,
|
|
|
|
(int) reloc->offset);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* We can't wait for rendering with pagefaults disabled */
|
2013-02-27 06:05:57 +01:00
|
|
|
|
2013-02-23 10:47:31 +01:00
|
|
|
reloc->delta += target_offset;
|
2013-12-17 07:12:18 +01:00
|
|
|
if (use_cpu_reloc(obj))
|
|
|
|
ret = relocate_entry_cpu(obj, reloc);
|
|
|
|
else
|
|
|
|
ret = relocate_entry_gtt(obj, reloc);
|
2013-02-23 10:47:31 +01:00
|
|
|
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
/* and update the user's relocation entry */
|
|
|
|
reloc->presumed_offset = target_offset;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
i915_gem_execbuffer_relocate_object(struct drm_i915_gem_object *obj,
|
2013-10-26 15:34:57 +02:00
|
|
|
struct eb_objects *eb,
|
|
|
|
struct i915_address_space *vm)
|
2013-02-23 10:47:31 +01:00
|
|
|
{
|
|
|
|
#define N_RELOC(x) ((x) / sizeof(struct drm_i915_gem_relocation_entry))
|
2013-02-24 07:22:22 +01:00
|
|
|
struct drm_i915_gem_relocation_entry stack_reloc[N_RELOC(64)];
|
2013-02-23 10:47:31 +01:00
|
|
|
struct drm_i915_gem_relocation_entry __user *user_relocs;
|
|
|
|
struct drm_i915_gem_exec_object2 *entry = obj->exec_entry;
|
|
|
|
int remain, ret;
|
|
|
|
|
|
|
|
user_relocs = (void __user *)(uintptr_t)entry->relocs_ptr;
|
|
|
|
|
|
|
|
remain = entry->relocation_count;
|
|
|
|
while (remain) {
|
|
|
|
struct drm_i915_gem_relocation_entry *r = stack_reloc;
|
|
|
|
int count = remain;
|
|
|
|
if (count > ARRAY_SIZE(stack_reloc))
|
|
|
|
count = ARRAY_SIZE(stack_reloc);
|
|
|
|
remain -= count;
|
|
|
|
|
|
|
|
memcpy(r, user_relocs, count*sizeof(r[0]));
|
|
|
|
|
|
|
|
do {
|
|
|
|
u64 offset = r->presumed_offset;
|
|
|
|
|
2013-10-26 15:34:57 +02:00
|
|
|
ret = i915_gem_execbuffer_relocate_entry(obj, eb, r,
|
|
|
|
vm);
|
2013-02-23 10:47:31 +01:00
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
2013-12-21 10:57:20 +01:00
|
|
|
if (r->presumed_offset != offset)
|
|
|
|
{
|
2013-02-23 10:47:31 +01:00
|
|
|
memcpy(&user_relocs->presumed_offset,
|
|
|
|
&r->presumed_offset,
|
|
|
|
sizeof(r->presumed_offset));
|
2013-12-21 10:57:20 +01:00
|
|
|
}
|
2013-02-23 10:47:31 +01:00
|
|
|
|
|
|
|
user_relocs++;
|
|
|
|
r++;
|
|
|
|
} while (--count);
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
#undef N_RELOC
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
i915_gem_execbuffer_relocate_object_slow(struct drm_i915_gem_object *obj,
|
|
|
|
struct eb_objects *eb,
|
2013-10-26 15:34:57 +02:00
|
|
|
struct drm_i915_gem_relocation_entry *relocs,
|
|
|
|
struct i915_address_space *vm)
|
2013-02-23 10:47:31 +01:00
|
|
|
{
|
|
|
|
const struct drm_i915_gem_exec_object2 *entry = obj->exec_entry;
|
|
|
|
int i, ret;
|
|
|
|
|
|
|
|
for (i = 0; i < entry->relocation_count; i++) {
|
2013-10-26 15:34:57 +02:00
|
|
|
ret = i915_gem_execbuffer_relocate_entry(obj, eb, &relocs[i],
|
|
|
|
vm);
|
2013-02-23 10:47:31 +01:00
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
2013-10-26 15:34:57 +02:00
|
|
|
i915_gem_execbuffer_relocate(struct eb_objects *eb,
|
|
|
|
struct i915_address_space *vm)
|
2013-02-23 10:47:31 +01:00
|
|
|
{
|
|
|
|
struct drm_i915_gem_object *obj;
|
|
|
|
int ret = 0;
|
|
|
|
|
|
|
|
/* This is the fast path and we cannot handle a pagefault whilst
|
|
|
|
* holding the struct mutex lest the user pass in the relocations
|
|
|
|
* contained within a mmaped bo. For in such a case we, the page
|
|
|
|
* fault handler would call i915_gem_fault() and we would try to
|
|
|
|
* acquire the struct mutex again. Obviously this is bad and so
|
|
|
|
* lockdep complains vehemently.
|
|
|
|
*/
|
2013-10-26 15:34:57 +02:00
|
|
|
// pagefault_disable();
|
2013-04-24 22:04:21 +02:00
|
|
|
list_for_each_entry(obj, &eb->objects, exec_list) {
|
2013-10-26 15:34:57 +02:00
|
|
|
ret = i915_gem_execbuffer_relocate_object(obj, eb, vm);
|
2013-02-23 10:47:31 +01:00
|
|
|
if (ret)
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
// pagefault_enable();
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
#define __EXEC_OBJECT_HAS_PIN (1<<31)
|
|
|
|
#define __EXEC_OBJECT_HAS_FENCE (1<<30)
|
|
|
|
|
|
|
|
static int
|
|
|
|
need_reloc_mappable(struct drm_i915_gem_object *obj)
|
|
|
|
{
|
|
|
|
struct drm_i915_gem_exec_object2 *entry = obj->exec_entry;
|
|
|
|
return entry->relocation_count && !use_cpu_reloc(obj);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
i915_gem_execbuffer_reserve_object(struct drm_i915_gem_object *obj,
|
2013-04-24 22:04:21 +02:00
|
|
|
struct intel_ring_buffer *ring,
|
2013-10-26 15:34:57 +02:00
|
|
|
struct i915_address_space *vm,
|
2013-04-24 22:04:21 +02:00
|
|
|
bool *need_reloc)
|
2013-02-23 10:47:31 +01:00
|
|
|
{
|
|
|
|
struct drm_i915_private *dev_priv = obj->base.dev->dev_private;
|
|
|
|
struct drm_i915_gem_exec_object2 *entry = obj->exec_entry;
|
|
|
|
bool has_fenced_gpu_access = INTEL_INFO(ring->dev)->gen < 4;
|
|
|
|
bool need_fence, need_mappable;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
need_fence =
|
|
|
|
has_fenced_gpu_access &&
|
|
|
|
entry->flags & EXEC_OBJECT_NEEDS_FENCE &&
|
|
|
|
obj->tiling_mode != I915_TILING_NONE;
|
|
|
|
need_mappable = need_fence || need_reloc_mappable(obj);
|
|
|
|
|
2013-10-26 15:34:57 +02:00
|
|
|
ret = i915_gem_object_pin(obj, vm, entry->alignment, need_mappable,
|
|
|
|
false);
|
2013-02-23 10:47:31 +01:00
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
entry->flags |= __EXEC_OBJECT_HAS_PIN;
|
|
|
|
|
|
|
|
if (has_fenced_gpu_access) {
|
|
|
|
if (entry->flags & EXEC_OBJECT_NEEDS_FENCE) {
|
|
|
|
ret = i915_gem_object_get_fence(obj);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
if (i915_gem_object_pin_fence(obj))
|
|
|
|
entry->flags |= __EXEC_OBJECT_HAS_FENCE;
|
|
|
|
|
|
|
|
obj->pending_fenced_gpu_access = true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Ensure ppgtt mapping exists if needed */
|
|
|
|
if (dev_priv->mm.aliasing_ppgtt && !obj->has_aliasing_ppgtt_mapping) {
|
|
|
|
i915_ppgtt_bind_object(dev_priv->mm.aliasing_ppgtt,
|
|
|
|
obj, obj->cache_level);
|
|
|
|
|
|
|
|
obj->has_aliasing_ppgtt_mapping = 1;
|
|
|
|
}
|
|
|
|
|
2013-10-26 15:34:57 +02:00
|
|
|
if (entry->offset != i915_gem_obj_offset(obj, vm)) {
|
|
|
|
entry->offset = i915_gem_obj_offset(obj, vm);
|
2013-04-24 22:04:21 +02:00
|
|
|
*need_reloc = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (entry->flags & EXEC_OBJECT_WRITE) {
|
|
|
|
obj->base.pending_read_domains = I915_GEM_DOMAIN_RENDER;
|
|
|
|
obj->base.pending_write_domain = I915_GEM_DOMAIN_RENDER;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (entry->flags & EXEC_OBJECT_NEEDS_GTT &&
|
|
|
|
!obj->has_global_gtt_mapping)
|
|
|
|
i915_gem_gtt_bind_object(obj, obj->cache_level);
|
2013-02-24 07:22:22 +01:00
|
|
|
|
2013-02-23 10:47:31 +01:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
i915_gem_execbuffer_unreserve_object(struct drm_i915_gem_object *obj)
|
|
|
|
{
|
|
|
|
struct drm_i915_gem_exec_object2 *entry;
|
|
|
|
|
2013-10-26 15:34:57 +02:00
|
|
|
if (!i915_gem_obj_bound_any(obj))
|
2013-02-23 10:47:31 +01:00
|
|
|
return;
|
|
|
|
|
|
|
|
entry = obj->exec_entry;
|
|
|
|
|
|
|
|
if (entry->flags & __EXEC_OBJECT_HAS_FENCE)
|
|
|
|
i915_gem_object_unpin_fence(obj);
|
|
|
|
|
|
|
|
if (entry->flags & __EXEC_OBJECT_HAS_PIN)
|
|
|
|
i915_gem_object_unpin(obj);
|
|
|
|
|
|
|
|
entry->flags &= ~(__EXEC_OBJECT_HAS_FENCE | __EXEC_OBJECT_HAS_PIN);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
i915_gem_execbuffer_reserve(struct intel_ring_buffer *ring,
|
2013-04-24 22:04:21 +02:00
|
|
|
struct list_head *objects,
|
2013-10-26 15:34:57 +02:00
|
|
|
struct i915_address_space *vm,
|
2013-04-24 22:04:21 +02:00
|
|
|
bool *need_relocs)
|
2013-02-23 10:47:31 +01:00
|
|
|
{
|
|
|
|
struct drm_i915_gem_object *obj;
|
|
|
|
struct list_head ordered_objects;
|
|
|
|
bool has_fenced_gpu_access = INTEL_INFO(ring->dev)->gen < 4;
|
|
|
|
int retry;
|
|
|
|
|
|
|
|
INIT_LIST_HEAD(&ordered_objects);
|
|
|
|
while (!list_empty(objects)) {
|
|
|
|
struct drm_i915_gem_exec_object2 *entry;
|
|
|
|
bool need_fence, need_mappable;
|
|
|
|
|
|
|
|
obj = list_first_entry(objects,
|
|
|
|
struct drm_i915_gem_object,
|
|
|
|
exec_list);
|
|
|
|
entry = obj->exec_entry;
|
|
|
|
|
|
|
|
need_fence =
|
|
|
|
has_fenced_gpu_access &&
|
|
|
|
entry->flags & EXEC_OBJECT_NEEDS_FENCE &&
|
|
|
|
obj->tiling_mode != I915_TILING_NONE;
|
|
|
|
need_mappable = need_fence || need_reloc_mappable(obj);
|
|
|
|
|
|
|
|
if (need_mappable)
|
|
|
|
list_move(&obj->exec_list, &ordered_objects);
|
|
|
|
else
|
|
|
|
list_move_tail(&obj->exec_list, &ordered_objects);
|
|
|
|
|
2013-04-24 22:04:21 +02:00
|
|
|
obj->base.pending_read_domains = I915_GEM_GPU_DOMAINS & ~I915_GEM_DOMAIN_COMMAND;
|
2013-02-23 10:47:31 +01:00
|
|
|
obj->base.pending_write_domain = 0;
|
|
|
|
obj->pending_fenced_gpu_access = false;
|
|
|
|
}
|
|
|
|
list_splice(&ordered_objects, objects);
|
|
|
|
|
|
|
|
/* Attempt to pin all of the buffers into the GTT.
|
|
|
|
* This is done in 3 phases:
|
|
|
|
*
|
|
|
|
* 1a. Unbind all objects that do not match the GTT constraints for
|
|
|
|
* the execbuffer (fenceable, mappable, alignment etc).
|
|
|
|
* 1b. Increment pin count for already bound objects.
|
|
|
|
* 2. Bind new objects.
|
|
|
|
* 3. Decrement pin count.
|
|
|
|
*
|
|
|
|
* This avoid unnecessary unbinding of later objects in order to make
|
|
|
|
* room for the earlier objects *unless* we need to defragment.
|
|
|
|
*/
|
|
|
|
retry = 0;
|
|
|
|
do {
|
|
|
|
int ret = 0;
|
|
|
|
|
|
|
|
/* Unbind any ill-fitting objects or pin. */
|
|
|
|
list_for_each_entry(obj, objects, exec_list) {
|
|
|
|
struct drm_i915_gem_exec_object2 *entry = obj->exec_entry;
|
|
|
|
bool need_fence, need_mappable;
|
2013-10-26 15:34:57 +02:00
|
|
|
u32 obj_offset;
|
2013-02-23 10:47:31 +01:00
|
|
|
|
2013-10-26 15:34:57 +02:00
|
|
|
if (!i915_gem_obj_bound(obj, vm))
|
2013-02-23 10:47:31 +01:00
|
|
|
continue;
|
|
|
|
|
2013-10-26 15:34:57 +02:00
|
|
|
obj_offset = i915_gem_obj_offset(obj, vm);
|
2013-02-23 10:47:31 +01:00
|
|
|
need_fence =
|
|
|
|
has_fenced_gpu_access &&
|
|
|
|
entry->flags & EXEC_OBJECT_NEEDS_FENCE &&
|
|
|
|
obj->tiling_mode != I915_TILING_NONE;
|
|
|
|
need_mappable = need_fence || need_reloc_mappable(obj);
|
|
|
|
|
2013-11-17 07:47:10 +01:00
|
|
|
WARN_ON((need_mappable || need_fence) &&
|
|
|
|
!i915_is_ggtt(vm));
|
2013-10-26 15:34:57 +02:00
|
|
|
|
|
|
|
if ((entry->alignment &&
|
|
|
|
obj_offset & (entry->alignment - 1)) ||
|
2013-02-23 10:47:31 +01:00
|
|
|
(need_mappable && !obj->map_and_fenceable))
|
2013-10-26 15:34:57 +02:00
|
|
|
ret = i915_vma_unbind(i915_gem_obj_to_vma(obj, vm));
|
2013-02-23 10:47:31 +01:00
|
|
|
else
|
2013-10-26 15:34:57 +02:00
|
|
|
ret = i915_gem_execbuffer_reserve_object(obj, ring, vm, need_relocs);
|
2013-02-23 10:47:31 +01:00
|
|
|
if (ret)
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Bind fresh objects */
|
|
|
|
list_for_each_entry(obj, objects, exec_list) {
|
2013-10-26 15:34:57 +02:00
|
|
|
if (i915_gem_obj_bound(obj, vm))
|
2013-02-23 10:47:31 +01:00
|
|
|
continue;
|
|
|
|
|
2013-10-26 15:34:57 +02:00
|
|
|
ret = i915_gem_execbuffer_reserve_object(obj, ring, vm, need_relocs);
|
2013-02-23 10:47:31 +01:00
|
|
|
if (ret)
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
|
|
|
|
err: /* Decrement pin count for bound objects */
|
|
|
|
list_for_each_entry(obj, objects, exec_list)
|
|
|
|
i915_gem_execbuffer_unreserve_object(obj);
|
|
|
|
|
|
|
|
if (ret != -ENOSPC || retry++)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
// ret = i915_gem_evict_everything(ring->dev);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
} while (1);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
i915_gem_execbuffer_relocate_slow(struct drm_device *dev,
|
2013-04-24 22:04:21 +02:00
|
|
|
struct drm_i915_gem_execbuffer2 *args,
|
2013-02-23 10:47:31 +01:00
|
|
|
struct drm_file *file,
|
|
|
|
struct intel_ring_buffer *ring,
|
|
|
|
struct eb_objects *eb,
|
2013-10-26 15:34:57 +02:00
|
|
|
struct drm_i915_gem_exec_object2 *exec,
|
|
|
|
struct i915_address_space *vm)
|
2013-02-23 10:47:31 +01:00
|
|
|
{
|
|
|
|
struct drm_i915_gem_relocation_entry *reloc;
|
|
|
|
struct drm_i915_gem_object *obj;
|
2013-04-24 22:04:21 +02:00
|
|
|
bool need_relocs;
|
2013-02-23 10:47:31 +01:00
|
|
|
int *reloc_offset;
|
|
|
|
int i, total, ret;
|
2013-04-24 22:04:21 +02:00
|
|
|
int count = args->buffer_count;
|
2013-02-23 10:47:31 +01:00
|
|
|
|
|
|
|
/* We may process another execbuffer during the unlock... */
|
2013-04-24 22:04:21 +02:00
|
|
|
while (!list_empty(&eb->objects)) {
|
|
|
|
obj = list_first_entry(&eb->objects,
|
2013-02-23 10:47:31 +01:00
|
|
|
struct drm_i915_gem_object,
|
|
|
|
exec_list);
|
|
|
|
list_del_init(&obj->exec_list);
|
|
|
|
drm_gem_object_unreference(&obj->base);
|
|
|
|
}
|
|
|
|
|
|
|
|
mutex_unlock(&dev->struct_mutex);
|
|
|
|
|
|
|
|
total = 0;
|
|
|
|
for (i = 0; i < count; i++)
|
|
|
|
total += exec[i].relocation_count;
|
|
|
|
|
|
|
|
reloc_offset = malloc(count * sizeof(*reloc_offset));
|
|
|
|
reloc = malloc(total * sizeof(*reloc));
|
|
|
|
if (reloc == NULL || reloc_offset == NULL) {
|
2013-02-24 07:22:22 +01:00
|
|
|
kfree(reloc);
|
|
|
|
kfree(reloc_offset);
|
2013-02-23 10:47:31 +01:00
|
|
|
mutex_lock(&dev->struct_mutex);
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
|
|
|
|
total = 0;
|
|
|
|
for (i = 0; i < count; i++) {
|
|
|
|
struct drm_i915_gem_relocation_entry __user *user_relocs;
|
|
|
|
u64 invalid_offset = (u64)-1;
|
|
|
|
int j;
|
|
|
|
|
|
|
|
user_relocs = (void __user *)(uintptr_t)exec[i].relocs_ptr;
|
|
|
|
|
|
|
|
if (copy_from_user(reloc+total, user_relocs,
|
|
|
|
exec[i].relocation_count * sizeof(*reloc))) {
|
|
|
|
ret = -EFAULT;
|
|
|
|
mutex_lock(&dev->struct_mutex);
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* As we do not update the known relocation offsets after
|
|
|
|
* relocating (due to the complexities in lock handling),
|
|
|
|
* we need to mark them as invalid now so that we force the
|
|
|
|
* relocation processing next time. Just in case the target
|
|
|
|
* object is evicted and then rebound into its old
|
|
|
|
* presumed_offset before the next execbuffer - if that
|
|
|
|
* happened we would make the mistake of assuming that the
|
|
|
|
* relocations were valid.
|
|
|
|
*/
|
|
|
|
for (j = 0; j < exec[i].relocation_count; j++) {
|
|
|
|
if (copy_to_user(&user_relocs[j].presumed_offset,
|
|
|
|
&invalid_offset,
|
|
|
|
sizeof(invalid_offset))) {
|
|
|
|
ret = -EFAULT;
|
|
|
|
mutex_lock(&dev->struct_mutex);
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
reloc_offset[i] = total;
|
|
|
|
total += exec[i].relocation_count;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = i915_mutex_lock_interruptible(dev);
|
|
|
|
if (ret) {
|
|
|
|
mutex_lock(&dev->struct_mutex);
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* reacquire the objects */
|
|
|
|
eb_reset(eb);
|
2013-04-24 22:04:21 +02:00
|
|
|
ret = eb_lookup_objects(eb, exec, args, file);
|
|
|
|
if (ret)
|
2013-02-23 10:47:31 +01:00
|
|
|
goto err;
|
|
|
|
|
2013-04-24 22:04:21 +02:00
|
|
|
need_relocs = (args->flags & I915_EXEC_NO_RELOC) == 0;
|
2013-10-26 15:34:57 +02:00
|
|
|
ret = i915_gem_execbuffer_reserve(ring, &eb->objects, vm, &need_relocs);
|
2013-02-23 10:47:31 +01:00
|
|
|
if (ret)
|
|
|
|
goto err;
|
|
|
|
|
2013-04-24 22:04:21 +02:00
|
|
|
list_for_each_entry(obj, &eb->objects, exec_list) {
|
2013-02-23 10:47:31 +01:00
|
|
|
int offset = obj->exec_entry - exec;
|
|
|
|
ret = i915_gem_execbuffer_relocate_object_slow(obj, eb,
|
2013-10-26 15:34:57 +02:00
|
|
|
reloc + reloc_offset[offset],
|
|
|
|
vm);
|
2013-02-23 10:47:31 +01:00
|
|
|
if (ret)
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Leave the user relocations as are, this is the painfully slow path,
|
|
|
|
* and we want to avoid the complication of dropping the lock whilst
|
|
|
|
* having buffers reserved in the aperture and so causing spurious
|
|
|
|
* ENOSPC for random operations.
|
|
|
|
*/
|
|
|
|
|
|
|
|
err:
|
2013-02-24 07:22:22 +01:00
|
|
|
kfree(reloc);
|
|
|
|
kfree(reloc_offset);
|
2013-02-23 10:47:31 +01:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
i915_gem_execbuffer_move_to_gpu(struct intel_ring_buffer *ring,
|
|
|
|
struct list_head *objects)
|
|
|
|
{
|
|
|
|
struct drm_i915_gem_object *obj;
|
|
|
|
uint32_t flush_domains = 0;
|
2013-10-26 15:34:57 +02:00
|
|
|
bool flush_chipset = false;
|
2013-02-23 10:47:31 +01:00
|
|
|
int ret;
|
|
|
|
|
|
|
|
list_for_each_entry(obj, objects, exec_list) {
|
|
|
|
ret = i915_gem_object_sync(obj, ring);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
if (obj->base.write_domain & I915_GEM_DOMAIN_CPU)
|
2013-10-26 15:34:57 +02:00
|
|
|
flush_chipset |= i915_gem_clflush_object(obj, false);
|
2013-02-23 10:47:31 +01:00
|
|
|
|
|
|
|
flush_domains |= obj->base.write_domain;
|
|
|
|
}
|
|
|
|
|
2013-10-26 15:34:57 +02:00
|
|
|
if (flush_chipset)
|
2013-02-23 10:47:31 +01:00
|
|
|
i915_gem_chipset_flush(ring->dev);
|
|
|
|
|
|
|
|
if (flush_domains & I915_GEM_DOMAIN_GTT)
|
|
|
|
wmb();
|
|
|
|
|
|
|
|
/* Unconditionally invalidate gpu caches and ensure that we do flush
|
|
|
|
* any residual writes from the previous batch.
|
|
|
|
*/
|
|
|
|
return intel_ring_invalidate_all_caches(ring);
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool
|
|
|
|
i915_gem_check_execbuffer(struct drm_i915_gem_execbuffer2 *exec)
|
|
|
|
{
|
2013-04-24 22:04:21 +02:00
|
|
|
if (exec->flags & __I915_EXEC_UNKNOWN_FLAGS)
|
|
|
|
return false;
|
|
|
|
|
2013-02-23 10:47:31 +01:00
|
|
|
return ((exec->batch_start_offset | exec->batch_len) & 0x7) == 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
validate_exec_list(struct drm_i915_gem_exec_object2 *exec,
|
|
|
|
int count)
|
|
|
|
{
|
|
|
|
int i;
|
2013-04-24 22:04:21 +02:00
|
|
|
int relocs_total = 0;
|
|
|
|
int relocs_max = INT_MAX / sizeof(struct drm_i915_gem_relocation_entry);
|
2013-02-23 10:47:31 +01:00
|
|
|
|
|
|
|
for (i = 0; i < count; i++) {
|
2013-07-02 18:03:52 +02:00
|
|
|
char __user *ptr = to_user_ptr(exec[i].relocs_ptr);
|
2013-02-23 10:47:31 +01:00
|
|
|
int length; /* limited by fault_in_pages_readable() */
|
|
|
|
|
2013-04-24 22:04:21 +02:00
|
|
|
if (exec[i].flags & __EXEC_OBJECT_UNKNOWN_FLAGS)
|
2013-02-23 10:47:31 +01:00
|
|
|
return -EINVAL;
|
|
|
|
|
2013-04-24 22:04:21 +02:00
|
|
|
/* First check for malicious input causing overflow in
|
|
|
|
* the worst case where we need to allocate the entire
|
|
|
|
* relocation tree as a single array.
|
|
|
|
*/
|
|
|
|
if (exec[i].relocation_count > relocs_max - relocs_total)
|
|
|
|
return -EINVAL;
|
|
|
|
relocs_total += exec[i].relocation_count;
|
|
|
|
|
2013-02-23 10:47:31 +01:00
|
|
|
length = exec[i].relocation_count *
|
|
|
|
sizeof(struct drm_i915_gem_relocation_entry);
|
2013-07-02 18:03:52 +02:00
|
|
|
/*
|
|
|
|
* We must check that the entire relocation array is safe
|
|
|
|
* to read, but since we may need to update the presumed
|
|
|
|
* offsets during execution, check for full write access.
|
|
|
|
*/
|
2013-02-23 10:47:31 +01:00
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
i915_gem_execbuffer_move_to_active(struct list_head *objects,
|
2013-10-26 15:34:57 +02:00
|
|
|
struct i915_address_space *vm,
|
2013-02-23 10:47:31 +01:00
|
|
|
struct intel_ring_buffer *ring)
|
|
|
|
{
|
|
|
|
struct drm_i915_gem_object *obj;
|
|
|
|
|
|
|
|
list_for_each_entry(obj, objects, exec_list) {
|
|
|
|
u32 old_read = obj->base.read_domains;
|
|
|
|
u32 old_write = obj->base.write_domain;
|
|
|
|
|
|
|
|
obj->base.write_domain = obj->base.pending_write_domain;
|
2013-04-24 22:04:21 +02:00
|
|
|
if (obj->base.write_domain == 0)
|
|
|
|
obj->base.pending_read_domains |= obj->base.read_domains;
|
|
|
|
obj->base.read_domains = obj->base.pending_read_domains;
|
2013-02-23 10:47:31 +01:00
|
|
|
obj->fenced_gpu_access = obj->pending_fenced_gpu_access;
|
|
|
|
|
2013-10-26 15:34:57 +02:00
|
|
|
/* FIXME: This lookup gets fixed later <-- danvet */
|
|
|
|
list_move_tail(&i915_gem_obj_to_vma(obj, vm)->mm_list, &vm->active_list);
|
2013-02-23 10:47:31 +01:00
|
|
|
i915_gem_object_move_to_active(obj, ring);
|
|
|
|
if (obj->base.write_domain) {
|
|
|
|
obj->dirty = 1;
|
|
|
|
obj->last_write_seqno = intel_ring_get_seqno(ring);
|
|
|
|
if (obj->pin_count) /* check for potential scanout */
|
2013-10-26 15:34:57 +02:00
|
|
|
intel_mark_fb_busy(obj, ring);
|
2013-02-23 10:47:31 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
trace_i915_gem_object_change_domain(obj, old_read, old_write);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
i915_gem_execbuffer_retire_commands(struct drm_device *dev,
|
|
|
|
struct drm_file *file,
|
2013-10-26 15:34:57 +02:00
|
|
|
struct intel_ring_buffer *ring,
|
|
|
|
struct drm_i915_gem_object *obj)
|
2013-02-23 10:47:31 +01:00
|
|
|
{
|
|
|
|
/* Unconditionally force add_request to emit a full flush. */
|
|
|
|
ring->gpu_caches_dirty = true;
|
|
|
|
|
|
|
|
/* Add a breadcrumb for the completion of the batch buffer */
|
2013-10-26 15:34:57 +02:00
|
|
|
(void)__i915_add_request(ring, file, obj, NULL);
|
2013-02-23 10:47:31 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
i915_reset_gen7_sol_offsets(struct drm_device *dev,
|
|
|
|
struct intel_ring_buffer *ring)
|
|
|
|
{
|
|
|
|
drm_i915_private_t *dev_priv = dev->dev_private;
|
|
|
|
int ret, i;
|
|
|
|
|
|
|
|
if (!IS_GEN7(dev) || ring != &dev_priv->ring[RCS])
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
ret = intel_ring_begin(ring, 4 * 3);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
for (i = 0; i < 4; i++) {
|
|
|
|
intel_ring_emit(ring, MI_LOAD_REGISTER_IMM(1));
|
|
|
|
intel_ring_emit(ring, GEN7_SO_WRITE_OFFSET(i));
|
|
|
|
intel_ring_emit(ring, 0);
|
|
|
|
}
|
|
|
|
|
|
|
|
intel_ring_advance(ring);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
i915_gem_do_execbuffer(struct drm_device *dev, void *data,
|
|
|
|
struct drm_file *file,
|
|
|
|
struct drm_i915_gem_execbuffer2 *args,
|
2013-10-26 15:34:57 +02:00
|
|
|
struct drm_i915_gem_exec_object2 *exec,
|
|
|
|
struct i915_address_space *vm)
|
2013-02-23 10:47:31 +01:00
|
|
|
{
|
|
|
|
drm_i915_private_t *dev_priv = dev->dev_private;
|
|
|
|
struct eb_objects *eb;
|
|
|
|
struct drm_i915_gem_object *batch_obj;
|
|
|
|
struct drm_clip_rect *cliprects = NULL;
|
|
|
|
struct intel_ring_buffer *ring;
|
|
|
|
u32 ctx_id = i915_execbuffer2_get_context_id(*args);
|
|
|
|
u32 exec_start, exec_len;
|
2013-04-24 22:04:21 +02:00
|
|
|
u32 mask, flags;
|
2013-02-23 10:47:31 +01:00
|
|
|
int ret, mode, i;
|
2013-04-24 22:04:21 +02:00
|
|
|
bool need_relocs;
|
2013-02-23 10:47:31 +01:00
|
|
|
|
2013-04-24 22:04:21 +02:00
|
|
|
if (!i915_gem_check_execbuffer(args))
|
2013-02-23 10:47:31 +01:00
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
ret = validate_exec_list(exec, args->buffer_count);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
flags = 0;
|
|
|
|
if (args->flags & I915_EXEC_SECURE) {
|
|
|
|
|
|
|
|
flags |= I915_DISPATCH_SECURE;
|
|
|
|
}
|
|
|
|
if (args->flags & I915_EXEC_IS_PINNED)
|
|
|
|
flags |= I915_DISPATCH_PINNED;
|
|
|
|
|
|
|
|
switch (args->flags & I915_EXEC_RING_MASK) {
|
|
|
|
case I915_EXEC_DEFAULT:
|
|
|
|
case I915_EXEC_RENDER:
|
|
|
|
ring = &dev_priv->ring[RCS];
|
|
|
|
break;
|
|
|
|
case I915_EXEC_BSD:
|
|
|
|
ring = &dev_priv->ring[VCS];
|
2013-10-26 15:34:57 +02:00
|
|
|
if (ctx_id != DEFAULT_CONTEXT_ID) {
|
2013-02-23 10:47:31 +01:00
|
|
|
DRM_DEBUG("Ring %s doesn't support contexts\n",
|
|
|
|
ring->name);
|
|
|
|
return -EPERM;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case I915_EXEC_BLT:
|
|
|
|
ring = &dev_priv->ring[BCS];
|
2013-10-26 15:34:57 +02:00
|
|
|
if (ctx_id != DEFAULT_CONTEXT_ID) {
|
2013-02-23 10:47:31 +01:00
|
|
|
DRM_DEBUG("Ring %s doesn't support contexts\n",
|
|
|
|
ring->name);
|
|
|
|
return -EPERM;
|
|
|
|
}
|
|
|
|
break;
|
2013-10-26 15:34:57 +02:00
|
|
|
case I915_EXEC_VEBOX:
|
|
|
|
ring = &dev_priv->ring[VECS];
|
|
|
|
if (ctx_id != DEFAULT_CONTEXT_ID) {
|
|
|
|
DRM_DEBUG("Ring %s doesn't support contexts\n",
|
|
|
|
ring->name);
|
|
|
|
return -EPERM;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
|
2013-02-23 10:47:31 +01:00
|
|
|
default:
|
|
|
|
DRM_DEBUG("execbuf with unknown ring: %d\n",
|
|
|
|
(int)(args->flags & I915_EXEC_RING_MASK));
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
if (!intel_ring_initialized(ring)) {
|
|
|
|
DRM_DEBUG("execbuf with invalid ring: %d\n",
|
|
|
|
(int)(args->flags & I915_EXEC_RING_MASK));
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
mode = args->flags & I915_EXEC_CONSTANTS_MASK;
|
|
|
|
mask = I915_EXEC_CONSTANTS_MASK;
|
|
|
|
switch (mode) {
|
|
|
|
case I915_EXEC_CONSTANTS_REL_GENERAL:
|
|
|
|
case I915_EXEC_CONSTANTS_ABSOLUTE:
|
|
|
|
case I915_EXEC_CONSTANTS_REL_SURFACE:
|
|
|
|
if (ring == &dev_priv->ring[RCS] &&
|
|
|
|
mode != dev_priv->relative_constants_mode) {
|
|
|
|
if (INTEL_INFO(dev)->gen < 4)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
if (INTEL_INFO(dev)->gen > 5 &&
|
|
|
|
mode == I915_EXEC_CONSTANTS_REL_SURFACE)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
/* The HW changed the meaning on this bit on gen6 */
|
|
|
|
if (INTEL_INFO(dev)->gen >= 6)
|
|
|
|
mask &= ~I915_EXEC_CONSTANTS_REL_SURFACE;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
DRM_DEBUG("execbuf with unknown constants: %d\n", mode);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (args->buffer_count < 1) {
|
|
|
|
DRM_DEBUG("execbuf with %d buffers\n", args->buffer_count);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (args->num_cliprects != 0) {
|
|
|
|
if (ring != &dev_priv->ring[RCS]) {
|
|
|
|
DRM_DEBUG("clip rectangles are only valid with the render ring\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (INTEL_INFO(dev)->gen >= 5) {
|
|
|
|
DRM_DEBUG("clip rectangles are only valid on pre-gen5\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (args->num_cliprects > UINT_MAX / sizeof(*cliprects)) {
|
|
|
|
DRM_DEBUG("execbuf with %u cliprects\n",
|
|
|
|
args->num_cliprects);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
cliprects = kmalloc(args->num_cliprects * sizeof(*cliprects),
|
|
|
|
GFP_KERNEL);
|
|
|
|
if (cliprects == NULL) {
|
|
|
|
ret = -ENOMEM;
|
|
|
|
goto pre_mutex_err;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (copy_from_user(cliprects,
|
2013-07-02 18:03:52 +02:00
|
|
|
to_user_ptr(args->cliprects_ptr),
|
2013-02-23 10:47:31 +01:00
|
|
|
sizeof(*cliprects)*args->num_cliprects)) {
|
|
|
|
ret = -EFAULT;
|
|
|
|
goto pre_mutex_err;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = i915_mutex_lock_interruptible(dev);
|
|
|
|
if (ret)
|
|
|
|
goto pre_mutex_err;
|
|
|
|
|
2013-10-26 15:34:57 +02:00
|
|
|
if (dev_priv->ums.mm_suspended) {
|
2013-02-23 10:47:31 +01:00
|
|
|
mutex_unlock(&dev->struct_mutex);
|
|
|
|
ret = -EBUSY;
|
|
|
|
goto pre_mutex_err;
|
|
|
|
}
|
|
|
|
|
2013-04-24 22:04:21 +02:00
|
|
|
eb = eb_create(args);
|
2013-02-23 10:47:31 +01:00
|
|
|
if (eb == NULL) {
|
|
|
|
mutex_unlock(&dev->struct_mutex);
|
|
|
|
ret = -ENOMEM;
|
|
|
|
goto pre_mutex_err;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Look up object handles */
|
2013-04-24 22:04:21 +02:00
|
|
|
ret = eb_lookup_objects(eb, exec, args, file);
|
|
|
|
if (ret)
|
2013-02-23 10:47:31 +01:00
|
|
|
goto err;
|
|
|
|
|
|
|
|
/* take note of the batch buffer before we might reorder the lists */
|
2013-04-24 22:04:21 +02:00
|
|
|
batch_obj = list_entry(eb->objects.prev,
|
2013-02-23 10:47:31 +01:00
|
|
|
struct drm_i915_gem_object,
|
|
|
|
exec_list);
|
|
|
|
|
|
|
|
/* Move the objects en-masse into the GTT, evicting if necessary. */
|
2013-04-24 22:04:21 +02:00
|
|
|
need_relocs = (args->flags & I915_EXEC_NO_RELOC) == 0;
|
2013-10-26 15:34:57 +02:00
|
|
|
ret = i915_gem_execbuffer_reserve(ring, &eb->objects, vm, &need_relocs);
|
2013-02-23 10:47:31 +01:00
|
|
|
if (ret)
|
|
|
|
goto err;
|
|
|
|
|
|
|
|
/* The objects are in their final locations, apply the relocations. */
|
2013-04-24 22:04:21 +02:00
|
|
|
if (need_relocs)
|
2013-10-26 15:34:57 +02:00
|
|
|
ret = i915_gem_execbuffer_relocate(eb, vm);
|
2013-02-23 10:47:31 +01:00
|
|
|
if (ret) {
|
|
|
|
if (ret == -EFAULT) {
|
2013-04-24 22:04:21 +02:00
|
|
|
ret = i915_gem_execbuffer_relocate_slow(dev, args, file, ring,
|
2013-10-26 15:34:57 +02:00
|
|
|
eb, exec, vm);
|
2013-02-23 10:47:31 +01:00
|
|
|
BUG_ON(!mutex_is_locked(&dev->struct_mutex));
|
|
|
|
}
|
|
|
|
if (ret)
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Set the pending read domains for the batch buffer to COMMAND */
|
|
|
|
if (batch_obj->base.pending_write_domain) {
|
|
|
|
DRM_DEBUG("Attempting to use self-modifying batch buffer\n");
|
|
|
|
ret = -EINVAL;
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
batch_obj->base.pending_read_domains |= I915_GEM_DOMAIN_COMMAND;
|
|
|
|
|
|
|
|
/* snb/ivb/vlv conflate the "batch in ppgtt" bit with the "non-secure
|
|
|
|
* batch" bit. Hence we need to pin secure batches into the global gtt.
|
|
|
|
* hsw should have this fixed, but let's be paranoid and do it
|
|
|
|
* unconditionally for now. */
|
|
|
|
if (flags & I915_DISPATCH_SECURE && !batch_obj->has_global_gtt_mapping)
|
|
|
|
i915_gem_gtt_bind_object(batch_obj, batch_obj->cache_level);
|
|
|
|
|
2013-04-24 22:04:21 +02:00
|
|
|
ret = i915_gem_execbuffer_move_to_gpu(ring, &eb->objects);
|
2013-02-23 10:47:31 +01:00
|
|
|
if (ret)
|
|
|
|
goto err;
|
|
|
|
|
|
|
|
ret = i915_switch_context(ring, file, ctx_id);
|
|
|
|
if (ret)
|
|
|
|
goto err;
|
|
|
|
|
|
|
|
if (ring == &dev_priv->ring[RCS] &&
|
|
|
|
mode != dev_priv->relative_constants_mode) {
|
|
|
|
ret = intel_ring_begin(ring, 4);
|
|
|
|
if (ret)
|
|
|
|
goto err;
|
|
|
|
|
|
|
|
intel_ring_emit(ring, MI_NOOP);
|
|
|
|
intel_ring_emit(ring, MI_LOAD_REGISTER_IMM(1));
|
|
|
|
intel_ring_emit(ring, INSTPM);
|
|
|
|
intel_ring_emit(ring, mask << 16 | mode);
|
|
|
|
intel_ring_advance(ring);
|
|
|
|
|
|
|
|
dev_priv->relative_constants_mode = mode;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (args->flags & I915_EXEC_GEN7_SOL_RESET) {
|
|
|
|
ret = i915_reset_gen7_sol_offsets(dev, ring);
|
|
|
|
if (ret)
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
|
2013-10-26 15:34:57 +02:00
|
|
|
exec_start = i915_gem_obj_offset(batch_obj, vm) +
|
|
|
|
args->batch_start_offset;
|
2013-02-23 10:47:31 +01:00
|
|
|
exec_len = args->batch_len;
|
|
|
|
if (cliprects) {
|
2013-11-17 07:47:10 +01:00
|
|
|
for (i = 0; i < args->num_cliprects; i++) {
|
|
|
|
ret = i915_emit_box(dev, &cliprects[i],
|
|
|
|
args->DR1, args->DR4);
|
|
|
|
if (ret)
|
|
|
|
goto err;
|
2013-04-24 22:04:21 +02:00
|
|
|
|
2013-11-17 07:47:10 +01:00
|
|
|
ret = ring->dispatch_execbuffer(ring,
|
|
|
|
exec_start, exec_len,
|
|
|
|
flags);
|
|
|
|
if (ret)
|
|
|
|
goto err;
|
|
|
|
}
|
2013-02-23 10:47:31 +01:00
|
|
|
} else {
|
|
|
|
ret = ring->dispatch_execbuffer(ring,
|
|
|
|
exec_start, exec_len,
|
|
|
|
flags);
|
|
|
|
if (ret)
|
|
|
|
goto err;
|
|
|
|
}
|
|
|
|
|
2013-02-24 07:22:22 +01:00
|
|
|
trace_i915_gem_ring_dispatch(ring, intel_ring_get_seqno(ring), flags);
|
|
|
|
|
2013-10-26 15:34:57 +02:00
|
|
|
i915_gem_execbuffer_move_to_active(&eb->objects, vm, ring);
|
|
|
|
i915_gem_execbuffer_retire_commands(dev, file, ring, batch_obj);
|
2013-02-23 10:47:31 +01:00
|
|
|
|
|
|
|
err:
|
|
|
|
eb_destroy(eb);
|
|
|
|
|
|
|
|
mutex_unlock(&dev->struct_mutex);
|
|
|
|
|
|
|
|
pre_mutex_err:
|
2013-10-26 15:34:57 +02:00
|
|
|
kfree(cliprects);
|
2013-02-23 10:47:31 +01:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2013-11-17 07:47:10 +01:00
|
|
|
#if 0
|
|
|
|
/*
|
|
|
|
* Legacy execbuffer just creates an exec2 list from the original exec object
|
|
|
|
* list array and passes it to the real function.
|
|
|
|
*/
|
|
|
|
int
|
|
|
|
i915_gem_execbuffer(struct drm_device *dev, void *data,
|
|
|
|
struct drm_file *file)
|
|
|
|
{
|
|
|
|
struct drm_i915_private *dev_priv = dev->dev_private;
|
|
|
|
struct drm_i915_gem_execbuffer *args = data;
|
|
|
|
struct drm_i915_gem_execbuffer2 exec2;
|
|
|
|
struct drm_i915_gem_exec_object *exec_list = NULL;
|
|
|
|
struct drm_i915_gem_exec_object2 *exec2_list = NULL;
|
|
|
|
int ret, i;
|
2013-04-24 22:04:21 +02:00
|
|
|
|
2013-11-17 07:47:10 +01:00
|
|
|
if (args->buffer_count < 1) {
|
|
|
|
DRM_DEBUG("execbuf with %d buffers\n", args->buffer_count);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Copy in the exec list from userland */
|
|
|
|
exec_list = drm_malloc_ab(sizeof(*exec_list), args->buffer_count);
|
|
|
|
exec2_list = drm_malloc_ab(sizeof(*exec2_list), args->buffer_count);
|
|
|
|
if (exec_list == NULL || exec2_list == NULL) {
|
|
|
|
DRM_DEBUG("Failed to allocate exec list for %d buffers\n",
|
|
|
|
args->buffer_count);
|
|
|
|
drm_free_large(exec_list);
|
|
|
|
drm_free_large(exec2_list);
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
ret = copy_from_user(exec_list,
|
|
|
|
to_user_ptr(args->buffers_ptr),
|
|
|
|
sizeof(*exec_list) * args->buffer_count);
|
|
|
|
if (ret != 0) {
|
|
|
|
DRM_DEBUG("copy %d exec entries failed %d\n",
|
|
|
|
args->buffer_count, ret);
|
|
|
|
drm_free_large(exec_list);
|
|
|
|
drm_free_large(exec2_list);
|
|
|
|
return -EFAULT;
|
|
|
|
}
|
|
|
|
|
|
|
|
for (i = 0; i < args->buffer_count; i++) {
|
|
|
|
exec2_list[i].handle = exec_list[i].handle;
|
|
|
|
exec2_list[i].relocation_count = exec_list[i].relocation_count;
|
|
|
|
exec2_list[i].relocs_ptr = exec_list[i].relocs_ptr;
|
|
|
|
exec2_list[i].alignment = exec_list[i].alignment;
|
|
|
|
exec2_list[i].offset = exec_list[i].offset;
|
|
|
|
if (INTEL_INFO(dev)->gen < 4)
|
|
|
|
exec2_list[i].flags = EXEC_OBJECT_NEEDS_FENCE;
|
|
|
|
else
|
|
|
|
exec2_list[i].flags = 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
exec2.buffers_ptr = args->buffers_ptr;
|
|
|
|
exec2.buffer_count = args->buffer_count;
|
|
|
|
exec2.batch_start_offset = args->batch_start_offset;
|
|
|
|
exec2.batch_len = args->batch_len;
|
|
|
|
exec2.DR1 = args->DR1;
|
|
|
|
exec2.DR4 = args->DR4;
|
|
|
|
exec2.num_cliprects = args->num_cliprects;
|
|
|
|
exec2.cliprects_ptr = args->cliprects_ptr;
|
|
|
|
exec2.flags = I915_EXEC_RENDER;
|
|
|
|
i915_execbuffer2_set_context_id(exec2, 0);
|
|
|
|
|
|
|
|
ret = i915_gem_do_execbuffer(dev, data, file, &exec2, exec2_list,
|
|
|
|
&dev_priv->gtt.base);
|
|
|
|
if (!ret) {
|
|
|
|
/* Copy the new buffer offsets back to the user's exec list. */
|
|
|
|
for (i = 0; i < args->buffer_count; i++)
|
|
|
|
exec_list[i].offset = exec2_list[i].offset;
|
|
|
|
/* ... and back out to userspace */
|
|
|
|
ret = copy_to_user(to_user_ptr(args->buffers_ptr),
|
|
|
|
exec_list,
|
|
|
|
sizeof(*exec_list) * args->buffer_count);
|
|
|
|
if (ret) {
|
|
|
|
ret = -EFAULT;
|
|
|
|
DRM_DEBUG("failed to copy %d exec entries "
|
|
|
|
"back to user (%d)\n",
|
|
|
|
args->buffer_count, ret);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
drm_free_large(exec_list);
|
|
|
|
drm_free_large(exec2_list);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
#endif
|
2013-04-24 22:04:21 +02:00
|
|
|
|
2013-02-23 10:47:31 +01:00
|
|
|
int
|
|
|
|
i915_gem_execbuffer2(struct drm_device *dev, void *data,
|
|
|
|
struct drm_file *file)
|
|
|
|
{
|
2013-10-26 15:34:57 +02:00
|
|
|
struct drm_i915_private *dev_priv = dev->dev_private;
|
2013-02-23 10:47:31 +01:00
|
|
|
struct drm_i915_gem_execbuffer2 *args = data;
|
|
|
|
struct drm_i915_gem_exec_object2 *exec2_list = NULL;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
if (args->buffer_count < 1 ||
|
|
|
|
args->buffer_count > UINT_MAX / sizeof(*exec2_list)) {
|
|
|
|
DRM_DEBUG("execbuf2 with %d buffers\n", args->buffer_count);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2013-04-24 22:04:21 +02:00
|
|
|
exec2_list = kmalloc(sizeof(*exec2_list)*args->buffer_count,
|
|
|
|
GFP_TEMPORARY | __GFP_NOWARN | __GFP_NORETRY);
|
2013-02-23 10:47:31 +01:00
|
|
|
if (exec2_list == NULL) {
|
|
|
|
DRM_DEBUG("Failed to allocate exec list for %d buffers\n",
|
|
|
|
args->buffer_count);
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
ret = copy_from_user(exec2_list,
|
|
|
|
(struct drm_i915_relocation_entry __user *)
|
|
|
|
(uintptr_t) args->buffers_ptr,
|
|
|
|
sizeof(*exec2_list) * args->buffer_count);
|
|
|
|
if (ret != 0) {
|
|
|
|
DRM_DEBUG("copy %d exec entries failed %d\n",
|
|
|
|
args->buffer_count, ret);
|
2013-02-24 07:22:22 +01:00
|
|
|
kfree(exec2_list);
|
|
|
|
FAIL();
|
2013-02-23 10:47:31 +01:00
|
|
|
return -EFAULT;
|
|
|
|
}
|
|
|
|
|
2013-10-26 15:34:57 +02:00
|
|
|
ret = i915_gem_do_execbuffer(dev, data, file, args, exec2_list,
|
|
|
|
&dev_priv->gtt.base);
|
2013-02-23 10:47:31 +01:00
|
|
|
if (!ret) {
|
|
|
|
/* Copy the new buffer offsets back to the user's exec list. */
|
|
|
|
ret = copy_to_user((void __user *)(uintptr_t)args->buffers_ptr,
|
|
|
|
exec2_list,
|
|
|
|
sizeof(*exec2_list) * args->buffer_count);
|
|
|
|
if (ret) {
|
|
|
|
ret = -EFAULT;
|
|
|
|
DRM_DEBUG("failed to copy %d exec entries "
|
|
|
|
"back to user (%d)\n",
|
|
|
|
args->buffer_count, ret);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-02-24 07:22:22 +01:00
|
|
|
kfree(exec2_list);
|
2013-02-23 10:47:31 +01:00
|
|
|
return ret;
|
|
|
|
}
|