From 088dbaed5f2e17194bfef081d422ce9b12450728 Mon Sep 17 00:00:00 2001 From: Abdur-Rahman Mansoor Date: Fri, 23 Aug 2024 08:17:12 -0400 Subject: [PATCH] NVMe: add TODO comment suggested by @sdongles --- drivers/nvme/nvme.asm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/nvme/nvme.asm b/drivers/nvme/nvme.asm index 935f23768b..00e3de25c2 100644 --- a/drivers/nvme/nvme.asm +++ b/drivers/nvme/nvme.asm @@ -1136,6 +1136,12 @@ proc cqyhdbl_write stdcall, pci:dword, y:dword, cqh:dword mov word [esi + edx], ax ; Write to CQyHDBL mov word [edi + NVM_QUEUE_ENTRY.head], ax + ; NOTE: Currently commented out since we're just using + ; plain spinlocks for notifying when a command has been + ; completed, but this will be uncommented later and use + ; semaphores instead of mutexes once the polling code + ; has been replaced with the asynchronous API. + ; Unlock the mutex now that the command is complete ;mov edi, dword [edi + NVM_QUEUE_ENTRY.cmd_ptr] ;mov ecx, [cqh]