Docs: Added README and contributing guide #124

Merged
mxlgv merged 9 commits from add-readme-contributing-code-of-conduct into main 2025-03-21 21:08:49 +01:00
Owner
No description provided.
mxlgv added 1 commit 2025-03-08 22:42:34 +01:00
mxlgv force-pushed add-readme-contributing-code-of-conduct from f298c2d0f7 to 45b299d80c 2025-03-08 22:42:47 +01:00 Compare
mxlgv requested review from dunkaist 2025-03-09 11:21:02 +01:00
mxlgv requested review from Leency 2025-03-09 11:21:03 +01:00
mxlgv requested review from Burer 2025-03-09 11:21:36 +01:00
mxlgv requested review from rgimad 2025-03-09 11:21:52 +01:00
dunkaist reviewed 2025-03-10 16:58:24 +01:00
@@ -0,0 +4,4 @@
## Purpose
The primary goal of our community is to be inclusive of a large number of contributors, with the most varied and diverse backgrounds possible. As such, we are committed to providing a friendly, safe and welcoming environment for all, regardless of gender, ability, ethnicity, socioeconomic status, and religion (or lack thereof)
Owner

I believe the primary goal of our community is to develop KolibriOS, isn't it?

I believe the primary goal of our community is to develop KolibriOS, isn't it?
Author
Owner

CoC has been removed.

CoC has been removed.
mxlgv marked this conversation as resolved
dunkaist reviewed 2025-03-10 17:07:26 +01:00
@@ -0,0 +8,4 @@
This code of conduct outlines our expectations for all those who participate in our community, as well as the consequences for unacceptable behavior
We invite all those who participate in our community to help us create safe and positive experience for everyone
Owner

If we require people to follow this CoC, then we should be honest and use words like force, enforce but not invite.

If we require people to follow this CoC, then we should be honest and use words like force, enforce but not invite.
Author
Owner

CoC has been removed.

CoC has been removed.
mxlgv marked this conversation as resolved
dunkaist reviewed 2025-03-10 17:08:23 +01:00
@@ -0,0 +6,4 @@
The primary goal of our community is to be inclusive of a large number of contributors, with the most varied and diverse backgrounds possible. As such, we are committed to providing a friendly, safe and welcoming environment for all, regardless of gender, ability, ethnicity, socioeconomic status, and religion (or lack thereof)
This code of conduct outlines our expectations for all those who participate in our community, as well as the consequences for unacceptable behavior
Owner

This document does not mention consequences.

This document does not mention consequences.
Author
Owner

CoC has been removed.

CoC has been removed.
mxlgv marked this conversation as resolved
rgimad requested changes 2025-03-10 17:14:11 +01:00
Dismissed
CONTRIBUTING.md Outdated
@@ -0,0 +41,4 @@
- Pattern
Regular commit message should consist of several parts and be built according to the following template:
Owner

Text seems like too formal

For example, instead of this, you can simply write smth like

Commit message should look like
etc

Text seems like too formal For example, instead of this, you can simply write smth like `Commit message should look like ` etc
Author
Owner

Fixed

Fixed
mxlgv marked this conversation as resolved
CONTRIBUTING.md Outdated
@@ -0,0 +92,4 @@
### Signing
This is not a requirement, but it is strongly recommended to sign commits. This can be done by the following command:
Owner

Maybe you should in two words say why

Maybe you should in two words say why
Author
Owner
Deleted. Not relevant for us: https://stackoverflow.com/questions/1962094/what-is-the-sign-off-feature-in-git-for
mxlgv marked this conversation as resolved
dunkaist reviewed 2025-03-10 17:25:27 +01:00
CONTRIBUTING.md Outdated
@@ -0,0 +55,4 @@
- Length
The maximum number of characters in a commit header is __72__ (standard for __Git__). Additionally, __72__ is the maximum length of a line in a commit body.
Owner

Why not 50 and 72 like in Linux?

Why not 50 and 72 like in Linux?
Author
Owner

I thought about it but I didn't find any advantages. Rather, we limit ourselves.

I thought about it but I didn't find any advantages. Rather, we limit ourselves.
mxlgv marked this conversation as resolved
mxlgv force-pushed add-readme-contributing-code-of-conduct from 45b299d80c to 35f774b541 2025-03-10 21:33:07 +01:00 Compare
mxlgv changed title from Docs: Added README, contributing guide and code of conduct to Docs: Added README and contributing guide 2025-03-10 21:34:00 +01:00
mxlgv force-pushed add-readme-contributing-code-of-conduct from 35f774b541 to d2856e033e 2025-03-11 22:25:25 +01:00 Compare
mxlgv force-pushed add-readme-contributing-code-of-conduct from d2856e033e to 3cc3fa6689 2025-03-11 22:31:24 +01:00 Compare
mxlgv added 1 commit 2025-03-11 23:07:44 +01:00
mxlgv force-pushed add-readme-contributing-code-of-conduct from b5ff84abe1 to d55f2055f2 2025-03-11 23:08:17 +01:00 Compare
mxlgv force-pushed add-readme-contributing-code-of-conduct from d55f2055f2 to 63264c83a3 2025-03-11 23:11:02 +01:00 Compare
mxlgv requested review from rgimad 2025-03-11 23:13:38 +01:00
rgimad approved these changes 2025-03-12 08:45:48 +01:00
Dismissed
Burer added 1 commit 2025-03-12 09:37:09 +01:00
Burer dismissed rgimad’s review 2025-03-12 09:37:09 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Burer approved these changes 2025-03-12 09:37:43 +01:00
Dismissed
rgimad approved these changes 2025-03-12 09:45:02 +01:00
Dismissed
mxlgv requested review from Sweetbread 2025-03-12 10:21:52 +01:00
Sweetbread requested changes 2025-03-13 19:19:36 +01:00
Dismissed
CONTRIBUTING.md Outdated
@@ -0,0 +37,4 @@
The commit message should look like this:
```test
[Category] Commit message header
Owner

-> commit type(category): commit message
To Conventional Commit Messages

-> `commit type`(`category`): `commit message` To [Conventional Commit Messages](https://gist.github.com/rishavpandey43/84665ffe3cea76400d8e5a1ad7133a79)
Owner

I have checked Linux, Qemu and GCC. They all do mention categories but in a plain format like 'category: Commit message'. I believe it would be easier for us to explain to people why they should follow a policy if it is the policy of Linux, Qemu and GCC rather than the one of Rishav Pandey.

I have checked [Linux](https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=90fd9ad5b0c981693c8512d9da01f14fb6596e9d), [Qemu](https://gitlab.com/qemu-project/qemu/-/commit/2f3b6e61f692bade441230dd25c1c0f101bd2eef) and [GCC](https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=254549d2bb9bb3c2719dec597427919c59514fc3). They all do mention categories but in a plain format like 'category: Commit message'. I believe it would be easier for us to explain to people why they should follow a policy if it is the policy of Linux, Qemu and GCC rather than the one of Rishav Pandey.
Owner

https://www.conventionalcommits.org/en/v1.0.0/

Why Use Conventional Commits

  • Automatically generating CHANGELOGs.
  • Automatically determining a semantic version bump (based on the types of commits landed).
  • Communicating the nature of changes to teammates, the public, and other stakeholders.
  • Triggering build and publish processes.
  • Making it easier for people to contribute to your projects, by allowing them to explore a more structured commit history.
https://www.conventionalcommits.org/en/v1.0.0/ > **Why Use Conventional Commits** > - Automatically generating CHANGELOGs. > - Automatically determining a semantic version bump (based on the types of commits landed). > - Communicating the nature of changes to teammates, the public, and other stakeholders. > - Triggering build and publish processes. > - Making it easier for people to contribute to your projects, by allowing them to explore a more structured commit history.
Owner

I might be wrong but this looks like whishful thinking to me.

Automatically generating CHANGELOGs.

All the automatically generated changelogs I have seen are unreadable because you have to know the context first to understand them. They can be used if you want to have them as a formality only. But they won't be useful for users/developers as a dump of commit messages.

Automatically determining a semantic version bump (based on the types of commits landed).

To what version in KolibriOS does this apply?

Communicating the nature of changes to teammates, the public, and other stakeholders.

The nature of changes is described in any normal commit message.

Triggering build and publish processes.

Currently we build and publish on each push. What will this change?

Making it easier for people to contribute to your projects, by allowing them to explore a more structured commit history.

I have never seen anybody using it.

I might be wrong but this looks like whishful thinking to me. > Automatically generating CHANGELOGs. All the automatically generated changelogs I have seen are unreadable because you have to know the context first to understand them. They can be used if you want to have them as a formality only. But they won't be useful for users/developers as a dump of commit messages. > Automatically determining a semantic version bump (based on the types of commits landed). To what version in KolibriOS does this apply? > Communicating the nature of changes to teammates, the public, and other stakeholders. The nature of changes is described in any normal commit message. > Triggering build and publish processes. Currently we build and publish on each push. What will this change? > Making it easier for people to contribute to your projects, by allowing them to explore a more structured commit history. I have never seen anybody using it.
Owner

All the automatically generated changelogs I have seen are unreadable because you have to know the context first to understand them

If commit messages are descriptive, follow a consistent format, and include meaningful context, the generated changelog can be more useful.

To what version in KolibriOS does this apply?

Not neccessary the OS, but apps, libs and other software in it

The nature of changes is described in any normal commit message.

The standart enforse to use types, which is better both for describing and searching in commit list

Currently we build and publish on each push. What will this change?

For example, not to build if the type is docs

I have never seen anybody using it.

Namida, antimicrox, AGS, yazi, bubbletea, pokete, Bagels, kaizen, fd

> All the automatically generated changelogs I have seen are unreadable because you have to know the context first to understand them If commit messages are descriptive, follow a consistent format, and include meaningful context, the generated changelog can be more useful. > To what version in KolibriOS does this apply? Not neccessary the OS, but apps, libs and other software in it > The nature of changes is described in any normal commit message. The standart enforse to use types, which is better both for describing and searching in commit list > Currently we build and publish on each push. What will this change? For example, not to build if the type is `docs` > I have never seen anybody using it. [Namida](https://github.com/namidaco/namida), [antimicrox](https://github.com/AntiMicroX/antimicrox), [AGS](https://github.com/Aylur/ags), [yazi](https://github.com/sxyazi/yazi), [bubbletea](https://github.com/charmbracelet/bubbletea), [pokete](https://github.com/lxgr-linux/pokete), [Bagels](https://github.com/EnhancedJax/Bagels), [kaizen](https://github.com/TheRiceCold/kaizen), [fd](https://github.com/sharkdp/fd)
Owner

If commit messages are descriptive, follow a consistent format, and include meaningful context, the generated changelog can be more useful.

I wish we could eventually motivate people to write meaningful commit messages. Let be honest, forcing them to choose from 20 commit types it just too much, it won't work. What is surprisingly strange, the spec allows to shorten feature as feat but not performance as perf, no logic behind this.

For example, not to build if the type is docs

The rebuild is needed is the docs are in the distro. Tup handles this automatically already. You don't need to manually control this via commit messages.

Namida, antimicrox, AGS, yazi, bubbletea, pokete, Bagels, kaizen, fd

I have never heard of them. Linux, Qemu and GCC are more familiar to our potential developers, I believe.

> If commit messages are descriptive, follow a consistent format, and include meaningful context, the generated changelog can be more useful. I wish we could eventually motivate people to write meaningful commit messages. Let be honest, forcing them to choose from 20 commit types it just too much, it won't work. What is surprisingly strange, the spec allows to shorten feature as feat but not performance as perf, no logic behind this. > For example, not to build if the type is docs The rebuild is needed is the docs are in the distro. Tup handles this automatically already. You don't need to manually control this via commit messages. > Namida, antimicrox, AGS, yazi, bubbletea, pokete, Bagels, kaizen, fd I have never heard of them. Linux, Qemu and GCC are more familiar to our potential developers, I believe.
Author
Owner

What GCC uses, Linux seems to me really more attractive

What GCC uses, Linux seems to me really more attractive
Author
Owner

@Sweetbread @dunkaist The adoption of a style for commits can take a long time (while we are discussing we don't have any documentation at all). This minimal documentation with very light rules should be enough for the community while it adapts to GIT. We can probably raise this issue in the future. But for now, let's not get hung up on it. This PR contains other changes as well.

@Sweetbread @dunkaist The adoption of a style for commits can take a long time (while we are discussing we don't have any documentation at all). This minimal documentation with very light rules should be enough for the community while it adapts to GIT. We can probably raise this issue in the future. But for now, let's not get hung up on it. This PR contains other changes as well.
mxlgv marked this conversation as resolved
Burer added 1 commit 2025-03-13 19:40:45 +01:00
Burer dismissed Burer’s review 2025-03-13 19:40:45 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Burer dismissed rgimad’s review 2025-03-13 19:40:45 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Sweetbread reviewed 2025-03-13 19:51:23 +01:00
CONTRIBUTING.md Outdated
@@ -0,0 +24,4 @@
2. Make a fork of kolibrios (or other needed) repository
3. Create a branch with a name that matches your changes
4. Implement and test the changes
5. Create commits according to the [accepted style](##commit-style)
Owner

Incorrect anchor link

Incorrect anchor link
Owner

Fixed.

Fixed.
mxlgv marked this conversation as resolved
Burer added 1 commit 2025-03-14 09:04:02 +01:00
mxlgv added the
Kind
Documentation
PR
Request changes
labels 2025-03-15 23:20:18 +01:00
mxlgv added 1 commit 2025-03-20 01:34:55 +01:00
mxlgv reviewed 2025-03-20 01:53:20 +01:00
README.md Outdated
@@ -0,0 +21,4 @@
The KolibriOS team expresses special thanks to the author of the 32-bit **MenuetOS**, [Ville Turjanmaa](https://www.menuetos.net/contact.htm). We also want to note that all **MenuetOS** copyrights have been preserved.
## License
Author
Owner

The license is already written next to Build system section. It seems that this is not necessary.

@Burer @dunkaist @Sweetbread what do you think?

The license is already written next to **Build system** section. It seems that this is not necessary. @Burer @dunkaist @Sweetbread what do you think?
Owner

I agree that we can remove License here, as it as already preset at the top of README.

I agree that we can remove License here, as it as already preset at the top of README.
Author
Owner

Fixed

Fixed
mxlgv marked this conversation as resolved
mxlgv added 1 commit 2025-03-20 17:06:16 +01:00
mxlgv added 1 commit 2025-03-20 17:12:31 +01:00
mxlgv force-pushed add-readme-contributing-code-of-conduct from 0499ba2c51 to 16f627ed45 2025-03-20 17:16:44 +01:00 Compare
Sweetbread dismissed Sweetbread’s review 2025-03-20 18:21:16 +01:00
mxlgv added
PR
Review required
and removed
PR
Request changes
labels 2025-03-20 18:41:26 +01:00
dunkaist reviewed 2025-03-21 03:42:23 +01:00
CONTRIBUTING.md Outdated
@@ -0,0 +2,4 @@
## Type of contributing
There are two main types of contributions accepted in KolibriOS:
Owner

in KolibriOS

If we were talking about the entire KolibriOS then we should have mentioned documentation, testing, content creation, etc. Since we agreed in the telegram chat to write about this main repo only, let's change 'in KolibriOS' to 'to the main KolibriOS repository'.

> in KolibriOS If we were talking about the entire KolibriOS then we should have mentioned documentation, testing, content creation, etc. Since we agreed in the telegram chat to write about this main repo only, let's change 'in KolibriOS' to 'to the main KolibriOS repository'.
Burer marked this conversation as resolved
dunkaist reviewed 2025-03-21 03:47:38 +01:00
CONTRIBUTING.md Outdated
@@ -0,0 +7,4 @@
- Submitting issues about problems in the project
- Submitting code to the project via pull requests
Each of these types is described in detail below.
Owner

Each of these types is

Both these types are ?

> Each of these types is Both these types are ?
Burer marked this conversation as resolved
dunkaist reviewed 2025-03-21 03:50:56 +01:00
CONTRIBUTING.md Outdated
@@ -0,0 +14,4 @@
You can help us by submitting issues about problems found in the system. Currently, there are two main ways of submitting an issue in the project: **Bug Reports** and **Feature Requests**:
- Bug Reports are suitable if you find a **bug** (crash, error, unexpected behavior) in some part of the system (kernel, drivers, apps, etc.) and want to report it
- Feature Request are used, when you want to propose some **improvement** to the system (missing features, improved user experience, etc.)
Owner

Feature Request

Feature Request_s_

improved user

improved user (only one space between the words)

> Feature Request Feature Request_s_ > improved user improved user (only one space between the words)
Burer marked this conversation as resolved
dunkaist reviewed 2025-03-21 03:54:45 +01:00
CONTRIBUTING.md Outdated
@@ -0,0 +28,4 @@
6. Create and submit a pull request into `main` branch
7. Wait for CI/CD pipelines and code review to pass
When a pull request is submitted, at least two project participants must conduct a code review, after which the proposed changes can be corrected (if it's necessary) and merged into the project.
Owner

changes can be corrected (if it's necessary)

changes need to be corrected (if requested)

> changes can be corrected (if it's necessary) changes need to be corrected (if requested)
Burer marked this conversation as resolved
dunkaist reviewed 2025-03-21 04:03:58 +01:00
CONTRIBUTING.md Outdated
@@ -0,0 +32,4 @@
## Commit style
### Pattern
Owner

Pattern

Message pattern?

> Pattern Message pattern?
Burer marked this conversation as resolved
dunkaist reviewed 2025-03-21 04:14:08 +01:00
CONTRIBUTING.md Outdated
@@ -0,0 +68,4 @@
## Conclusion
We hope this small instructions will help you to get familiar with KolibriOS contribution rules and inspire you to participate in the work of this project.
Owner

instructions

instruction

familiar with

familiar with (one space)

participate in the work of this project

participate in the life of our project?

> instructions instruction > familiar with familiar with (one space) > participate in the work of this project participate in the life of our project?
Burer marked this conversation as resolved
dunkaist reviewed 2025-03-21 04:15:56 +01:00
README.md Outdated
@@ -0,0 +3,4 @@
[![License](https://img.shields.io/badge/License-GPL%202.0-green)](./COPYING.TXT)
[![Build system](https://git.kolibrios.org/KolibriOS/kolibrios/actions/workflows/build.yaml/badge.svg)](https://git.kolibrios.org/KolibriOS/kolibrios/actions)
KolibriOS is a hobby operating system for x86-compatible computers, which is currently being developed by a small teem of enthusiasts.
Owner

small

small but passionate (!)

teem

team

> small small but passionate (!) > teem team
Burer marked this conversation as resolved
dunkaist reviewed 2025-03-21 04:17:24 +01:00
README.md Outdated
@@ -0,0 +5,4 @@
KolibriOS is a hobby operating system for x86-compatible computers, which is currently being developed by a small teem of enthusiasts.
It's kernel is written entirely in [FASM](https://flatassembler.net/) assembly language, making it very compact and lean on system resources.
Owner

It's

Its

kernel

kernel, most drivers and many programs

> It's Its > kernel kernel, most drivers and many programs
Burer marked this conversation as resolved
dunkaist reviewed 2025-03-21 04:18:03 +01:00
README.md Outdated
@@ -0,0 +7,4 @@
It's kernel is written entirely in [FASM](https://flatassembler.net/) assembly language, making it very compact and lean on system resources.
Based on [MenuetOS](https://www.menuetos.net/), it uses its own standards and is NOT fully POSIX or UNIX compliant
Owner

compliant

compliant. (dot)

> compliant compliant. (dot)
Burer marked this conversation as resolved
Burer added 1 commit 2025-03-21 08:53:03 +01:00
[Docs/Readme and Contributing] Fixed text mistakes
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 42s
Build system / Build (pull_request) Successful in 5m44s
05d8850702
dunkaist approved these changes 2025-03-21 13:03:33 +01:00
mxlgv added
PR
Ready to merge
and removed
PR
Review required
labels 2025-03-21 20:50:01 +01:00
mxlgv merged commit 22d572f789 into main 2025-03-21 21:08:49 +01:00
mxlgv deleted branch add-readme-contributing-code-of-conduct 2025-03-21 21:08:51 +01:00
Sign in to join this conversation.
5 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#124
No description provided.