KolibriOS/kolibrios
13
14
Fork 12
Code Issues 113 Pull Requests 16 Actions Projects 1 Releases Wiki Activity

Ftpc: Update #185

Merged
mxlgv merged 6 commits from ftpc-update into main 2025-04-10 18:47:17 +02:00
Conversation 12 Commits 6 Files Changed 10 +308 -128
IgorA commented 2025-03-30 17:06:17 +02:00
Member
Copy Link

Ftpc:

  • fix for bugs with buffers 'remote_list_buf', 'buf_buffer2'
  • fix stack leak when navigating files
  • change sorting of folders and files, clean code
  • added option to show|hide log
  • icons are taken from @reshare
  • added icons to the 'disconnect' and 'search' buttons
Ftpc: - fix for bugs with buffers 'remote_list_buf', 'buf_buffer2' - fix stack leak when navigating files - change sorting of folders and files, clean code - added option to show|hide log - icons are taken from @reshare - added icons to the 'disconnect' and 'search' buttons
IgorA added 2 commits 2025-03-30 17:06:20 +02:00
Ftpc: change sorting of folders and files, clean code 9d0cfa8dfb
Ftpc: added option to show|hide log
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 32s
Details
Build system / Build (pull_request) Successful in 5m25s
Details
94fcb0c49f
Leency commented 2025-03-31 01:20:58 +02:00
Owner
Copy Link

Tested the new ftpc

  • If you go into a folder, for some reason the list itself does not update until you move the mouse
  • Can you please add the same fix that you did in the right panel for the left one?
  • Is it possible to use a larger 8x16 font and @reshare icons for the list?
Tested the new ftpc - If you go into a folder, for some reason the list itself does not update until you move the mouse - Can you please add the same fix that you did in the right panel for the left one? - Is it possible to use a larger 8x16 font and @reshare icons for the list?
mxlgv requested review from Leency 2025-03-31 08:45:36 +02:00
mxlgv added the
PR
Request changes
 label 2025-03-31 08:45:50 +02:00
mxlgv changed title from ftpc-update to Ftpc: Update 2025-03-31 09:00:39 +02:00
mxlgv requested changes 2025-03-31 09:06:07 +02:00
Dismissed
mxlgv left a comment
Owner
Copy Link

Please update the copyright date.

Please update the copyright date.
mxlgv commented 2025-03-31 09:08:58 +02:00
Owner
Copy Link

@Leency @IgorA I suggest adding some versioning. Like Eolite. So that the user knows exactly what version he is using. What do you think?

@Leency @IgorA I suggest adding some versioning. Like Eolite. So that the user knows exactly what version he is using. What do you think?
IgorA force-pushed ftpc-update from 94fcb0c49f to 929a75f751 2025-03-31 21:00:10 +02:00 Compare
mxlgv approved these changes 2025-03-31 22:06:11 +02:00
Dismissed
IgorA commented 2025-03-31 22:07:33 +02:00
Author
Member
Copy Link

Please update the copyright date.

done

> Please update the copyright date. done
mxlgv added a new dependency 2025-03-31 22:53:36 +02:00
#188 Boxlib: the tree_list can use large fonts
mxlgv added
PR
Dependent
 and removed
PR
Request changes
 labels 2025-03-31 22:53:52 +02:00
IgorA added 1 commit 2025-04-01 17:34:28 +02:00
Ftpc: icons are taken from @reshare
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 24s
Details
Build system / Build (pull_request) Successful in 4m39s
Details
011e17de7c
IgorA dismissed mxlgv’s review 2025-04-01 17:34:29 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

IgorA force-pushed ftpc-update from 011e17de7c to a617d45245 2025-04-01 21:08:06 +02:00 Compare
mxlgv added
PR
Review required
 and removed
PR
Dependent
 labels 2025-04-03 08:39:32 +02:00
mxlgv approved these changes 2025-04-03 10:44:30 +02:00
Dismissed
IgorA added 1 commit 2025-04-03 21:02:47 +02:00
partial fix if function is not called
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 47s
Details
Build system / Build (pull_request) Successful in 12m46s
Details
8895f29b9a
IgorA dismissed mxlgv’s review 2025-04-03 21:02:48 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

IgorA force-pushed ftpc-update from 8895f29b9a to 012d58b9f6 2025-04-04 07:29:37 +02:00 Compare
IgorA force-pushed ftpc-update from 012d58b9f6 to f93ccccdbe 2025-04-04 15:00:14 +02:00 Compare
IgorA force-pushed ftpc-update from f93ccccdbe to 70b05aaa86 2025-04-04 17:01:35 +02:00 Compare
IgorA added 1 commit 2025-04-07 23:52:14 +02:00
Ftpc: fix for bugs with buffers 'remote_list_buf' and 'buf_buffer2'
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 1m16s
Details
Build system / Build (pull_request) Successful in 8m58s
Details
148a3292fb
IgorA added 1 commit 2025-04-08 23:26:29 +02:00
Ftpc: added icons to the 'disconnect' and 'search' buttons
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 36s
Details
Build system / Build (pull_request) Successful in 5m32s
Details
002824a2df
mxlgv requested changes 2025-04-10 16:37:36 +02:00
Dismissed
mxlgv left a comment
Owner
Copy Link

Crash when opening the pub/newlib folder on sourceware.org. Before your changes, this folder opens correctly

Crash when opening the `pub/newlib` folder on sourceware.org. Before your changes, this folder opens correctly
mxlgv commented 2025-04-10 16:41:42 +02:00
Owner
Copy Link

Crash when opening the pub/newlib folder on sourceware.org. Before your changes, this folder opens correctly

UPD: This is a floating bug. It also appears in the previous version.
New issue: #207

> Crash when opening the `pub/newlib` folder on sourceware.org. Before your changes, this folder opens correctly UPD: This is a floating bug. It also appears in the previous version. New issue: https://git.kolibrios.org/KolibriOS/kolibrios/issues/207
mxlgv approved these changes 2025-04-10 16:56:31 +02:00
Dismissed
mxlgv force-pushed ftpc-update from 002824a2df to eff4380b67 2025-04-10 16:59:48 +02:00 Compare
mxlgv dismissed mxlgv’s review 2025-04-10 16:59:48 +02:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

mxlgv approved these changes 2025-04-10 17:01:04 +02:00
Dismissed
mxlgv requested changes 2025-04-10 17:06:47 +02:00
Dismissed
mxlgv left a comment
Owner
Copy Link

Please update the description of changes in the PR text.

Please update the description of changes in the PR text.
mxlgv added
PR
Request changes
 and removed
PR
Review required
 labels 2025-04-10 17:07:03 +02:00
mxlgv approved these changes 2025-04-10 18:42:05 +02:00
mxlgv merged commit 75b6663ce0 into main 2025-04-10 18:47:17 +02:00
mxlgv deleted branch ftpc-update 2025-04-10 18:47:17 +02:00
mxlgv referenced this issue from a commit 2025-04-10 18:47:17 +02:00
Ftpc: Update (#185)
mxlgv added
PR
Ready to merge
 and removed
PR
Request changes
 labels 2025-04-10 18:47:26 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Leency
mxlgv
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
PR
Ready to merge
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Depends on
#188 Boxlib: the tree_list can use large fonts
KolibriOS/kolibrios
Reference: KolibriOS/kolibrios#185
No description provided.
Delete Branch "ftpc-update"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?