KolibriOS/kolibrios
13
14
Fork 12
Code Issues 113 Pull Requests 16 Actions Projects 1 Releases Wiki Activity

Eolite 5.31: #187

Merged
mxlgv merged 2 commits from eolite-5-31 into main 2025-03-31 22:40:58 +02:00
Conversation 5 Commits 2 Files Changed 5 +43 -55
Leency commented 2025-03-31 03:27:54 +02:00
Owner
Copy Link
  • fix: editbox edit text
  • fix: remove unnecessary editbox form delete popin
  • add: "Copy path" menu item
  • add: "Search" to a burger menu
- fix: editbox edit text - fix: remove unnecessary editbox form delete popin - add: "Copy path" menu item - add: "Search" to a burger menu
Screenshot_2.png
16 KiB
Screenshot_4.png
18 KiB
Screenshot_3.png
9.4 KiB
Screenshot_2.png Screenshot_4.png Screenshot_3.png
Leency added 1 commit 2025-03-31 03:27:57 +02:00
Eolite 5.31:
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 45s
Details
Build system / Build (pull_request) Failing after 1m8s
Details
e76175775a 
- fix: editbox edit text
- fix: remove unnecessary editbox form delete popin
- add: "Copy path" menu item
- add: "Search" to a burger menu
mxlgv requested review from rgimad 2025-03-31 08:22:15 +02:00
mxlgv added the
PR
Review required
 label 2025-03-31 08:25:33 +02:00
mxlgv requested changes 2025-03-31 08:53:47 +02:00
Dismissed
mxlgv left a comment
Owner
Copy Link

Your changes broke the build of another program:

imgedit.c(111)#4> 'edit_box_key_c' undefined.
imgedit.c(111)#5> ';' expected.
imgedit.c(111)#6> operator identifier expected.

Please, check. It could have broken something else.

Your changes broke the build of another program: ``` imgedit.c(111)#4> 'edit_box_key_c' undefined. imgedit.c(111)#5> ';' expected. imgedit.c(111)#6> operator identifier expected. ``` Please, check. It could have broken something else.
mxlgv added
PR
Request changes
 and removed
PR
Review required
 labels 2025-03-31 08:54:09 +02:00
mxlgv requested changes 2025-03-31 08:55:03 +02:00
Dismissed
programs/cmm/eolite/Eolite.c
@@ -1,9 +1,8 @@
//Leency, Veliant, Punk_Joker, PavelYakov & KolibriOS Team 2008-2022
//Leency, Veliant, Punk_Joker, PavelYakov & KolibriOS Team 2008-2025
//GNU GPL license.
mxlgv commented 2025-03-31 08:55:00 +02:00
Owner
Copy Link

Let's specify that the license is version 2.

Let's specify that the license is version 2.
mxlgv marked this conversation as resolved
Leency added 1 commit 2025-03-31 21:15:10 +02:00
use edit_box_key_c in a proper places
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 31s
Details
Build system / Build (pull_request) Successful in 7m31s
Details
c390bcedc0
mxlgv approved these changes 2025-03-31 22:08:11 +02:00
mxlgv commented 2025-03-31 22:10:55 +02:00
Owner
Copy Link

@rgimad please test build artifacts.

@rgimad please test build artifacts.
rgimad approved these changes 2025-03-31 22:21:00 +02:00
rgimad left a comment
Owner
Copy Link

tested build, works good

tested build, works good
mxlgv force-pushed eolite-5-31 from c390bcedc0 to d9b8a8edf2 2025-03-31 22:35:50 +02:00 Compare
mxlgv scheduled this pull request to auto merge when all checks succeed 2025-03-31 22:36:43 +02:00
mxlgv merged commit ff625706c0 into main 2025-03-31 22:40:58 +02:00
mxlgv referenced this issue from a commit 2025-03-31 22:40:59 +02:00
Eolite 5.31: (#187)
mxlgv added
PR
Ready to merge
 and removed
PR
Request changes
 labels 2025-04-02 22:15:07 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
mxlgv
rgimad
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
PR
Ready to merge
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#187
No description provided.
Delete Branch "eolite-5-31"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?