KolibriOS/kolibrios
13
14
Fork 12
Code Issues 113 Pull Requests 16 Actions Projects 1 Releases Wiki Activity

[Apps/Charsets] Updated to 0.4.2 #196

Merged
mxlgv merged 9 commits from charsets-update-0-4-1 into main 2025-04-10 16:24:19 +02:00
Conversation 6 Commits 9 Files Changed 4 +1077 -476
Burer commented 2025-04-03 12:10:00 +02:00
Owner
Copy Link

While code is fully finished and functional, now app binary doesn't fit into 512 x 3 bytes.
So I will be grateful to hear the opinion of more experienced assembler devs about how this program can be optimized by size.

While code is fully finished and functional, now app binary doesn't fit into 512 x 3 bytes. So I will be grateful to hear the opinion of more experienced assembler devs about how this program can be optimized by size.
Burer added the
PR
Review required
Kind
Feature
Category/Applications
 labels 2025-04-03 12:10:00 +02:00
Burer self-assigned this 2025-04-03 12:10:00 +02:00
Burer added 1 commit 2025-04-03 12:10:03 +02:00
[Apps/Charsets] Updated to 0.4.1
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 29s
Details
Build system / Build (pull_request) Failing after 39s
Details
c1101e65be
Burer requested review from dunkaist 2025-04-03 12:10:05 +02:00
Burer requested review from Leency 2025-04-03 12:10:06 +02:00
Burer requested review from mxlgv 2025-04-03 12:10:08 +02:00
Burer added 1 commit 2025-04-03 12:17:53 +02:00
[Apps/Charsets] Fixed Tupfile.lua
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 28s
Details
Build system / Build (pull_request) Successful in 5m42s
Details
666884ed27
mxlgv reviewed 2025-04-03 12:35:25 +02:00
programs/develop/charsets/charsets.asm Outdated
@@ -1,83 +1,177 @@
; SPDX-License-Identifier: GPL-2.0-only
; SPDX-FileCopyrightText: 2024-2025 KolibriOS Team
; SPDX-FileCopyrightText: 2025 KolibriOS Team
; FileContributor: UTF-8 to UTF-16 by Doczom
mxlgv commented 2025-04-03 12:35:25 +02:00
Owner
Copy Link

I found SPDX-FileContributor only in SPDX v2.3. In general, we use the SPDX standard only for license identification. But in principle, no one prohibits using this standard in this way.

I found `SPDX-FileContributor` only in SPDX v2.3. In general, we use the SPDX standard only for license identification. But in principle, no one prohibits using this standard in this way.
mxlgv commented 2025-04-03 14:49:20 +02:00
Owner
Copy Link

This tag only applies to the SPDX document. Write in a free format. But not like that, otherwise it’s not competent )

This tag only applies to the SPDX document. Write in a free format. But not like that, otherwise it’s not competent )
Burer commented 2025-04-03 16:16:06 +02:00
Author
Owner
Copy Link

Fixed, check, please.

Fixed, check, please.
Burer commented 2025-04-03 18:40:13 +02:00
Author
Owner
Copy Link

Fixed once again.

Fixed once again.
ace-dent commented 2025-04-03 23:17:13 +02:00
Member
Copy Link

Sorry... Reading the overview for SPDX 2.3 ... it seems the original was valid- but please correct me... I want to learn!? CopyrightText is a free format text field, but common use is just YYYY Name . In some (all?) jurisdictions, it is useful to give the range of years that Copyright is being claimed; start date to most recent date for legal reasons. FileContributor is also free format, single line.

; SPDX-License-Identifier: GPL-2.0-only
; SPDX-FileCopyrightText: Copyright 2024-2025 KolibriOS Team
; SPDX-FileContributorContributor: Burer  - Main code
; SPDX-FileContributorContributor: Doczom - UTF-8 to UTF-16 convertor
Sorry... Reading the overview for [SPDX 2.3 ](https://spdx.github.io/spdx-spec/v2.3/file-tags/) ... it seems the original was valid- but please correct me... I want to learn!? `CopyrightText` is a free format text field, but common use is just YYYY Name <optional email>. In some (all?) jurisdictions, it is useful to give the range of years that Copyright is being claimed; start date to most recent date for legal reasons. `FileContributor` is also free format, single line. ```asm ; SPDX-License-Identifier: GPL-2.0-only ; SPDX-FileCopyrightText: Copyright 2024-2025 KolibriOS Team ; SPDX-FileContributorContributor: Burer - Main code ; SPDX-FileContributorContributor: Doczom - UTF-8 to UTF-16 convertor ```
mxlgv commented 2025-04-04 09:32:25 +02:00
Owner
Copy Link

@ace-dent You are confusing tags from SPDX files with comments in the source code. In the source code you can only use: SPDX-License-Identifier: GPL-2.0-only. Here is an example: https://github.com/ARM-software/u-boot/blob/master/include/net/fastboot.h

@ace-dent You are confusing tags from SPDX files with comments in the source code. In the source code you can only use: SPDX-License-Identifier: GPL-2.0-only. Here is an example: https://github.com/ARM-software/u-boot/blob/master/include/net/fastboot.h
mxlgv commented 2025-04-04 09:44:08 +02:00
Owner
Copy Link

In fact, you can use the old version of the license entry. Like in the kernel. It's just that when that standard was adopted, there was only one GPL. Now there is also version 3. The SPDX identifier is good because it is a standard and is used in many open source projects. This avoids ambiguity, since a specific id refers to a specific license.

In fact, you can use the old version of the license entry. Like in the kernel. It's just that when that standard was adopted, there was only one GPL. Now there is also version 3. The SPDX identifier is good because it is a standard and is used in many open source projects. This avoids ambiguity, since a specific id refers to a specific license.
mxlgv marked this conversation as resolved
mxlgv requested changes 2025-04-03 12:43:25 +02:00
Dismissed
programs/develop/charsets/charsets.asm Outdated
@@ -659,3 +1191,3 @@
I_END:
rb 4096
rb 0
mxlgv commented 2025-04-03 12:42:24 +02:00
Owner
Copy Link

Don't need a stack? O_o

Don't need a stack? O_o
Burer marked this conversation as resolved
mxlgv reviewed 2025-04-03 13:08:33 +02:00
programs/develop/charsets/charsets.asm Outdated
@@ -75,3 +167,2 @@
mcall
.button_a: ; select character
mcall SF_TERMINATE_PROCESS
mxlgv commented 2025-04-03 12:55:44 +02:00
Owner
Copy Link
or eax, SF_TERMINATE_PROCESS
mcall

2 bytes less

Look at the macro mcall, maybe it’s already there

``` or eax, SF_TERMINATE_PROCESS mcall ``` 2 bytes less Look at the macro `mcall`, maybe it’s already there
Burer marked this conversation as resolved
Burer added 1 commit 2025-04-03 14:53:10 +02:00
[Apps/Charsets] Fixed license text and stack size
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 46s
Details
Build system / Build (pull_request) Successful in 7m17s
Details
fa4d0dd3ab
mxlgv reviewed 2025-04-03 14:56:05 +02:00
programs/develop/charsets/charsets.asm Outdated
@@ -39,1 +33,3 @@
; applications buttons.
mcall SF_WAIT_EVENT
cmp eax, 1
mxlgv commented 2025-04-03 14:56:05 +02:00
Owner
Copy Link

I think it is enough to check only al (- 4 byte).

I think it is enough to check only `al` (- 4 byte).
Burer marked this conversation as resolved
Burer added 1 commit 2025-04-03 16:15:49 +02:00
[Apps/Charsets] Fixes license
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 43s
Details
Build system / Build (pull_request) Successful in 10m55s
Details
a93c01c8a8
Burer added 2 commits 2025-04-03 18:27:00 +02:00
[Apps/Charsets] Fixed license once again 0ce5e667dd
[Apps/Charsets] To previous
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 53s
Details
Build system / Build (pull_request) Successful in 12m41s
Details
68275b7265
Burer added 1 commit 2025-04-04 07:48:18 +02:00
[Apps/Charsets] Updated to 0.4.2
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 33s
Details
Build system / Build (pull_request) Failing after 1m25s
Details
088ba2fd22
Burer changed title from WIP: [Apps/Charsets] Updated to 0.4.1 to [Apps/Charsets] Updated to 0.4.2 2025-04-04 07:48:32 +02:00
Burer added 1 commit 2025-04-04 08:02:42 +02:00
[Apps/Charsets] Fixed broken code
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 37s
Details
Build system / Build (pull_request) Successful in 13m6s
Details
2cbc845de1
Burer changed title from [Apps/Charsets] Updated to 0.4.2 to WIP [Apps/Charsets] Updated to 0.4.2 2025-04-04 09:07:47 +02:00
Burer commented 2025-04-04 09:08:56 +02:00
Author
Owner
Copy Link

Updated UX/UI (still WIP):

image.png
Updated UX/UI (still WIP): <img width="773" alt="image.png" src="attachments/26d6c61e-6e3f-410d-ba12-7469aa0da308">
image.png
51 KiB
mxlgv changed title from WIP [Apps/Charsets] Updated to 0.4.2 to WIP: [Apps/Charsets] Updated to 0.4.2 2025-04-04 10:54:27 +02:00
Burer added 1 commit 2025-04-04 11:17:06 +02:00
[Apps/Charsets] Fixed wrong charpage button redraw and added mising asm header options
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 27s
Details
Build system / Build (pull_request) Successful in 11m47s
Details
ce98c2db04
Burer changed title from WIP: [Apps/Charsets] Updated to 0.4.2 to [Apps/Charsets] Updated to 0.4.2 2025-04-04 11:42:21 +02:00
Burer force-pushed charsets-update-0-4-1 from ce98c2db04 to ef9c6ada19 2025-04-05 12:51:10 +02:00 Compare
mxlgv approved these changes 2025-04-10 16:08:40 +02:00
mxlgv merged commit df0c5d8f48 into main 2025-04-10 16:24:19 +02:00
mxlgv deleted branch charsets-update-0-4-1 2025-04-10 16:24:20 +02:00
mxlgv added
PR
Ready to merge
 and removed
PR
Review required
 labels 2025-04-10 16:25:52 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
dunkaist
Leency
mxlgv
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Category/Applications
Kind
Feature
PR
Ready to merge
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees Burer
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#196
No description provided.
Delete Branch "charsets-update-0-4-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?