KolibriOS/kolibrios
13
14
Fork 12
Code Issues 113 Pull Requests 16 Actions Projects 1 Releases Wiki Activity

TinyGL: #210

Merged
mxlgv merged 1 commits from tinygl-fix into main 2025-04-15 14:40:45 +02:00
Conversation 10 Commits 1 Files Changed 20 +272 -390
IgorA commented 2025-04-14 07:51:44 +02:00
Member
Copy Link

TinyGL:

  • The depth parameter in the glClearDepth function is now qword instead of dword.
  • Fixed bug with z-buffer (the edges were cut off incorrectly, the coordinates in it were from 0 to 1, but should be from -1 to 1)
  • Optimized array functions: glDrawArrays, glDrawElements

info3ds, info3ds_u, vox_tgl:

  • Removed unnecessary operations after fixing a bug with the z-buffer.
TinyGL: - The `depth` parameter in the `glClearDepth` function is now `qword` instead of `dword`. - Fixed bug with z-buffer (the edges were cut off incorrectly, the coordinates in it were from 0 to 1, but should be from -1 to 1) - Optimized array functions: `glDrawArrays`, `glDrawElements` info3ds, info3ds_u, vox_tgl: - Removed unnecessary operations after fixing a bug with the z-buffer.
IgorA added 1 commit 2025-04-14 07:51:47 +02:00
TinyGL:
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 40s
Details
Build system / Build (pull_request) Successful in 7m12s
Details
190936d799 
- fix function glClearDepth
- fix bug with z-buffer
- flag demo program rewritten
- fix array functions
mxlgv requested changes 2025-04-14 09:46:25 +02:00
Dismissed
mxlgv left a comment
Owner
Copy Link

Let's add your demo to ISO.

Let's add your demo to ISO.
mxlgv requested changes 2025-04-14 10:00:31 +02:00
Dismissed
mxlgv left a comment
Owner
Copy Link

Has the flag been rewritten? Judging by the changes, the program is new.

Has the flag been rewritten? Judging by the changes, the program is new.
programs/demos/flag/flag.asm Outdated
@@ -0,0 +1,311 @@
use32
mxlgv commented 2025-04-14 09:53:40 +02:00
Owner
Copy Link

Please add copyright:

; SPDX-License-Identifier: GPL-2.0-only
; Program - Brief description.
; Copyright (C) 2011-2025 KolibriOS team

You can use your name and email if you like

Please add copyright: ```asm ; SPDX-License-Identifier: GPL-2.0-only ; Program - Brief description. ; Copyright (C) 2011-2025 KolibriOS team ``` You can use your name and email if you like
IgorA force-pushed tinygl-fix from 190936d799 to 3e03bd4e10 2025-04-14 10:28:04 +02:00 Compare
mxlgv requested changes 2025-04-14 10:56:41 +02:00
Dismissed
mxlgv left a comment
Owner
Copy Link

We have an international project. Let's write comments in the code in English. At least new ones.

We have an international project. Let's write comments in the code in English. At least new ones.
mxlgv requested changes 2025-04-14 10:58:58 +02:00
Dismissed
mxlgv left a comment
Owner
Copy Link

let's split this PR into two commits: tinygl fixes and addition of your new program.

let's split this PR into two commits: tinygl fixes and addition of your new program.
programs/demos/flag/flag.asm Outdated
@@ -0,0 +1,315 @@
; SPDX-License-Identifier: GPL-2.0-only
; Program - demo program shows a flag with the inscription 'KolibriOS'
; Copyright (C) 2011-2025 KolibriOS team
mxlgv commented 2025-04-14 10:57:36 +02:00
Owner
Copy Link

If this is a new program, then leave only 2025.

If this is a new program, then leave only 2025.
mxlgv requested changes 2025-04-14 11:05:53 +02:00
Dismissed
mxlgv left a comment
Owner
Copy Link

I have seen that you have made changes to other programs as well. At least describe what these changes do (but it would be better to do it all in separate commits or PRs)

I have seen that you have made changes to other programs as well. At least describe what these changes do (but it would be better to do it all in separate commits or PRs)
IgorA force-pushed tinygl-fix from 3e03bd4e10 to 7ab4de091c 2025-04-14 11:51:22 +02:00 Compare
IgorA commented 2025-04-14 12:12:21 +02:00
Author
Member
Copy Link

changes in other programs ('info3ds', 'info3ds_u', 'vox_tgl', ...) are related to the correction of the z coordinate in the z buffer

changes in other programs ('info3ds', 'info3ds_u', 'vox_tgl', ...) are related to the correction of the z coordinate in the z buffer
IgorA force-pushed tinygl-fix from 7ab4de091c to 1a51e27df4 2025-04-14 20:36:31 +02:00 Compare
mxlgv approved these changes 2025-04-15 12:43:42 +02:00
Dismissed
mxlgv added the
PR
Ready to merge
 label 2025-04-15 12:43:56 +02:00
mxlgv scheduled this pull request to auto merge when all checks succeed 2025-04-15 13:11:58 +02:00
mxlgv requested changes 2025-04-15 13:33:14 +02:00
Dismissed
mxlgv left a comment
Owner
Copy Link
image.png

Part of the object is cut off. Is this normal behavior?

<img width="255" alt="image.png" src="attachments/65b0c9c5-d766-49ac-9c9d-829634ee5cb2"> Part of the object is cut off. Is this normal behavior?
image.png
49 KiB
mxlgv added
PR
Request changes
 and removed
PR
Ready to merge
 labels 2025-04-15 13:35:48 +02:00
IgorA commented 2025-04-15 13:44:17 +02:00
Author
Member
Copy Link
image.png

Part of the object is cut off. Is this normal behavior?
in the old version it was the same
image.png

> <img width="255" alt="image.png" src="attachments/65b0c9c5-d766-49ac-9c9d-829634ee5cb2"> > > Part of the object is cut off. Is this normal behavior? in the old version it was the same <img width="428" alt="image.png" src="attachments/0c821071-5d1c-41c5-92c9-651b6e4812d6">
image.png
18 KiB
mxlgv approved these changes 2025-04-15 14:31:31 +02:00
mxlgv force-pushed tinygl-fix from 1a51e27df4 to 8a069d3fa9 2025-04-15 14:31:48 +02:00 Compare
mxlgv added
PR
Ready to merge
 and removed
PR
Request changes
 labels 2025-04-15 14:31:56 +02:00
mxlgv merged commit 03cfdeb50f into main 2025-04-15 14:40:45 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
mxlgv
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
PR
Ready to merge
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#210
No description provided.
Delete Branch "tinygl-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?