KolibriOS/kolibrios
13
14
Fork 12
Code Issues 113 Pull Requests 16 Actions Projects 1 Releases Wiki Activity

Libraries (box_lib, buf2d, libimg, tinygl): optimize function import #231

Merged
Burer merged 1 commits from libraries-import-optimize into main 2025-07-14 08:20:37 +02:00
Conversation 7 Commits 1 Files Changed 24 +397 -1540
IgorA commented 2025-05-08 21:36:26 +02:00
Member
Copy Link

Libraries (box_lib, buf2d, libimg, tinygl): optimize function import

Рrograms updated:

  • gears, test3, test_glu1, test_glu2,
  • test_array1, textures0, textures1, textures2,
  • ctrldemo, editbox_ex, crypt_files, img_transform,
  • scrshoot, t_edit, cnc_control, cnc_editor
Libraries (box_lib, buf2d, libimg, tinygl): optimize function import Рrograms updated: - gears, test3, test_glu1, test_glu2, - test_array1, textures0, textures1, textures2, - ctrldemo, editbox_ex, crypt_files, img_transform, - scrshoot, t_edit, cnc_control, cnc_editor
IgorA added 1 commit 2025-05-08 21:36:29 +02:00
Libraries (box_lib, buf2d, libimg, tinygl): optimize function import
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 37s
Details
Build system / Build (pull_request) Successful in 4m50s
Details
a8675404e7 
Рrograms updated:
- info3ds: added resizing of the window with the figure
  and the list of vertices in the properties window

- info3ds_u, gears, test3, test_glu1, test_glu2,
- test_array1, textures0, textures1, textures2,
- ctrldemo, editbox_ex, crypt_files, img_transform,
- scrshoot, t_edit, cnc_control, cnc_editor
IgorA added the
Category/Applications
Category/Libraries
FASM
 labels 2025-05-11 15:25:32 +02:00
mxlgv added the
PR
Review required
 label 2025-05-14 21:08:51 +02:00
mxlgv commented 2025-05-14 21:21:52 +02:00
Owner
Copy Link

Do I understand correctly that only those functions that are used in the code are imported?

Do I understand correctly that only those functions that are used in the code are imported?
IgorA commented 2025-05-14 21:44:25 +02:00
Author
Member
Copy Link

Do I understand correctly that only those functions that are used in the code are imported?

That's right, only those functions that are used in the program are imported. That's why some programs have become smaller than they were.

> Do I understand correctly that only those functions that are used in the code are imported? That's right, only those functions that are used in the program are imported. That's why some programs have become smaller than they were.
dunkaist commented 2025-05-15 15:13:28 +02:00
Owner
Copy Link

We already have the shared /programs/dll.inc file included in some programs to help them with loading of dynamic libraries. Can we expand that single file instead of introducing two more files per each library? This is not a requirement, just a question if it's possible to avoid adding many similar files. I once cleaned some semi-duplicates, I'm afraid we can end up in a similar place with these import.inc and export.inc 2c778124e3

We already have the shared /programs/dll.inc file included in some programs to help them with loading of dynamic libraries. Can we expand that single file instead of introducing two more files per each library? This is not a requirement, just a question if it's possible to avoid adding many similar files. I once cleaned some semi-duplicates, I'm afraid we can end up in a similar place with these import.inc and export.inc https://git.kolibrios.org/KolibriOS/kolibrios/commit/2c778124e3a64f27f88c21c0578d18d597377578
IgorA commented 2025-05-15 23:46:55 +02:00
Author
Member
Copy Link

We already have the shared /programs/dll.inc file included in some programs to help them with loading of dynamic libraries. Can we expand that single file instead of introducing two more files per each library? This is not a requirement, just a question if it's possible to avoid adding many similar files. I once cleaned some semi-duplicates, I'm afraid we can end up in a similar place with these import.inc and export.inc 2c778124e3

The dll.inc file has a different format for describing the export table, not the same as in load_lib.mac. That's why I added two additional files, one with a list of functions and the other with the formation of the export table. At first I wanted to make a macro for forming the export table, and in that case the second file would not be needed. But I couldn't write such a macro because it requires a macro inside another macro.

> We already have the shared /programs/dll.inc file included in some programs to help them with loading of dynamic libraries. Can we expand that single file instead of introducing two more files per each library? This is not a requirement, just a question if it's possible to avoid adding many similar files. I once cleaned some semi-duplicates, I'm afraid we can end up in a similar place with these import.inc and export.inc https://git.kolibrios.org/KolibriOS/kolibrios/commit/2c778124e3a64f27f88c21c0578d18d597377578 The dll.inc file has a different format for describing the export table, not the same as in load_lib.mac. That's why I added two additional files, one with a list of functions and the other with the formation of the export table. At first I wanted to make a macro for forming the export table, and in that case the second file would not be needed. But I couldn't write such a macro because it requires a macro inside another macro.
IgorA force-pushed libraries-import-optimize from a8675404e7 to 1a2e3e7938 2025-05-17 21:08:00 +02:00 Compare
IgorA added a new dependency 2025-05-17 21:33:39 +02:00
#241 WIP: Info3ds: added resizing of the window with the figure
IgorA added a new dependency 2025-05-18 14:45:29 +02:00
#242 CtrlDemo: code cleaning, library import optimization
mxlgv requested changes 2025-05-20 22:47:39 +02:00
programs/develop/libraries/TinyGL/asm_fork/examples/textures0.asm Outdated
@@ -435,3 +435,2 @@
;--------------------------------------------------
align 4
import_tinygl:
sz_lib_init db 'lib_init',0
mxlgv commented 2025-05-20 22:47:32 +02:00
Owner
Copy Link

Let's try adding this to import.inc...

Let's try adding this to import.inc...
IgorA commented 2025-05-21 13:26:34 +02:00
Author
Member
Copy Link

moved declaration of sz_lib_init to file load_lib.mac

moved declaration of `sz_lib_init` to file load_lib.mac
Burer marked this conversation as resolved
mxlgv added
PR
Request changes
 and removed
PR
Review required
 labels 2025-05-20 22:47:57 +02:00
IgorA force-pushed libraries-import-optimize from 9f858e0265 to 5623b3510c 2025-05-21 00:42:34 +02:00 Compare
IgorA force-pushed libraries-import-optimize from 5623b3510c to 14c2c965c5 2025-05-21 06:10:20 +02:00 Compare
Doczom approved these changes 2025-07-13 14:31:55 +02:00
dunkaist approved these changes 2025-07-13 14:53:23 +02:00
Burer force-pushed libraries-import-optimize from 14c2c965c5 to 21658ef74c 2025-07-14 08:10:49 +02:00 Compare
Burer merged commit 1483ec8462 into main 2025-07-14 08:20:37 +02:00
Burer deleted branch libraries-import-optimize 2025-07-14 08:20:37 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
mxlgv
Doczom
dunkaist
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Category/Applications
Category/Libraries
FASM
PR
Request changes
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Blocks
#241 WIP: Info3ds: added resizing of the window with the figure
KolibriOS/kolibrios
#242 CtrlDemo: code cleaning, library import optimization
KolibriOS/kolibrios
Reference: KolibriOS/kolibrios#231
No description provided.
Delete Branch "libraries-import-optimize"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?