KolibriOS/kolibrios
13
14
Fork 12
Code Issues 113 Pull Requests 16 Actions Projects 1 Releases Wiki Activity

[Libs/HTTP] Added encoding for '+' and '&' #233

Merged
mxlgv merged 5 commits from http-asm-encoding-fix into main 2025-05-17 19:11:18 +02:00
Conversation 6 Commits 5 Files Changed 1 +10 -10
Burer commented 2025-05-10 10:41:13 +02:00
Owner
Copy Link

This is clone of original GitHub PR by @Saru2003:
https://github.com/KolibriOS/kolibrios/pull/34

That address GitHub issue opened by @MvDDD
https://github.com/KolibriOS/kolibrios/issues/33

Warning

I am not author of PR code and don't fully understand how it works, so detailed review is required.

This is clone of original GitHub PR by @Saru2003: https://github.com/KolibriOS/kolibrios/pull/34 That address GitHub issue opened by @MvDDD https://github.com/KolibriOS/kolibrios/issues/33 > [!WARNING] > I am not author of PR code and don't fully understand how it works, so detailed review is required.
Burer added 1 commit 2025-05-10 10:41:16 +02:00
[Libs/HTTP] Added encoding for '+' and '&'
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 22s
Details
Build system / Build (pull_request) Successful in 4m49s
Details
b0d28e6b8d
Burer requested review from Doczom 2025-05-10 10:41:17 +02:00
Burer requested review from dunkaist 2025-05-10 10:41:17 +02:00
Burer requested review from IgorA 2025-05-10 10:41:17 +02:00
b00bl1k requested changes 2025-05-10 11:54:37 +02:00
Dismissed
programs/develop/libraries/http/http.asm Outdated
@@ -2026,2 +2024,2 @@
dd 1 shl 27 + 1 shl 28 + 1 shl 29 + 1 shl 30 ;[\]^
dd 1 shl 0 + 1 shl 27 + 1 shl 28 + 1 shl 29 + 1 shl 31 ;`{|} DEL
dd 0xffffffff ; 00-1F
dd 1 shl 0 + 1 shl 2 + 1 shl 3 + 1 shl 5 + 1 shl 6 + 1 shl 11 + 1 shl 28 + 1 shl 30 ; "#%<>+&"
b00bl1k commented 2025-05-10 11:54:16 +02:00
Contributor
Copy Link
  • 1 shl 0 means char (space)
  • 1 shl 2 means "
  • 1 shl 3 means #
  • 1 shl 5 means %
  • 1 shl 6 means &
  • 1 shl 11 means +
  • 1 shl 28 means <
  • 1 shl 30 means >

so, the last " in the comment is redundant

- `1 shl 0` means ` ` char (space) - `1 shl 2` means `"` - `1 shl 3` means `#` - `1 shl 5` means `%` - `1 shl 6` means `&` - `1 shl 11` means `+` - `1 shl 28` means `<` - `1 shl 30` means `>` so, the last `"` in the comment is redundant
Burer marked this conversation as resolved
programs/develop/libraries/http/http.asm Outdated
@@ -2027,1 +2024,3 @@
dd 1 shl 0 + 1 shl 27 + 1 shl 28 + 1 shl 29 + 1 shl 31 ;`{|} DEL
dd 0xffffffff ; 00-1F
dd 1 shl 0 + 1 shl 2 + 1 shl 3 + 1 shl 5 + 1 shl 6 + 1 shl 11 + 1 shl 28 + 1 shl 30 ; "#%<>+&"
dd 1 shl 0 + 1 shl 2 + 1 shl 3 + 1 shl 5 + 1 shl 28 + 1 shl 30 ; "#%<>
b00bl1k commented 2025-05-10 11:49:13 +02:00
Contributor
Copy Link

this line is redundant

this line is redundant
Burer marked this conversation as resolved
Burer added 1 commit 2025-05-10 12:43:45 +02:00
[Libs/HTTP] Fix to previous
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 20s
Details
Build system / Build (pull_request) Successful in 4m52s
Details
c974c50a4b
IgorA commented 2025-05-10 13:50:15 +02:00
Member
Copy Link

;; Copyright (C) KolibriOS team 2004-2020. All rights reserved. ;;
year of update in the header

;; Copyright (C) KolibriOS team 2004-2020. All rights reserved. ;; year of update in the header
Burer added 1 commit 2025-05-11 14:41:47 +02:00
[Libs/HTTP] Updated copyright years
Some checks failed
Build system / Check kernel codestyle (pull_request) Has been cancelled
Details
Build system / Build (pull_request) Has been cancelled
Details
fab42d1f21
Burer added 1 commit 2025-05-12 10:35:09 +02:00
[Libs/HTTP] Add all delim chars from RFC 3986 standard
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 34s
Details
Build system / Build (pull_request) Failing after 2m16s
Details
e61c3064a8
Burer added 1 commit 2025-05-13 08:31:28 +02:00
[Libs/HTTP] Fixed binary numbers format
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 31s
Details
Build system / Build (pull_request) Successful in 5m6s
Details
ebeb16dd73
Doczom approved these changes 2025-05-13 09:21:09 +02:00
IgorA approved these changes 2025-05-13 09:28:06 +02:00
Burer changed title from WIP: [Libs/HTTP] Added encoding for '+' and '&' to [Libs/HTTP] Added encoding for '+' and '&' 2025-05-13 14:06:04 +02:00
mxlgv commented 2025-05-14 21:03:39 +02:00
Owner
Copy Link

How to test this?

How to test this?
b00bl1k approved these changes 2025-05-14 22:59:25 +02:00
b00bl1k left a comment
Contributor
Copy Link

Since only the PASTA app uses http_escape, I tried uploading part of the http.asm source code to check whether the data uploads without errors. It seems to be fine: https://dpaste.com/6SWM8FJMP

Since only the PASTA app uses http_escape, I tried uploading part of the http.asm source code to check whether the data uploads without errors. It seems to be fine: https://dpaste.com/6SWM8FJMP
mxlgv added
PR
Ready to merge
 and removed
PR
Review required
 labels 2025-05-17 18:38:44 +02:00
mxlgv force-pushed http-asm-encoding-fix from ebeb16dd73 to 65f87c7311 2025-05-17 18:38:55 +02:00 Compare
mxlgv merged commit c148987224 into main 2025-05-17 19:11:18 +02:00
mxlgv deleted branch http-asm-encoding-fix 2025-05-17 19:11:19 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
dunkaist
Doczom
IgorA
b00bl1k
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Category/Libraries
FASM
Kind
Enhancement
Priority
Medium
PR
Ready to merge
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#233
No description provided.
Delete Branch "http-asm-encoding-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?