KolibriOS/kolibrios
14
16
Fork 15
Code Issues 114 Pull Requests 14 Actions Projects 1 Releases Wiki Activity

Post-SVN clean up #244

Merged
Sweetbread merged 11 commits from ace-dent/kolibrios-gitea:PR-CleanupSVN into main 2025-05-20 15:36:15 +00:00
Conversation 4 Commits 11 Files Changed 133 +3548 -3531
ace-dent commented 2025-05-18 21:44:43 +00:00
Member
Copy Link
  • Move source code from trunk into program root directory.
  • Fix build and ASM files.
  • Translated a few RU comments to en_US.
  • Note: Line endings standardised from CRLF > LF, so best to view diffs with whitespace changes hidden.

(Work towards #75, point 3)

- Move source code from `trunk` into program root directory. - Fix build and ASM files. - Translated a few RU comments to en_US. - Note: Line endings standardised from `CRLF` > `LF`, so best to view diffs with whitespace changes hidden. (Work towards #75, point 3)
👍 1
ace-dent added the
Kind
Build
Priority
Low
Category/Applications labels 2025-05-18 21:44:43 +00:00
ace-dent added 1 commit 2025-05-18 21:44:50 +00:00
programs/period: Post-SVN clean up
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 26s
Details
Build system / Build (pull_request) Failing after 55s
Details
c6b957e002 
- Move source code from `trunk` into program root directory.
ace-dent added 1 commit 2025-05-18 22:00:39 +00:00
programs/calc: Post-SVN clean up
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 24s
Details
Build system / Build (pull_request) Failing after 53s
Details
b9d5a827b0 
- Move source code from `trunk` into program root directory.
ace-dent added 1 commit 2025-05-18 22:41:12 +00:00
programs/rtfread: Post-SVN clean up
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 22s
Details
Build system / Build (pull_request) Failing after 49s
Details
f31a0cb1f6 
- Move source code from `trunk` into program root directory.
ace-dent force-pushed PR-CleanupSVN from f31a0cb1f6 to e335765afa 2025-05-18 22:46:36 +00:00 Compare
ace-dent added 1 commit 2025-05-18 22:52:05 +00:00
programs/e80: Post-SVN clean up
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 28s
Details
Build system / Build (pull_request) Failing after 33s
Details
2509dec262 
- Move source code from `trunk` into program root directory.
ace-dent added 1 commit 2025-05-18 22:59:10 +00:00
programs/PrMK: Post-SVN clean up
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 23s
Details
Build system / Build (pull_request) Failing after 29s
Details
6c078b0ec5 
- Move source code from `trunk` into program root directory.
ace-dent force-pushed PR-CleanupSVN from 6c078b0ec5 to a5e72d7ea4 2025-05-18 23:53:47 +00:00 Compare
ace-dent force-pushed PR-CleanupSVN from a5e72d7ea4 to 047892f73d 2025-05-19 00:06:26 +00:00 Compare
ace-dent added 1 commit 2025-05-19 00:16:39 +00:00
programs/animage: Post-SVN clean up
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 22s
Details
Build system / Build (pull_request) Failing after 34s
Details
02725eb34b 
- Move source code from `trunk` into program root directory.
ace-dent added 1 commit 2025-05-19 00:30:00 +00:00
programs/kiv: Post-SVN clean up
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 25s
Details
Build system / Build (pull_request) Failing after 37s
Details
1bd68cec46 
- Move source code from `trunk` into program root directory.
ace-dent added 2 commits 2025-05-19 12:03:33 +00:00
programs/listplay: Post-SVN clean up 00da3a2ec9 
- Move source code from `trunk` into program root directory.
programs: Fix post-SVN tidying
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 22s
Details
Build system / Build (pull_request) Failing after 51s
Details
f9ef36d154 
- Fix include paths after moving files up a level, from old SVN trunk subdirs. e.g. `include '../../macros.inc’`.
- Add SPDX placeholder.
- Translated RU comments to en_US. (In some cases this removes codepage dependency).
- Note: Line endings standardised from `CRLF` > `LF`, so best to view diffs with whitespace changes hidden.
ace-dent added 1 commit 2025-05-19 13:32:43 +00:00
programs: Fix post-SVN tidying
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 28s
Details
Build system / Build (pull_request) Failing after 56s
Details
177c6817e5 
- Fix include paths after moving files up a level, from old SVN trunk subdirs. e.g. `include '../../macros.inc’`.
- Add SPDX placeholder.
- Translated a few RU comments to en_US.
- Note: Line endings standardised from `CRLF` > `LF`, so best to view diffs with whitespace changes hidden.
ace-dent force-pushed PR-CleanupSVN from 177c6817e5 to e2b9593a24 2025-05-19 13:58:06 +00:00 Compare
ace-dent commented 2025-05-19 16:29:12 +00:00
Author
Member
Copy Link

@Sweetbread - Submitting this PR for review- as I want to see whether it gets merged before spending more time on this.

@Sweetbread - Submitting this PR for review- as I want to see whether it gets merged before spending more time on this.
ace-dent changed title from WIP: Post-SVN clean up to Post-SVN clean up 2025-05-19 16:29:15 +00:00
ace-dent requested review from Burer 2025-05-19 16:29:30 +00:00
ace-dent requested review from dunkaist 2025-05-19 16:29:31 +00:00
ace-dent requested review from Leency 2025-05-19 16:29:31 +00:00
ace-dent added the
PR
Review required
 label 2025-05-19 16:45:28 +00:00
Sweetbread reviewed 2025-05-19 17:03:55 +00:00
programs/other/period/period.asm Outdated
@@ -0,0 +5,4 @@
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Periodic Table of Chemical Elements for KolibriOS
;; Dmitry Ivanovich Mendeleyev
Sweetbread commented 2025-05-19 16:57:29 +00:00
Owner
Copy Link

The original was in Genetive (by Dmitry Ivanovich). I think

Dmitry Ivanovich Mendeleyev's Periodic Table of Chemical Elements for KolibriOS

would be better

The original was in Genetive (by Dmitry Ivanovich). I think > Dmitry Ivanovich Mendeleyev's Periodic Table of Chemical Elements for KolibriOS would be better
ace-dent commented 2025-05-19 17:37:11 +00:00
Author
Member
Copy Link

Thanks for the better translation. Fixed in next commit.

Thanks for the better translation. Fixed in next commit.
ace-dent marked this conversation as resolved
programs/other/period/period.asm Outdated
@@ -0,0 +644,4 @@
add ebx,15
mcall
mov ecx,0x80000000 ;asciz, color !!!
Sweetbread commented 2025-05-19 17:02:01 +00:00
Owner
Copy Link

Droped i

Droped `i`
ace-dent commented 2025-05-19 17:37:02 +00:00
Author
Member
Copy Link

Great catch! Thanks. Fixed in next commit.

Great catch! Thanks. Fixed in next commit.
ace-dent marked this conversation as resolved
ace-dent added 1 commit 2025-05-19 17:42:59 +00:00
programs: Fix post-SVN tidying
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 23s
Details
Build system / Build (pull_request) Successful in 4m31s
Details
9f1237f278 
- Fix translation and typos. Thanks to feedback from @Sweetbread.
Sweetbread approved these changes 2025-05-19 17:48:27 +00:00
Burer approved these changes 2025-05-20 13:04:34 +00:00
Burer left a comment
Owner
Copy Link

Reviewed changes in files, can't see any obvious problems.
Also, if autobuild don't throw any errors - everything is okay, probably.

Reviewed changes in files, can't see any obvious problems. Also, if autobuild don't throw any errors - everything is okay, probably.
🎉 1
ace-dent added
PR
Ready to merge
 and removed
PR
Review required
 labels 2025-05-20 14:42:22 +00:00
Sweetbread force-pushed PR-CleanupSVN from 9f1237f278 to 8c90555142 2025-05-20 14:54:04 +00:00 Compare
Sweetbread merged commit 7e63294b5e into main 2025-05-20 15:36:15 +00:00
Sweetbread referenced this issue from a commit 2025-05-20 15:36:16 +00:00
Post-SVN clean up (#244)
ace-dent removed review request for dunkaist 2025-05-20 19:53:20 +00:00
ace-dent removed review request for Leency 2025-05-20 19:53:23 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sweetbread
Burer
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label Category/Applications
Kind
Build
Priority
Low
PR
Ready to merge
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#244
Delete Branch "ace-dent/kolibrios-gitea:PR-CleanupSVN"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?