KolibriOS/kolibrios
13
14
Fork 12
Code Issues 113 Pull Requests 16 Actions Projects 1 Releases Wiki Activity

drivers/usb: add usbother driver and usbdrv.dat config #253

Closed
Doczom wants to merge 6 commits from add_usbother into main
pull from: add_usbother
merge into: KolibriOS:main
Conversation 6 Commits 6 Files Changed 4 +743
Doczom commented 2025-05-23 21:31:45 +02:00
Owner
Copy Link

This driver loading usb drivers for class and for vendor and product id device.

This driver loading usb drivers for class and for vendor and product id device.
Doczom added 1 commit 2025-05-23 21:31:48 +02:00
drivers/usb: add usbother driver and usbdrv.dat config
Some checks failed
Build system / Check kernel codestyle (pull_request) Successful in 21s
Details
Build system / Build (pull_request) Failing after 1m11s
Details
d360daff80 
This driver loading usb drivers for class and for vendor and product id device.
Doczom added 1 commit 2025-05-23 21:42:28 +02:00
drivers/usb: fix auto build usbother
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 22s
Details
Build system / Build (pull_request) Successful in 4m25s
Details
1b49cbf4e4
Doczom added 1 commit 2025-05-23 21:46:23 +02:00
drivers/usb: fix auto build usbother (part 2)
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 21s
Details
Build system / Build (pull_request) Successful in 4m19s
Details
38781dfa3f
Doczom requested review from dunkaist 2025-05-24 04:09:04 +02:00
Doczom requested review from mxlgv 2025-05-24 04:09:04 +02:00
Doczom requested review from rgimad 2025-05-24 04:09:05 +02:00
Doczom added the
Category/Drivers
FASM
Kind
Feature
 labels 2025-05-24 04:12:09 +02:00
b00bl1k reviewed 2025-05-24 17:59:22 +02:00
drivers/usb/usbother/usbother.asm Outdated
@@ -0,0 +18,4 @@
include '../../struct.inc'
; USB device descriptor
struct DEVICE_DESCR
b00bl1k commented 2025-05-24 17:58:51 +02:00
Contributor
Copy Link

Do you think it would be better to move this to a separate common include file for USB drivers along with those structs? Right now, each USB driver has its own duplicated definitions:

  • usbstor: struct config_descr, struct interface_descr
  • usbhid: struct config_descr
  • usbftdi: struct usb_descr
Do you think it would be better to move this to a separate common include file for USB drivers along with those structs? Right now, each USB driver has its own duplicated definitions: - usbstor: struct config_descr, struct interface_descr - usbhid: struct config_descr - usbftdi: struct usb_descr
Doczom commented 2025-05-25 16:04:04 +02:00
Author
Owner
Copy Link

The common file for all USB drivers should be added as a separate PR.

The common file for all USB drivers should be added as a separate PR.
b00bl1k reviewed 2025-05-26 20:26:18 +02:00
drivers/usb/usbother/usbother.asm Outdated
@@ -0,0 +161,4 @@
cmp ecx, .count_ioctl_codes
jae .fail
jmp dword[.table_subfunction + ecx]
b00bl1k commented 2025-05-26 20:17:36 +02:00
Contributor
Copy Link

ecx * 4?

`ecx * 4`?
👍 1
Doczom commented 2025-06-06 20:21:43 +02:00
Author
Owner
Copy Link

fixed

fixed
Doczom added 1 commit 2025-06-06 13:35:19 +02:00
drivers/usb: fix usbother driver
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 1m8s
Details
Build system / Build (pull_request) Successful in 7m47s
Details
10b25bc579 
Added array of endpoints in DRV_CONTEXT and save params for ioctl API.
Doczom removed review request for dunkaist 2025-06-06 15:26:43 +02:00
Doczom removed review request for mxlgv 2025-06-06 15:26:43 +02:00
Doczom removed review request for rgimad 2025-06-06 15:26:44 +02:00
Doczom requested review from dunkaist 2025-06-06 20:20:24 +02:00
Doczom requested review from mxlgv 2025-06-06 20:20:26 +02:00
Doczom requested review from rgimad 2025-06-06 20:20:26 +02:00
Doczom force-pushed add_usbother from 10b25bc579 to 4813b67aaa 2025-06-08 10:12:02 +02:00 Compare
rgimad refused to review 2025-06-11 19:51:09 +02:00
Burer added 1 commit 2025-06-12 08:17:35 +02:00
[drivers/usbother] grammar fixes in comments
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 1m29s
Details
Build system / Build (pull_request) Successful in 8m54s
Details
29ce07d8e3
Burer added 1 commit 2025-06-13 21:07:50 +02:00
[drivers/usbother]: more grammar fixes in comments
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 1m17s
Details
Build system / Build (pull_request) Successful in 9m16s
Details
ffa69689c6
Doczom removed review request for mxlgv 2025-06-15 09:58:55 +02:00
Doczom requested review from IgorA 2025-06-15 09:58:57 +02:00
Doczom requested review from sdongles 2025-06-15 09:58:57 +02:00
dunkaist approved these changes 2025-06-16 22:32:45 +02:00
Doczom commented 2025-07-10 19:57:48 +02:00
Author
Owner
Copy Link

If you don't mind, I'll add this query to the main thread tomorrow.

If you don't mind, I'll add this query to the main thread tomorrow.
Doczom force-pushed add_usbother from ffa69689c6 to 7db3d22a37 2025-07-10 20:08:34 +02:00 Compare
Burer approved these changes 2025-07-11 07:37:08 +02:00
Burer commented 2025-07-12 06:56:35 +02:00
Owner
Copy Link

Merged in e8121c66f8.

Merged in e8121c66f8.
Burer closed this pull request 2025-07-12 06:56:40 +02:00
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 35s
Required
Details
Build system / Build (pull_request) Successful in 6m2s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
IgorA
sdongles
dunkaist
Burer
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Category/Drivers
FASM
Kind
Feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#253
No description provided.
Delete Branch "add_usbother"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?