KolibriOS/kolibrios
9
3
Fork 6
Code Issues 73 Pull Requests 2 Projects Releases Activity

Remove or re-purpose __REV macro #68

New Issue
Open
opened 2024-05-31 19:20:43 +02:00 by ace-dent · 0 comments
ace-dent commented 2024-05-31 19:20:43 +02:00
Member
Copy Link

On migrating from SVN --> git...

We no longer use $Revision$ macro which has already been removed.
We need to either remove or re-purpose the supporting __REV macro, in the following:

Please consider wording changes (e.g. how we describe the version & build on boot screen).
We should also comment if any remaining code has a hard dependancy on the VCS (to future proof possible migrations).

On migrating from SVN --> git... We no longer use `$Revision$` macro which has already been removed. We need to either remove or re-purpose the supporting `__REV` macro, in the following: - [ ] [bootstr.inc](https://git.kolibrios.org/KolibriOS/kolibrios/src/commit/f80a8960b0f526a2baa6bd57f323e0d87723805d/kernel/trunk/boot/bootstr.inc#L32-L43). - [ ] [kernel.asm](https://git.kolibrios.org/KolibriOS/kolibrios/src/commit/f80a8960b0f526a2baa6bd57f323e0d87723805d/kernel/trunk/kernel.asm#L2289-L2295) and [here](https://git.kolibrios.org/KolibriOS/kolibrios/src/commit/f80a8960b0f526a2baa6bd57f323e0d87723805d/kernel/trunk/kernel.asm#L4467). - [ ] [macros.inc](https://git.kolibrios.org/KolibriOS/kolibrios/src/commit/f80a8960b0f526a2baa6bd57f323e0d87723805d/kernel/trunk/macros.inc#L8-L16) Please consider wording changes (e.g. how we describe the version & build on boot screen). We should also comment if any remaining code has a hard dependancy on the VCS (to future proof possible migrations).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
C

   
Category/Applications

   
Category/Drivers

   
Category/General

   
Category/Kernel

   
Category/Libraries

   
Eolite

   
FASM

   
FS

   
HLL

   
Influence/Settings

   
Influence/Text/TYPO

   
IRCC

   
Kernel
  
Kind
Breaking
Breaking change that won't be backward compatible

  
Kind
Bug
Something is not working

  
Kind
Build

  
Kind
Documentation
Documentation changes

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Security
This is security issue

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Kind
Bug
Kind
Build
Kind
Documentation
Kind
Enhancement
Kind
Feature
Kind
Security
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#68
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?