KolibriOS/kolibrios
13
14
Fork 12
Code Issues 113 Pull Requests 16 Actions Projects 1 Releases Wiki Activity

Calc+ v1.0 #189

Merged
mxlgv merged 29 commits from calc-plus-v1.0 into main 2025-04-14 19:47:01 +02:00
Conversation 23 Commits 29 Files Changed 15 +4 -4
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 3d5ea64dee - Show all commits

8
programs/other/calcplus/calcplus.asm
View File

@@ -73,7 +73,7 @@ edb1 edit_box 0, 14, 12, 0xFFFFFF, 0x94AECE, 0xFFC90E, 0xCACACA, 0x10
START:
mov [ans.buffer], dword " = 0"
mov [ans.size], 3 * 8 + 9
mov [ans.size], 4 * 8 + 9
mcall SF_SET_EVENTS_MASK, EVM_REDRAW + EVM_KEY + EVM_BUTTON + EVM_MOUSE
@@ -306,7 +306,7 @@ calc:
cmp [error_n], 0
jne .error
mov [ans.buffer], word "= "
mov [ans.buffer], dword " = "
stdcall convert_to_str, eax, ans.buffer + 2
add eax, 2
@@ -666,7 +666,7 @@ endp
if lang eq ru_RU
engineering_str db "Engineering calc"
engineering_str db "Инженерный режим"
engineering_len = 16
else if lang eq es_ES
@@ -675,7 +675,7 @@ else if lang eq es_ES
engineering_len = 16
else
engineering_str cp866 "Инженерный режим"
engineering_str cp866 "Engineering calc"
engineering_len = 16
Burer marked this conversation as resolved Outdated
dunkaist commented 2025-04-13 20:30:58 +02:00
Outdated
Review
Copy Link

Hardcoding a string length is error prone. You can write 'engineering_len = $ - engineering_str' here. If you prefer macros, you can also use macros sz or lsz from macros.inc. For example, zsea uses lsz.

Hardcoding a string length is error prone. You can write 'engineering_len = $ - engineering_str' here. If you prefer macros, you can also use macros sz or lsz from macros.inc. For example, zsea uses lsz.
endf