KolibriOS/kolibrios
12
4
Fork 12
Code Issues 78 Pull Requests 5 Projects Releases Activity

WIP: refactor/links #77

Draft
Sweetbread wants to merge 2 commits from Sweetbread/kolibrios:refactor/links into main
pull from: Sweetbread/kolibrios:refactor/links
merge into: KolibriOS:main
Conversation 0 Commits 2 Files Changed 6 +4 -5
4 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 578eb6072c - Show all commits

2
kernel/branches/kolibri-ahci/asmxygen.py
View File

@ -17,7 +17,7 @@ print_stats = False
enable_warnings = True enable_warnings = True
# Constants # Constants
link_root = "http://websvn.kolibrios.org/filedetails.php?repname=Kolibri+OS&path=/kernel/trunk" link_root = "https://git.kolibrios.org/KolibriOS/kolibrios/src/branch/main/kernel/trunk"
# fasm keywords # fasm keywords
keywords = [ keywords = [

2
kernel/branches/kolibri-lldw/asmxygen.py
View File

@ -17,7 +17,7 @@ print_stats = False
enable_warnings = True enable_warnings = True
# Constants # Constants
link_root = "http://websvn.kolibrios.org/filedetails.php?repname=Kolibri+OS&path=/kernel/trunk" link_root = "https://git.kolibrios.org/KolibriOS/kolibrios/src/branch/main/kernel/trunk"
# fasm keywords # fasm keywords
keywords = [ keywords = [

2
kernel/branches/kolibrios-pe-clevermouse/asmxygen.py
View File

@ -17,7 +17,7 @@ print_stats = False
enable_warnings = True enable_warnings = True
# Constants # Constants
link_root = "http://websvn.kolibrios.org/filedetails.php?repname=Kolibri+OS&path=/kernel/trunk" link_root = "https://git.kolibrios.org/KolibriOS/kolibrios/src/branch/main/kernel/trunk"
# fasm keywords # fasm keywords
keywords = [ keywords = [

3
kernel/trunk/asmxygen.py
View File

@ -1038,8 +1038,7 @@ def handle_file(handled_files, asm_file_name, subdir="."):
get_declarations(asm_file_contents, asm_file_name) get_declarations(asm_file_contents, asm_file_name)
if __name__ == "__main__": if __name__ == "__main__":
link_root = "http://websvn.kolibrios.org/filedetails.php" link_root = "https://git.kolibrios.org/KolibriOS/kolibrios/src/branch/main/kernel/trunk"
ace-dent commented 2024-06-10 14:01:14 +02:00
Review
Copy Link

Looking good. As per my comment #65, please also change here, using the Gitea hyperlink #Lx to highlight specific line number(s).

Also we should add a comment, like: # This hardcoded link is specific to the Version Control System currently in use (Gitea). This would help any future migrations.

Looking good. As per my comment #65, please also change [here](https://github.com/KolibriOS/kolibrios/blob/f4fd3f6ea049dc4c7c0fd3b9bd41fd3377e92e0e/kernel/trunk/asmxygen.py#L401-L403), using the Gitea hyperlink `#Lx` to highlight specific line number(s). Also we should add a comment, like: `# This hardcoded link is specific to the Version Control System currently in use (Gitea)`. This would help any future migrations.
Sweetbread commented 2024-06-10 14:03:56 +02:00
Review
Copy Link

As per my comment #65, please also change here

That's why the PR is WIP

Also we should add a comment

I'm not sure. For future migrations it's possible to look into Changed files sections in this PR

> As per my comment #65, please also change here That's why the PR is WIP > Also we should add a comment I'm not sure. For future migrations it's possible to look into Changed files sections in this PR
👍 1
link_root += "?repname=Kolibri+OS&path=/kernel/trunk"
# Dict where an identifier is assicoated with a string # Dict where an identifier is assicoated with a string
# The string contains characters specifying flags # The string contains characters specifying flags