From fac0425ac011241ca5be2b5a8563fb3cca8a3fe1 Mon Sep 17 00:00:00 2001 From: nitinsoni4115 Date: Sat, 16 May 2026 08:37:35 +0000 Subject: [PATCH] games/invaders: review graphical assets in code (fix #236) (#394) - Remove the unused `gif_bullet2` file definition - Remove the unused `gif_bullet2` `decodeimg` call - Remove the unused `img_bullet2` memory allocation - Fix `gif_menu4.size` to use `gif_menu4` - Comment out the unused `img_alienpiece` allocation - Preserve `img_bullet` from `bullet2.gif` for bullet rendering --------- Co-authored-by: Burer Co-authored-by: nitinsoni4115 Reviewed-on: https://git.kolibrios.org/KolibriOS/kolibrios/pulls/394 Reviewed-by: Burer Co-authored-by: nitinsoni4115 Co-committed-by: nitinsoni4115 --- programs/games/invaders/invaders.asm | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/programs/games/invaders/invaders.asm b/programs/games/invaders/invaders.asm index e92732980..90ffb066d 100644 --- a/programs/games/invaders/invaders.asm +++ b/programs/games/invaders/invaders.asm @@ -269,7 +269,6 @@ exit: call draw_window decodeimg gif_bullet,gif_bullet.size,img_bullet - decodeimg gif_bullet2,gif_bullet2.size,img_bullet2 decodeimg gif_ship,gif_ship.size,img_ship decodeimg gif_enemy1,gif_enemy1.size,img_enemy1 decodeimg gif_enemy2,gif_enemy2.size,img_enemy2 @@ -1468,8 +1467,6 @@ enemy_img_list: gif_bullet file 'bullet2.gif' .size = $ - gif_bullet -gif_bullet2 file 'bullet2.gif' - .size = $ - gif_bullet2 gif_ship file 'ship.gif' .size = $ - gif_ship gif_enemy1 file 'enemy1.gif' @@ -1488,10 +1485,10 @@ gif_menu1 file 'menu1.gif' .size = $ - gif_menu1 gif_menu2 file 'menu2.gif' .size = $ - gif_menu2 -gif_menu3 file 'menu3.gif' - .size = $ - gif_menu3 -gif_menu4 file 'menu4.gif' - .size = $ - gif_menu3 +gif_menu3 file 'menu3.gif' + .size = $ - gif_menu3 +gif_menu4 file 'menu4.gif' + .size = $ - gif_menu4 gif_logo file 'logo.gif' .size = $ - gif_logo gif_pause file 'pause.gif' @@ -1532,7 +1529,6 @@ IM_END: STARS rb STARS_*5 img_bullet rb BULLET_X*BULLET_Y*3+8 -img_bullet2 rb BULLET_X*BULLET_Y*3+8 img_ship rb SHIP_X*SHIP_Y*3+8 img_enemy1 rb ENEMY_X*ENEMY_Y*3+8 img_enemy2 rb ENEMY_X*ENEMY_Y*3+8 @@ -1553,9 +1549,9 @@ img_smallfont rb 20*312*3+8 img_bigfont rb 28*520*3+8 img_numbers rb 16*200*3+8 -img_char rb 28*20*3+8 -img_alienpiece rb ALIEN_X*ALIEN_Y*3+8 +img_char rb 28*20*3+8 +;img_alienpiece rb ALIEN_X*ALIEN_Y*3+8 + +highscorebuffer rb 1024 -highscorebuffer rb 1024 - -I_END: \ No newline at end of file +I_END: