KolibriOS/kolibrios
15
21
Fork 36
Code Issues 129 Pull Requests 31 Actions 1 Projects 1 Releases Wiki Activity

Fix kolibri_libini.h #120

Closed
Egor00f wants to merge 3 commits from (deleted):main into main
pull from: (deleted):main
merge into: KolibriOS:main
Conversation 4 Commits 3 Files Changed 1 +48 -9
Egor00f commented 2025-03-07 15:35:26 +00:00
Contributor
Copy Link

Correction of the set of function arguments(The set of arguments of a pair of functions does not match) and addition of function descriptions.

Correction of the set of function arguments(The set of arguments of a pair of functions does not match) and addition of function descriptions.
Egor00f added 1 commit 2025-03-07 15:35:29 +00:00
fix kolibri_libini.h
Some checks failed
Build system / Check kernel codestyle (pull_request) Has been cancelled
Details
Build system / Build (pull_request) Has been cancelled
Details
e6646f8f5e 
Correction of the set of function arguments and addition of function descriptions
dunkaist commented 2025-03-08 00:02:57 +00:00
Owner
Copy Link

As I understand, no programs in the repo are including the file so far. Hence there is no easy way to check if the changes are correct. At the same time, nothing is broken for sure.

As I understand, no programs in the repo are including the file so far. Hence there is no easy way to check if the changes are correct. At the same time, nothing is broken for sure.
dunkaist reviewed 2025-03-08 00:03:47 +00:00
contrib/C_Layer/INCLUDE/kolibri_libini.h Outdated
@@ -16,0 +46,4 @@
/*
Read the hotkey.
The string for ini_get_shortcut is an arbitrary number of modifiers Ctrl/Alt/Shift/LCtrl/LAlt/LShift/RCtrl/RAlt/RShift, followed by a Latin letter/number/key name (proper names are Home, End, PgUp, PgDn, Ins=Insert, Del=Delete, Tab, Plus, Esc, Enter, Backspace, Space, Left, Right, Up, Down). The string can be written with any case of characters. Parts are either written together or separated by a plus. For example: Ctrl+Alt+Backspace, RCtrl+RShift, ShiftA, f10, shiftalt5
dunkaist commented 2025-03-08 00:03:47 +00:00
Owner
Copy Link

This line is insanely long.

This line is insanely long.
mxlgv reviewed 2025-03-08 00:15:11 +00:00
contrib/C_Layer/INCLUDE/kolibri_libini.h
@@ -16,0 +11,4 @@
/*
Loop through the keys in the section, calling the user-defined function for each one.
*/
extern uint32_t(*LIBINI_enum_keys)(const char* f_name, const char* sec_name, void(*)(const char* f_name, const char* sec_name, const char* key_name, const char* key_value)) __attribute__((__stdcall__));
mxlgv commented 2025-03-08 00:15:02 +00:00
Owner
Copy Link
  • Very long lines, reduce them to at least 100.
  • This style of commentary creates unnecessary space.
  • Comments are too short.
  • The names of the functions actually fully reflect what they do.
- Very long lines, reduce them to at least 100. - This style of commentary creates unnecessary space. - Comments are too short. - The names of the functions actually fully reflect what they do.
Egor00f added 1 commit 2025-03-08 07:05:24 +00:00
abbreviation abbreviation of a long comment
Some checks failed
Build system / Check kernel codestyle (pull_request) Has been cancelled
Details
Build system / Build (pull_request) Has been cancelled
Details
9cc195cae1
Egor00f added 1 commit 2025-03-08 07:06:29 +00:00
merge upstream
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 29s
Details
Build system / Build (pull_request) Successful in 8m22s
Details
df48d2034d
mxlgv requested review from mxlgv 2025-03-15 21:18:20 +00:00
mxlgv requested changes 2025-03-15 21:19:47 +00:00
mxlgv left a comment
Owner
Copy Link

Correct the code according to the reviewer's comments

Correct the code according to the reviewer's comments
mxlgv added the
PR
Request changes
 label 2025-03-15 21:20:19 +00:00
Sweetbread closed this pull request 2025-04-11 22:54:22 +00:00
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 29s
Required
Details
Build system / Build (pull_request) Successful in 8m22s
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
dunkaist
mxlgv
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
PR
Request changes
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#120
Delete Branch "(deleted):main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?