KolibriOS/kolibrios
15
21
Fork 36
Code Issues 129 Pull Requests 31 Actions 1 Projects 1 Releases Wiki Activity

Apps/tube: Improved code style and readability #134

Merged
mxlgv merged 2 commits from fixed-tube-demo-codestyle into main 2025-03-12 08:37:24 +00:00
Conversation 3 Commits 2 Files Changed 6 +248 -276
mxlgv commented 2025-03-11 23:53:42 +00:00
Owner
Copy Link
No description provided.
mxlgv added 2 commits 2025-03-11 23:53:45 +00:00
Apps/tube: Deleted trunk dir. Files moved abb7442055 
The trunk directory is no longer required. This is a rudiment of SVN
Apps/tube: Improved code style and readability
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 34s
Details
Build system / Build (pull_request) Successful in 5m20s
Details
c77ec910a2 
- Magic numbers are replaced with constants;
- Added copyrights and source to the original;
- Removed unnecessary *.bat files.

Co-authored-by: Max Logaev <maxlogaev@proton.me>
mxlgv requested review from IgorA 2025-03-11 23:54:10 +00:00
mxlgv reviewed 2025-03-12 00:03:23 +00:00
programs/demos/tube/tube.asm Outdated
@@ -0,0 +88,4 @@
loop ROTATE
fld st1
db 0xdc,0xc8 ;fmul st0,st ?
mxlgv commented 2025-03-11 23:59:30 +00:00
Author
Owner
Copy Link

Is this still relevant?

Is this still relevant?
mxlgv commented 2025-03-12 07:17:48 +00:00
Author
Owner
Copy Link

fasm generates a different D8 C8 opcode. But in fact, if i = 0, then it is the same thing. It's just that fasm and nasm generate different instructions:

FMUL ST(0), ST(i)	D8 C8+i		Multiply ST(0) by ST(i) and store result in ST(0).
FMUL ST(i), ST(0)	DC C8+i		Multiply ST(i) by ST(0) and store result in ST(i).

See: https://shell-storm.org/x86doc/

fasm generates a different `D8 C8` opcode. But in fact, if i = 0, then it is the same thing. It's just that fasm and nasm generate different instructions: ``` FMUL ST(0), ST(i) D8 C8+i Multiply ST(0) by ST(i) and store result in ST(0). FMUL ST(i), ST(0) DC C8+i Multiply ST(i) by ST(0) and store result in ST(i). ``` See: https://shell-storm.org/x86doc/
programs/demos/tube/tube.asm Outdated
@@ -0,0 +90,4 @@
fld st1
db 0xdc,0xc8 ;fmul st0,st ?
fld st1
db 0xdc,0xc8 ;fmul st0,st ?
mxlgv commented 2025-03-11 23:59:38 +00:00
Author
Owner
Copy Link

Is this still relevant?

Is this still relevant?
mxlgv commented 2025-03-12 07:19:59 +00:00
Author
Owner
Copy Link

#134 (comment)

https://git.kolibrios.org/KolibriOS/kolibrios/pulls/134#issuecomment-1185
programs/demos/tube/tube.asm
@@ -0,0 +118,4 @@
mov al,-48
STORE_1:
; add al,[ebx+esi+0x80000]
mxlgv commented 2025-03-11 23:59:59 +00:00
Author
Owner
Copy Link

Is this really necessary?

Is this really necessary?
mxlgv commented 2025-03-12 07:20:04 +00:00
Author
Owner
Copy Link

#134 (comment)

https://git.kolibrios.org/KolibriOS/kolibrios/pulls/134#issuecomment-1185
IgorA commented 2025-03-12 07:25:05 +00:00
Member
Copy Link

Это был код, который возможно включал в программе какой-либо режим работы. Оставил на всякий случай, может кто-нибудь поймет что оно раньше делало.

Это был код, который возможно включал в программе какой-либо режим работы. Оставил на всякий случай, может кто-нибудь поймет что оно раньше делало.
mxlgv marked this conversation as resolved
programs/demos/tube/tube.asm Outdated
@@ -0,0 +183,4 @@
ret
align 4
db 41,0,0xC3,0x3C
mxlgv commented 2025-03-11 23:58:28 +00:00
Author
Owner
Copy Link

@IgorA What is this for?

@IgorA What is this for?
IgorA commented 2025-03-12 07:21:46 +00:00
Member
Copy Link

Судя по коду это 4-х байтное число с плавающей точкой, потому как оно грузится в fpu инструкции. Но из это-го же места в другом месте кода грузится также 2 байта. Потому однозначно не понятно как его сделать или перевести во float или оставить как 4 отдельных байта.

Судя по коду это 4-х байтное число с плавающей точкой, потому как оно грузится в fpu инструкции. Но из это-го же места в другом месте кода грузится также 2 байта. Потому однозначно не понятно как его сделать или перевести во float или оставить как 4 отдельных байта.
mxlgv commented 2025-03-12 08:02:38 +00:00
Author
Owner
Copy Link

It's clear. Thank you

It's clear. Thank you
mxlgv marked this conversation as resolved
mxlgv commented 2025-03-12 00:35:42 +00:00
Author
Owner
Copy Link

Add Copyright (C) 2001 Miloš Bazelides <baze@stonline.sk>

Add `Copyright (C) 2001 Miloš Bazelides <baze@stonline.sk>`
mxlgv force-pushed fixed-tube-demo-codestyle from c77ec910a2 to 61277f8822 2025-03-12 08:04:43 +00:00 Compare
IgorA approved these changes 2025-03-12 08:31:39 +00:00
mxlgv merged commit 61277f8822 into main 2025-03-12 08:37:24 +00:00
mxlgv deleted branch fixed-tube-demo-codestyle 2025-03-12 08:37:30 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
mxlgv
IgorA
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#134
Delete Branch "fixed-tube-demo-codestyle"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?