KolibriOS/kolibrios
15
21
Fork 36
Code Issues 129 Pull Requests 31 Actions 2 Projects 1 Releases Wiki Activity

Update firework demo #151

Merged
mxlgv merged 2 commits from update-firework into main 2025-03-15 20:59:30 +00:00
Conversation 2 Commits 2 Files Changed 3 +175 -104
IgorA commented 2025-03-15 17:56:27 +00:00
Member
Copy Link

Apps/firework: Improved code style and readability
Apps/firework: Added support for window resizing

Apps/firework: Improved code style and readability Apps/firework: Added support for window resizing
IgorA added 2 commits 2025-03-15 17:56:29 +00:00
Apps/firework: Improved code style and readability fbd99c82a4
Apps/firework: Added support for window resizing
All checks were successful
Build system / Check kernel codestyle (pull_request) Successful in 40s
Details
Build system / Build (pull_request) Successful in 5m35s
Details
10efb47ee8
mxlgv changed title from update-firework to Update firework demo 2025-03-15 20:02:59 +00:00
mxlgv requested changes 2025-03-15 20:07:24 +00:00
Dismissed
programs/demos/firework/build.bat Outdated
@@ -0,0 +1,2 @@
@fasm.exe -m 16384 firework.asm firework.kex
mxlgv commented 2025-03-15 20:05:08 +00:00
Owner
Copy Link

Let's not add our own build scripts. Tup file solves this

Please do this using git commit --amend to avoid creating unnecessary commits.

Let's not add our own build scripts. Tup file solves this Please do this using `git commit --amend` to avoid creating unnecessary commits.
mxlgv marked this conversation as resolved
programs/demos/firework/firework.asm Outdated
@@ -0,0 +1,520 @@
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
; A firework demo
; Copyright (C) 2010-2025 KolibriOS team
mxlgv commented 2025-03-15 20:07:16 +00:00
Owner
Copy Link

Please correct this:

; SPDX-License-Identifier: GPL-2.0-only
; A firework demo
; Copyright (C) 2010-2025 KolibriOS team

Please do this using git commit --amend to avoid creating unnecessary commits.

Please correct this: ``` ; SPDX-License-Identifier: GPL-2.0-only ; A firework demo ; Copyright (C) 2010-2025 KolibriOS team ``` Please do this using `git commit --amend` to avoid creating unnecessary commits.
mxlgv marked this conversation as resolved
IgorA force-pushed update-firework from 10efb47ee8 to 20aba254bc 2025-03-15 20:40:45 +00:00 Compare
mxlgv approved these changes 2025-03-15 20:59:18 +00:00
mxlgv merged commit 20aba254bc into main 2025-03-15 20:59:30 +00:00
mxlgv deleted branch update-firework 2025-03-15 20:59:31 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
mxlgv
Labels
Clear labels
C
Category/Applications
Category/Drivers
Category/General
Category/Kernel
Category/Libraries
Eolite
FASM
FS
GSoC
This issue in GSoC program
 HardwareTested
HLL
Influence/Settings
Influence/Text/TYPO
IRCC
Kernel
Kind
Breaking
Breaking change that won't be backward compatible
Kind
Bug
Something is not working
Kind
Build
Kind
Documentation
Documentation changes
Kind
Enhancement
Improve existing functionality
Kind
Feature
New functionality
Kind
Security
This is security issue
Kind
Testing
Issue or pull request related to testing
Pay for the code
Paid task
PR
Conflicts
PR conflicts with main
PR
Dependent
This PR is dependent on another PR
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
PR
Ready to merge
Pull request is ready for merge
PR
Request changes
Changes requested in pull request
PR
Review required
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ace-dent Burer Doczom dunkaist IgorA Leency mxlgv ramenu rgimad sdongles Sweetbread
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KolibriOS/kolibrios#151
Delete Branch "update-firework"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?